* [PATCH] ALSA: hda: remove redundant assignment to variable timeout
@ 2020-02-08 22:27 Colin King
2020-02-10 7:30 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-02-08 22:27 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Baolin Wang, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable timeout is being assigned with the value 200 that is never
read, it is assigned a new value in a following do-loop. The assignment
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/pci/hda/hda_controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c
index 2609e391ce54..9765652a73d7 100644
--- a/sound/pci/hda/hda_controller.c
+++ b/sound/pci/hda/hda_controller.c
@@ -373,7 +373,7 @@ static int azx_get_sync_time(ktime_t *device,
u32 wallclk_ctr, wallclk_cycles;
bool direction;
u32 dma_select;
- u32 timeout = 200;
+ u32 timeout;
u32 retry_count = 0;
runtime = substream->runtime;
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda: remove redundant assignment to variable timeout
2020-02-08 22:27 [PATCH] ALSA: hda: remove redundant assignment to variable timeout Colin King
@ 2020-02-10 7:30 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2020-02-10 7:30 UTC (permalink / raw)
To: Colin King
Cc: Jaroslav Kysela, Takashi Iwai, Baolin Wang, alsa-devel,
kernel-janitors, linux-kernel
On Sat, 08 Feb 2020 23:27:56 +0100,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable timeout is being assigned with the value 200 that is never
> read, it is assigned a new value in a following do-loop. The assignment
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-10 7:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-08 22:27 [PATCH] ALSA: hda: remove redundant assignment to variable timeout Colin King
2020-02-10 7:30 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).