From: Takashi Iwai <tiwai@suse.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Johannes Stezenbach <js@sig21.net>,
Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC
Date: Tue, 05 Sep 2017 11:38:51 +0200 [thread overview]
Message-ID: <s5hwp5do578.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170905085341.ssukn2rtyf3q65bn@dell>
On Tue, 05 Sep 2017 10:53:41 +0200,
Lee Jones wrote:
>
> On Tue, 05 Sep 2017, Takashi Iwai wrote:
>
> > On Tue, 05 Sep 2017 10:10:49 +0200,
> > Lee Jones wrote:
> > >
> > > On Tue, 05 Sep 2017, Takashi Iwai wrote:
> > >
> > > > On Tue, 05 Sep 2017 09:24:51 +0200,
> > > > Lee Jones wrote:
> > > > >
> > > > > On Mon, 04 Sep 2017, Takashi Iwai wrote:
> > > > >
> > > > > > This patch adds the MFD driver for Dollar Cove (TI version) PMIC with
> > > > > > ACPI INT33F5 that is found on some Intel Cherry Trail devices.
> > > > > > The driver is based on the original work by Intel, found at:
> > > > > > https://github.com/01org/ProductionKernelQuilts
> > > > > >
> > > > > > This is a minimal version for adding the basic resources. Currently,
> > > > > > only ACPI PMIC opregion and the external power-button are used.
> > > > > >
> > > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=193891
> > > > > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > > > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > > > > > ---
> > > > > > v4->v5:
> > > > > > * Minor coding-style fixes suggested by Lee
> > > > > > * Put GPL text
> > > > > > v3->v4:
> > > > > > * no change for this patch
> > > > > > v2->v3:
> > > > > > * Rename dc_ti with chtdc_ti in all places
> > > > > > * Driver/kconfig renames accordingly
> > > > > > * Added acks by Andy and Mika
> > > > > > v1->v2:
> > > > > > * Minor cleanups as suggested by Andy
> > > > > >
> > > > > > drivers/mfd/Kconfig | 13 +++
> > > > > > drivers/mfd/Makefile | 1 +
> > > > > > drivers/mfd/intel_soc_pmic_chtdc_ti.c | 184 ++++++++++++++++++++++++++++++++++
> > > > > > 3 files changed, 198 insertions(+)
> > > > > > create mode 100644 drivers/mfd/intel_soc_pmic_chtdc_ti.c
> > > > >
> > > > > For my own reference:
> > > > > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> > > >
> > > > Thanks!
> > > >
> > > > Now the question is how to deal with these. It's no critical things,
> > > > so I'm OK to postpone for 4.15. OTOH, it's really a new
> > > > device-specific stuff, thus it can't break anything else, and it'd be
> > > > fairly safe to add it for 4.14 although it's at a bit late stage.
> > >
> > > Yes, you are over 2 weeks late for v4.14. It will have to be v4.15.
> >
> > OK, I'll ring your bells again once when 4.15 development is opened.
> >
> >
> > > > IMO, it'd be great if you can carry all stuff through MFD tree; or
> > > > create an immutable branch (again). But how to handle it, when to do
> > > > it, It's all up to you guys.
> > >
> > > If there aren't any build dependencies between the patches, each of
> > > the patches should be applied through their own trees. What are the
> > > build-time dependencies? Are there any?
> >
> > No, there is no strict build-time dependency. It's just that I don't
> > see it nice to have a commit for a dead code, partly for testing
> > purpose and partly for code consistency. But if this makes
> > maintenance easier, I'm happy with that, too, of course.
>
> There won't be any dead code. All of the subsystem trees are pulled
> into -next [0] where the build bots can operate on the patches as a
> whole.
But the merge order isn't guaranteed, i.e. at the commit of other tree
for this new stuff, it's a dead code without merging the MFD stuff
beforehand. e.g. Imagine to perform the git bisection. It's not
about the whole tree, but about the each commit.
And I won't be surprised if 0-day build bot gets a new feature to
inspect the kconfig files, spot a dead kconfig entry and warn
maintainers at each commit, too :)
thanks,
Takashi
next prev parent reply other threads:[~2017-09-05 9:38 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 14:43 [PATCH v5 0/3] Dollar Cove TI PMIC support for Intel Cherry Trail Takashi Iwai
2017-09-04 14:43 ` [PATCH v5 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC Takashi Iwai
2017-09-05 7:24 ` Lee Jones
2017-09-05 7:46 ` Takashi Iwai
2017-09-05 8:00 ` Hans de Goede
2017-09-05 8:11 ` Lee Jones
2017-09-05 8:12 ` Takashi Iwai
2017-09-05 8:10 ` Lee Jones
2017-09-05 8:20 ` Takashi Iwai
2017-09-05 8:53 ` Lee Jones
2017-09-05 9:38 ` Takashi Iwai [this message]
2017-09-05 10:31 ` Rafael J. Wysocki
2017-09-06 7:58 ` Lee Jones
2017-09-06 10:09 ` Rafael J. Wysocki
2017-09-06 10:47 ` Lee Jones
2017-09-06 10:52 ` Lee Jones
2017-09-06 22:19 ` Rafael J. Wysocki
2017-09-07 7:39 ` Lee Jones
2017-09-07 10:52 ` Rafael J. Wysocki
2017-09-07 11:07 ` Mika Westerberg
2017-09-07 10:59 ` Rafael J. Wysocki
2017-09-07 11:13 ` Lee Jones
2017-09-06 7:54 ` Lee Jones
2017-09-06 8:23 ` Takashi Iwai
2017-09-06 9:05 ` Lee Jones
2017-09-06 10:06 ` Takashi Iwai
2017-09-06 10:21 ` Rafael J. Wysocki
2017-09-06 10:50 ` Lee Jones
2017-09-06 10:40 ` Lee Jones
2017-09-06 10:58 ` Takashi Iwai
2017-09-06 11:01 ` Rafael J. Wysocki
2017-09-06 13:51 ` Lee Jones
2017-09-06 14:34 ` Takashi Iwai
2017-09-06 14:54 ` Lee Jones
2017-09-06 15:02 ` Takashi Iwai
2017-09-05 8:54 ` Lee Jones
2017-09-07 9:32 ` Takashi Iwai
2017-09-07 10:53 ` Lee Jones
2017-09-07 10:59 ` Rafael J. Wysocki
2017-09-07 11:17 ` Lee Jones
2017-09-07 11:44 ` Takashi Iwai
2017-09-07 12:24 ` Lee Jones
2017-09-07 13:11 ` Takashi Iwai
2017-09-07 13:22 ` Lee Jones
2017-09-07 8:00 ` Lee Jones
2017-09-04 14:43 ` [PATCH v5 2/3] platform/x86: Add support for Dollar Cove TI power button Takashi Iwai
2017-09-04 14:43 ` [PATCH v5 3/3] ACPI / PMIC: Add opregion driver for Intel Dollar Cove TI PMIC Takashi Iwai
2017-09-07 8:00 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2017-08-24 8:11 [PATCH v2 0/3] Dollar Cove TI PMIC support for Intel Cherry Trail Takashi Iwai
2017-08-24 8:11 ` [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC Takashi Iwai
2017-08-24 9:03 ` Mika Westerberg
2017-08-24 9:17 ` Andy Shevchenko
2017-09-04 13:37 ` Lee Jones
2017-09-04 13:50 ` Takashi Iwai
2017-09-05 7:25 ` Lee Jones
2017-09-05 7:41 ` Takashi Iwai
2017-09-05 8:14 ` Lee Jones
2017-08-24 8:11 ` [PATCH v2 2/3] platform/x86: Add support for Dollar Cove TI power button Takashi Iwai
2017-08-24 9:07 ` Mika Westerberg
2017-08-24 9:20 ` Andy Shevchenko
2017-08-24 9:45 ` Takashi Iwai
2017-08-24 11:47 ` Andy Shevchenko
2017-09-07 11:41 ` [PATCH v5 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC Takashi Iwai
2017-09-07 12:28 ` Lee Jones
2017-09-07 12:48 ` Takashi Iwai
2017-09-07 13:00 ` Lee Jones
2017-09-07 13:30 ` Takashi Iwai
2017-09-07 14:13 ` Lee Jones
2017-08-24 8:11 ` [PATCH v2 3/3] ACPI / PMIC: Add opregion driver for Intel " Takashi Iwai
2017-08-24 9:14 ` Mika Westerberg
2017-08-24 9:40 ` Takashi Iwai
2017-08-24 10:03 ` Takashi Iwai
2017-08-24 9:23 ` Andy Shevchenko
2017-08-24 9:43 ` Takashi Iwai
2017-08-24 9:27 ` [PATCH v2 0/3] Dollar Cove TI PMIC support for Intel Cherry Trail Andy Shevchenko
2017-08-24 9:38 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwp5do578.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=andy@infradead.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=js@sig21.net \
--cc=lee.jones@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).