linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for August 13
Date: Wed, 13 Aug 2008 15:37:15 +0200	[thread overview]
Message-ID: <s5hwsil829g.wl%tiwai@suse.de> (raw)
In-Reply-To: <20080813140811.030bb766@lxorguk.ukuu.org.uk>

At Wed, 13 Aug 2008 14:08:11 +0100,
Alan Cox wrote:
> 
> > When re-starting X, it complains that it cannot change to VT7.
> > Via strace, 
> 
> Does this fix it
> 
> @@ -838,6 +839,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk)
>  void __cleanup_signal(struct signal_struct *sig)
>  {
>  	exit_thread_group_keys(sig);
> +	tty_kref_put(sig->tty);
>  	kmem_cache_free(signal_cachep, sig);
>  }

Thanks, will give it a try.

The above can't be applied as is to next tree, so the following is
applied instead.


Takashi
---
diff --git a/kernel/fork.c b/kernel/fork.c
index 600a264..2353660 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -834,6 +834,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk)
 
 void __cleanup_signal(struct signal_struct *sig)
 {
+	tty_kref_put(sig->tty);
 	kmem_cache_free(signal_cachep, sig);
 }
 

  reply	other threads:[~2008-08-13 13:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13  7:24 linux-next: Tree for August 13 Stephen Rothwell
2008-08-13 11:05 ` Takashi Iwai
2008-08-13 11:42   ` Stephen Rothwell
2008-08-13 13:08   ` Alan Cox
2008-08-13 13:37     ` Takashi Iwai [this message]
2008-08-13 14:40       ` Takashi Iwai
2008-08-14  9:57         ` Takashi Iwai
2008-08-13 17:47 ` linux-next: Tree for August 13 (nfsd) Randy Dunlap
2008-08-13 18:09   ` J. Bruce Fields
2008-08-14  9:16     ` Thomas Petazzoni
2008-08-14 16:44       ` Randy Dunlap
2008-08-14 22:47       ` J. Bruce Fields
2008-08-18 11:01       ` Thomas Petazzoni
2009-08-13 10:05 linux-next: Tree for August 13 Stephen Rothwell
2010-08-13  3:13 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hwsil829g.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).