From: Takashi Iwai <tiwai@suse.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/4] firmware: Add the support for ZSTD-compressed firmware files
Date: Wed, 17 Feb 2021 15:21:39 +0100 [thread overview]
Message-ID: <s5hy2fm3hcc.wl-tiwai@suse.de> (raw)
In-Reply-To: <YC0lkDRXcR8Rg7+h@kroah.com>
On Wed, 17 Feb 2021 15:17:52 +0100,
Greg Kroah-Hartman wrote:
>
> On Wed, Feb 17, 2021 at 02:34:34PM +0100, Takashi Iwai wrote:
> > On Wed, 17 Feb 2021 14:24:19 +0100,
> > Luis Chamberlain wrote:
> > >
> > > On Wed, Jan 27, 2021 at 04:49:36PM +0100, Takashi Iwai wrote:
> > > > Due to the popular demands on ZSTD, here is a patch to add a support
> > > > of ZSTD-compressed firmware files via the direct firmware loader.
> > > > It's just like XZ-compressed file support, providing a decompressor
> > > > with ZSTD. Since ZSTD API can give the decompression size beforehand,
> > > > the code is even simpler than XZ.
> > > >
> > > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > >
> > > It also occurs to me that having a simple like #define HAVE_FIRMWARE_COMPRESS_ZSTD
> > > on include/linux/firmware.h would enable userspace to be aware (if they
> > > have kernel sources) to determine if the kernels supports this format.
> >
> > Extending that idea, we might want to have a sysfs entry showing the
> > supported formats instead? This will allow to judge dynamically.
>
> What could userspace do with that information?
Decide whether to store the firmware files on the system in the
supported compression format or not.
But admittedly it can be little help, as that's rather information you
want not for the running kernel but for the system to be installed...
Takashi
next prev parent reply other threads:[~2021-02-17 14:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 15:49 [PATCH RFC 0/4] firmware: Add ZSTD-compressed file support Takashi Iwai
2021-01-27 15:49 ` [PATCH RFC 1/4] firmware: Add the support for ZSTD-compressed firmware files Takashi Iwai
2021-02-17 13:16 ` Luis Chamberlain
2021-02-17 13:22 ` Takashi Iwai
2021-02-17 13:24 ` Luis Chamberlain
2021-02-17 13:34 ` Takashi Iwai
2021-02-17 14:17 ` Greg Kroah-Hartman
2021-02-17 14:21 ` Takashi Iwai [this message]
2021-01-27 15:49 ` [PATCH RFC 2/4] selftests: firmware: Simplify test patterns Takashi Iwai
2021-01-27 15:49 ` [PATCH RFC 3/4] selftest: firmware: Fix the request_firmware_into_buf() test for XZ format Takashi Iwai
2021-01-27 15:49 ` [PATCH RFC 4/4] selftest: firmware: Add ZSTD compressed file tests Takashi Iwai
2021-01-27 17:09 ` [PATCH RFC 0/4] firmware: Add ZSTD-compressed file support Greg Kroah-Hartman
2022-01-27 18:22 ` Hideki Yamane
2022-01-27 18:41 ` Greg Kroah-Hartman
2022-01-28 0:33 ` Hideki Yamane
2022-01-28 6:54 ` Greg Kroah-Hartman
2022-01-28 8:13 ` Takashi Iwai
2022-02-01 17:36 ` Hideki Yamane
2022-02-02 10:56 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy2fm3hcc.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).