From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A56C433E0 for ; Mon, 29 Mar 2021 11:23:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBD216188B for ; Mon, 29 Mar 2021 11:23:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232441AbhC2LXW (ORCPT ); Mon, 29 Mar 2021 07:23:22 -0400 Received: from mx2.suse.de ([195.135.220.15]:43474 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232454AbhC2LXG (ORCPT ); Mon, 29 Mar 2021 07:23:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C079AB46F; Mon, 29 Mar 2021 11:23:04 +0000 (UTC) Date: Mon, 29 Mar 2021 13:23:04 +0200 Message-ID: From: Takashi Iwai To: Ikjoon Jang Cc: Joakim Tjernlund , Jaroslav Kysela , alsa-devel@alsa-project.org, Takashi Iwai , Gregor Pintar , linux-usb@vger.kernel.org, Greg Kroah-Hartman , Dylan Robinson , Kai-Heng Feng , Olivia Mackintosh , Alexander Tsoy , open list Subject: Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect In-Reply-To: References: <20210324105153.2322881-1-ikjn@chromium.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Mar 2021 08:23:52 +0200, Ikjoon Jang wrote: > > On Wed, Mar 24, 2021 at 8:49 PM Takashi Iwai wrote: > > > > On Wed, 24 Mar 2021 13:03:14 +0100, > > Ikjoon Jang wrote: > > > > > > On Wed, Mar 24, 2021, 7:16 PM Joakim Tjernlund > > > wrote: > > > > > > On Wed, 2021-03-24 at 18:51 +0800, Ikjoon Jang wrote: > > > > Logitech ConferenceCam Connect is a compound USB device with UVC and > > > > UAC. Not 100% reproducible but sometimes it keeps responding STALL to > > > > every control transfer once it receives get_freq request. > > > > > > > > This patch adds 046d:0x084c to a snd_usb_get_sample_rate_quirk list. > > > > > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203419 > > > > Signed-off-by: Ikjoon Jang > > > > > > Most Logitech USB headset I got needs a delay in snd_usb_ctl_msg_quirk() > > > Have you tried to add say 20 ms delay in there? > > > > > > I didn't try that. But it sounds reasonable to me. > > > > > > let me try that quirk here. If that is the case, HID might need that delay > > > also. Logitech Group webcam had a similar problem on control xfer of > > > get_report from an another interface for HID. > > > > The Logitech devices with 046d:* should be covered generally in > > snd_usb_ctl_msg_quirk(), so I guess it's a different problem. > > But please check it first. > > > > > And 20ms can be too long if it's applied to every control transfer. I will > > > test the device with shorter delay if you didn't try it before. > > > > Actually the delay applied to Logitech devices is from 1 to 2ms, not > > 20ms. The 20ms delay is applied for some other devices. But if > > extending the delay fixes the problem, we need to reconsider the delay > > length. > > I tested this Logitech device with various delays 2..20ms > in snd_usb_ctl_msg_quirk() but it didn't help. > > Disregarding the delay between control transfers, > This device is always stuck at get_cur, responding STALL to all > control transfers. > > [ 24.045618] usb 1-1.2.1.1: 1:1: cannot get freq at ep 0x82 > [ 24.167475] usb 1-1.2.1.1: 2:0: cannot get min/max values for > control 2 (id 2) > [ 24.287393] usb 1-1.2.1.1: 6:0: cannot get min/max values for > control 2 (id 6) > [ 24.289854] usbcore: registered new interface driver snd-usb-audio > [ 24.877073] usb 1-1.2.1.1: 2:1: usb_set_interface failed (-32) > > And I've also found that in some other platforms (with the same kernel), > this device fails at get_freq - timeout with NYETs or NAKs (instead of STALL), > and succeeded in following set_interface even without any delays > I've tried but couldn't find any differences between the two. ;-( > > So until now, I think this approach of skipping get_rate is the only > one possible > workaround for Logitech Connect. OK, that makes sense, then. I applied your patch now. Thanks! Takashi