From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1942DC433E0 for ; Tue, 9 Jun 2020 11:45:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDCBD2078C for ; Tue, 9 Jun 2020 11:45:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729009AbgFILph (ORCPT ); Tue, 9 Jun 2020 07:45:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:51180 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726395AbgFILpg (ORCPT ); Tue, 9 Jun 2020 07:45:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 72577ACF1; Tue, 9 Jun 2020 11:45:38 +0000 (UTC) Date: Tue, 09 Jun 2020 13:45:34 +0200 Message-ID: From: Takashi Iwai To: Christoph Hellwig Cc: David Rientjes , "Alex Xu (Hello71)" , alsa-devel@alsa-project.org, bp@alien8.de, hch@infradead.org, hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@redhat.com, Pavel Machek , perex@perex.cz, tglx@linutronix.de, tiwai@suse.com, x86@kernel.org Subject: Re: next-0519 on thinkpad x60: sound related? window manager crash In-Reply-To: <20200609114059.GA1228@lst.de> References: <1591624340.z01ejtod28.none@localhost> <20200609054306.GA9606@lst.de> <20200609084305.GA21671@lst.de> <20200609091727.GA23814@lst.de> <20200609113123.GA547@lst.de> <20200609114059.GA1228@lst.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Jun 2020 13:40:59 +0200, Christoph Hellwig wrote: > > On Tue, Jun 09, 2020 at 01:38:46PM +0200, Takashi Iwai wrote: > > On Tue, 09 Jun 2020 13:31:23 +0200, > > Christoph Hellwig wrote: > > > > > > On Tue, Jun 09, 2020 at 11:31:20AM +0200, Takashi Iwai wrote: > > > > > > How would be a proper way to get the virtually mapped SG-buffer pages > > > > > > with coherent memory? (Also allowing user-space mmap, too) > > > > > > > > > > dma_mmap_coherent / dma_mmap_attrs for userspace. We don't really > > > > > have a good way for kernel space mappings. > > > > > > > > And that's the missing piece right now... :-< > > > > > > Can you point me to the relevant places (allocation and vmap mostly) > > > so that I can take a look at how to fix this mess? > > > > Found in sound/core/sgbuf.c. It's specific to x86. > > So it looks like we could just turn off CONFIG_SND_DMA_SGBUF and > be done with it? After all this works on other architectures > just fine.. Yes, for the sound stuff, something below should make things working. But it means that we'll lose the SG-buffer allocation and the allocation of large buffers might fail on some machines. Takashi --- a/sound/core/Kconfig +++ b/sound/core/Kconfig @@ -192,6 +192,6 @@ config SND_VMASTER config SND_DMA_SGBUF def_bool y - depends on X86 + depends on X86 && BROKEN source "sound/core/seq/Kconfig"