From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=/nvU=VK=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BE367C31E40
	for <linux-kernel@archiver.kernel.org>; Sat, 13 Jul 2019 17:44:20 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id A5D0820848
	for <linux-kernel@archiver.kernel.org>; Sat, 13 Jul 2019 17:44:20 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728043AbfGMRoT (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Sat, 13 Jul 2019 13:44:19 -0400
Received: from mx2.suse.de ([195.135.220.15]:38220 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1727818AbfGMRoT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 13 Jul 2019 13:44:19 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
        by mx1.suse.de (Postfix) with ESMTP id BC494B922;
        Sat, 13 Jul 2019 17:44:17 +0000 (UTC)
Date:   Sat, 13 Jul 2019 19:44:17 +0200
Message-ID: <s5hzhlhg77y.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     " Wasko, Michal " <michal.wasko@linux.intel.com>
Cc:     <alsa-devel@alsa-project.org>,
        Hariprasad Kelam <hariprasad.kelam@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Allison Randal <allison@lohutok.net>,
        Jaroslav Kysela <perex@perex.cz>,
        Richard Fontana <rfontana@redhat.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] sound: pci: emu10k1: Remove unneeded variable "change"
In-Reply-To: <d92d60c5-2a59-0d1f-05fa-a8ab13f6bdd0@linux.intel.com>
References: <20190711171726.GA4356@hari-Inspiron-1545>
        <d92d60c5-2a59-0d1f-05fa-a8ab13f6bdd0@linux.intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 12 Jul 2019 10:06:23 +0200,
 Wasko, Michal  wrote:
> 
> 
> On 7/11/2019 7:17 PM, Hariprasad Kelam wrote:
> 
>     fix below issue reported by coccicheck
>     sound/pci/emu10k1/emu10k1x.c:1077:5-11: Unneeded variable: "change".
>     Return "0" on line 1092
>     
>     Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
>     
> Since the  function always return 0 and you perform code clean-up then
> maybe it would be a good idea to just change function to void instead
> of returning int value which does not seem to have use.

No, it's a callback function.


Takashi