From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D586AC5B578 for ; Wed, 3 Jul 2019 08:32:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DFF32189E for ; Wed, 3 Jul 2019 08:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727264AbfGCIcK (ORCPT ); Wed, 3 Jul 2019 04:32:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:50476 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726400AbfGCIcJ (ORCPT ); Wed, 3 Jul 2019 04:32:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BD120AD3A; Wed, 3 Jul 2019 08:32:08 +0000 (UTC) Date: Wed, 03 Jul 2019 10:32:08 +0200 Message-ID: From: Takashi Iwai To: "Wasko, Michal" Cc: nick83ola , alsa-devel@alsa-project.org, info@jensverwiebe.de, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Richard Fontana , Jussi Laako , Thomas Gleixner , Allison Randal Subject: Re: [alsa-devel] [PATCH] ALSA: usb-audio: fix Line6 Helix audio format rates In-Reply-To: <38462424-4e2b-bdbd-f7cc-ea94385924e0@linux.intel.com> References: <20190702004439.30131-1-nick83ola@gmail.com> <4181a467-5332-c256-5124-513a0343ec70@linux.intel.com> <38462424-4e2b-bdbd-f7cc-ea94385924e0@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 03 Jul 2019 10:26:31 +0200, Wasko, Michal wrote: > > >> My idea is that if line6 in the future fixes their code (they are quite active > >> on the helix line) the call will not fail and we get a proper device without > >> quirks. > >> But If the driver fail to get the clock this settings works as a "failsafe" > >> and get the device working. > >> I also tried to contact their support but they don't care a lot about Linux > >> for now :-( > > The fallback might be good, but I'm not sure whether there are many > > devices that hit the same problem. If we encounter more, let's try to > > make it as a fallback. > > thanks, > > > > Takashi > Since there is a chance that the issue will be addressed in USB device FW > thanthe fallback mechanism will make sense. It would cover eventual future > scenario withdevices that will have the issue fixed. Fair enough. Let's handle it as fallback, then. thanks, Takashi