From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753782Ab2HUIBH (ORCPT ); Tue, 21 Aug 2012 04:01:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56711 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752592Ab2HUIBD (ORCPT ); Tue, 21 Aug 2012 04:01:03 -0400 Date: Tue, 21 Aug 2012 10:01:02 +0200 Message-ID: From: Takashi Iwai To: Ondrej Zary Cc: alsa-devel@alsa-project.org, Kernel development list Subject: Re: [alsa-devel] [PATCH] introduce snd-cmi8328: C-Media CMI8328 driver In-Reply-To: <201208202239.52426.linux@rainbow-software.org> References: <201208202239.52426.linux@rainbow-software.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 20 Aug 2012 22:39:51 +0200, Ondrej Zary wrote: > > Introduce snd-cmi8328 driver for C-Media CMI8328-based sound cards, such as > AudioExcel AV500. > > It supports PCM playback and capture (full-duplex) through wss_lib, gameport, > OPL3 and MPU401. The AV500 card has onboard Dream wavetable synth connected > to the MPU401 port and Aux 1 input internally which works too. > The CDROM interface is not supported (as the drivers for these CDROMs were > removed from the kernel some time ago). > > A separate driver is needed because CMI8328 is completely different chip to > CMI8329/CMI8330. It's configured by magic registers (there's no PnP). Sound is > provided by a real WSS codec (CS4231A) and the SB part is just a SB Pro > emulation (for DOS games, useless for Linux). > > When SB is enabled, the CMI8328 chip disables access to the WSS codec, > emulates SoundBlaster on one side and outputs sound data to the codec - so SB > and WSS can't work together with this card. The WSS codec can do full duplex > by itself so there's no need for crazy things like snd-cmi8330 does > (combining SB and WSS parts into one driver). > > Signed-off-by: Ondrej Zary OK, I merged it now for 3.7 tree. thanks, Takashi > > commit ebd26fe68c73eb979ace14b51a4fbdd899233952 > Author: Ondrej Zary > Date: Thu Aug 2 09:17:57 2012 +0200 > > introduce snd-cmi8328: C-Media CMI8328 driver > > Introduce snd-cmi8328 driver for C-Media CMI8328-based sound cards, such as AudioExcel AV500. > > It supports PCM playback and capture (full-duplex) through wss_lib, gameport, > OPL3 and MPU401. The AV500 card has onboard Dream wavetable synth connected > to the MPU401 port and Aux 1 input internally which works too. > The CDROM interface is not supported (as the drivers for these CDROMs were > removed from the kernel some time ago). > > diff --git a/sound/isa/Kconfig b/sound/isa/Kconfig > index 52064cf..a38d964 100644 > --- a/sound/isa/Kconfig > +++ b/sound/isa/Kconfig > @@ -117,6 +117,18 @@ config SND_AZT2320 > To compile this driver as a module, choose M here: the module > will be called snd-azt2320. > > +config SND_CMI8328 > + tristate "C-Media CMI8328" > + select SND_WSS_LIB > + select SND_OPL3_LIB > + select SND_MPU401_UART > + help > + Say Y here to include support for soundcards based on the > + C-Media CMI8328 chip. > + > + To compile this driver as a module, choose M here: the module > + will be called snd-cmi8328. > + > config SND_CMI8330 > tristate "C-Media CMI8330" > select SND_WSS_LIB > diff --git a/sound/isa/Makefile b/sound/isa/Makefile > index 8d781e4..9a15f14 100644 > --- a/sound/isa/Makefile > +++ b/sound/isa/Makefile > @@ -6,6 +6,7 @@ > snd-adlib-objs := adlib.o > snd-als100-objs := als100.o > snd-azt2320-objs := azt2320.o > +snd-cmi8328-objs := cmi8328.o > snd-cmi8330-objs := cmi8330.o > snd-es18xx-objs := es18xx.o > snd-opl3sa2-objs := opl3sa2.o > @@ -16,6 +17,7 @@ snd-sscape-objs := sscape.o > obj-$(CONFIG_SND_ADLIB) += snd-adlib.o > obj-$(CONFIG_SND_ALS100) += snd-als100.o > obj-$(CONFIG_SND_AZT2320) += snd-azt2320.o > +obj-$(CONFIG_SND_CMI8328) += snd-cmi8328.o > obj-$(CONFIG_SND_CMI8330) += snd-cmi8330.o > obj-$(CONFIG_SND_ES18XX) += snd-es18xx.o > obj-$(CONFIG_SND_OPL3SA2) += snd-opl3sa2.o > diff --git a/sound/isa/cmi8328.c b/sound/isa/cmi8328.c > new file mode 100644 > index 0000000..aefafff > --- /dev/null > +++ b/sound/isa/cmi8328.c > @@ -0,0 +1,482 @@ > +/* > + * Driver for C-Media CMI8328-based soundcards, such as AudioExcel AV500 > + * Copyright (c) 2012 Ondrej Zary > + * > + * AudioExcel AV500 card consists of: > + * - CMI8328 - main chip (SB Pro emulation, gameport, OPL3, MPU401, CD-ROM) > + * - CS4231A - WSS codec > + * - Dream SAM9233+GMS950400+RAM+ROM: Wavetable MIDI, connected to MPU401 > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#define SNDRV_LEGACY_FIND_FREE_IOPORT > +#define SNDRV_LEGACY_FIND_FREE_IRQ > +#define SNDRV_LEGACY_FIND_FREE_DMA > +#include > + > +MODULE_AUTHOR("Ondrej Zary "); > +MODULE_DESCRIPTION("C-Media CMI8328"); > +MODULE_LICENSE("GPL"); > + > +#if defined(CONFIG_GAMEPORT) || defined(CONFIG_GAMEPORT_MODULE) > +#define SUPPORT_JOYSTICK 1 > +#endif > + > +/* I/O port is configured by jumpers on the card to one of these */ > +static int cmi8328_ports[] = { 0x530, 0xe80, 0xf40, 0x604 }; > +#define CMI8328_MAX ARRAY_SIZE(cmi8328_ports) > + > +static int index[CMI8328_MAX] = {[0 ... (CMI8328_MAX-1)] = -1}; > +static char *id[CMI8328_MAX] = {[0 ... (CMI8328_MAX-1)] = NULL}; > +static long port[CMI8328_MAX] = {[0 ... (CMI8328_MAX-1)] = SNDRV_AUTO_PORT}; > +static int irq[CMI8328_MAX] = {[0 ... (CMI8328_MAX-1)] = SNDRV_AUTO_IRQ}; > +static int dma1[CMI8328_MAX] = {[0 ... (CMI8328_MAX-1)] = SNDRV_AUTO_DMA}; > +static int dma2[CMI8328_MAX] = {[0 ... (CMI8328_MAX-1)] = SNDRV_AUTO_DMA}; > +static long mpuport[CMI8328_MAX] = {[0 ... (CMI8328_MAX-1)] = SNDRV_AUTO_PORT}; > +static int mpuirq[CMI8328_MAX] = {[0 ... (CMI8328_MAX-1)] = SNDRV_AUTO_IRQ}; > +#ifdef SUPPORT_JOYSTICK > +static bool gameport[CMI8328_MAX] = {[0 ... (CMI8328_MAX-1)] = true}; > +#endif > + > +module_param_array(index, int, NULL, 0444); > +MODULE_PARM_DESC(index, "Index value for CMI8328 soundcard."); > +module_param_array(id, charp, NULL, 0444); > +MODULE_PARM_DESC(id, "ID string for CMI8328 soundcard."); > + > +module_param_array(port, long, NULL, 0444); > +MODULE_PARM_DESC(port, "Port # for CMI8328 driver."); > +module_param_array(irq, int, NULL, 0444); > +MODULE_PARM_DESC(irq, "IRQ # for CMI8328 driver."); > +module_param_array(dma1, int, NULL, 0444); > +MODULE_PARM_DESC(dma1, "DMA1 for CMI8328 driver."); > +module_param_array(dma2, int, NULL, 0444); > +MODULE_PARM_DESC(dma2, "DMA2 for CMI8328 driver."); > + > +module_param_array(mpuport, long, NULL, 0444); > +MODULE_PARM_DESC(mpuport, "MPU-401 port # for CMI8328 driver."); > +module_param_array(mpuirq, int, NULL, 0444); > +MODULE_PARM_DESC(mpuirq, "IRQ # for CMI8328 MPU-401 port."); > +#ifdef SUPPORT_JOYSTICK > +module_param_array(gameport, bool, NULL, 0444); > +MODULE_PARM_DESC(gameport, "Enable gameport."); > +#endif > + > +struct snd_cmi8328 { > + u16 port; > + u8 cfg[3]; > + u8 wss_cfg; > + struct snd_card *card; > + struct snd_wss *wss; > +#ifdef SUPPORT_JOYSTICK > + struct gameport *gameport; > +#endif > +}; > + > +/* CMI8328 configuration registers */ > +#define CFG1 0x61 > +#define CFG1_SB_DISABLE (1 << 0) > +#define CFG1_GAMEPORT (1 << 1) > +/* > + * bit 0: SB: 0=enabled, 1=disabled > + * bit 1: gameport: 0=disabled, 1=enabled > + * bits 2-4: SB IRQ: 001=3, 010=5, 011=7, 100=9, 101=10, 110=11 > + * bits 5-6: SB DMA: 00=disabled (when SB disabled), 01=DMA0, 10=DMA1, 11=DMA3 > + * bit 7: SB port: 0=0x220, 1=0x240 > + */ > +#define CFG2 0x62 > +#define CFG2_MPU_ENABLE (1 << 2) > +/* > + * bits 0-1: CD-ROM mode: 00=disabled, 01=Panasonic, 10=Sony/Mitsumi/Wearnes, > + 11=IDE > + * bit 2: MPU401: 0=disabled, 1=enabled > + * bits 3-4: MPU401 IRQ: 00=3, 01=5, 10=7, 11=9, > + * bits 5-7: MPU401 port: 000=0x300, 001=0x310, 010=0x320, 011=0x330, 100=0x332, > + 101=0x334, 110=0x336 > + */ > +#define CFG3 0x63 > +/* > + * bits 0-2: CD-ROM IRQ: 000=disabled, 001=3, 010=5, 011=7, 100=9, 101=10, > + 110=11 > + * bits 3-4: CD-ROM DMA: 00=disabled, 01=DMA0, 10=DMA1, 11=DMA3 > + * bits 5-7: CD-ROM port: 000=0x300, 001=0x310, 010=0x320, 011=0x330, 100=0x340, > + 101=0x350, 110=0x360, 111=0x370 > + */ > + > +static u8 snd_cmi8328_cfg_read(u16 port, u8 reg) > +{ > + outb(0x43, port + 3); > + outb(0x21, port + 3); > + outb(reg, port + 3); > + return inb(port); > +} > + > +static void snd_cmi8328_cfg_write(u16 port, u8 reg, u8 val) > +{ > + outb(0x43, port + 3); > + outb(0x21, port + 3); > + outb(reg, port + 3); > + outb(val, port + 3); /* yes, value goes to the same port as index */ > +} > + > +static void snd_cmi8328_cfg_save(u16 port, u8 cfg[]) > +{ > + cfg[0] = snd_cmi8328_cfg_read(port, CFG1); > + cfg[1] = snd_cmi8328_cfg_read(port, CFG2); > + cfg[2] = snd_cmi8328_cfg_read(port, CFG3); > +} > + > +static void snd_cmi8328_cfg_restore(u16 port, u8 cfg[]) > +{ > + snd_cmi8328_cfg_write(port, CFG1, cfg[0]); > + snd_cmi8328_cfg_write(port, CFG2, cfg[1]); > + snd_cmi8328_cfg_write(port, CFG3, cfg[2]); > +} > + > +static int __devinit snd_cmi8328_mixer(struct snd_wss *chip) > +{ > + struct snd_card *card; > + struct snd_ctl_elem_id id1, id2; > + int err; > + > + card = chip->card; > + > + memset(&id1, 0, sizeof(id1)); > + memset(&id2, 0, sizeof(id2)); > + id1.iface = id2.iface = SNDRV_CTL_ELEM_IFACE_MIXER; > + /* rename AUX0 switch to CD */ > + strcpy(id1.name, "Aux Playback Switch"); > + strcpy(id2.name, "CD Playback Switch"); > + err = snd_ctl_rename_id(card, &id1, &id2); > + if (err < 0) { > + snd_printk(KERN_ERR "error renaming control\n"); > + return err; > + } > + /* rename AUX0 volume to CD */ > + strcpy(id1.name, "Aux Playback Volume"); > + strcpy(id2.name, "CD Playback Volume"); > + err = snd_ctl_rename_id(card, &id1, &id2); > + if (err < 0) { > + snd_printk(KERN_ERR "error renaming control\n"); > + return err; > + } > + /* rename AUX1 switch to Synth */ > + strcpy(id1.name, "Aux Playback Switch"); > + id1.index = 1; > + strcpy(id2.name, "Synth Playback Switch"); > + err = snd_ctl_rename_id(card, &id1, &id2); > + if (err < 0) { > + snd_printk(KERN_ERR "error renaming control\n"); > + return err; > + } > + /* rename AUX1 volume to Synth */ > + strcpy(id1.name, "Aux Playback Volume"); > + id1.index = 1; > + strcpy(id2.name, "Synth Playback Volume"); > + err = snd_ctl_rename_id(card, &id1, &id2); > + if (err < 0) { > + snd_printk(KERN_ERR "error renaming control\n"); > + return err; > + } > + > + return 0; > +} > + > +/* find index of an item in "-1"-ended array */ > +int array_find(int array[], int item) > +{ > + int i; > + > + for (i = 0; array[i] != -1; i++) > + if (array[i] == item) > + return i; > + > + return -1; > +} > +/* the same for long */ > +int array_find_l(long array[], long item) > +{ > + int i; > + > + for (i = 0; array[i] != -1; i++) > + if (array[i] == item) > + return i; > + > + return -1; > +} > + > +static int __devinit snd_cmi8328_probe(struct device *pdev, unsigned int ndev) > +{ > + struct snd_card *card; > + struct snd_opl3 *opl3; > + struct snd_cmi8328 *cmi; > +#ifdef SUPPORT_JOYSTICK > + struct resource *res; > +#endif > + int err, pos; > + static long mpu_ports[] = { 0x330, 0x300, 0x310, 0x320, 0x332, 0x334, > + 0x336, -1 }; > + static u8 mpu_port_bits[] = { 3, 0, 1, 2, 4, 5, 6 }; > + static int mpu_irqs[] = { 9, 7, 5, 3, -1 }; > + static u8 mpu_irq_bits[] = { 3, 2, 1, 0 }; > + static int irqs[] = { 9, 10, 11, 7, -1 }; > + static u8 irq_bits[] = { 2, 3, 4, 1 }; > + static int dma1s[] = { 3, 1, 0, -1 }; > + static u8 dma_bits[] = { 3, 2, 1 }; > + static int dma2s[][2] = { {1, -1}, {0, -1}, {-1, -1}, {0, -1} }; > + u16 port = cmi8328_ports[ndev]; > + u8 val; > + > + /* 0xff is invalid configuration (but settable - hope it isn't set) */ > + if (snd_cmi8328_cfg_read(port, CFG1) == 0xff) > + return -ENODEV; > + /* the SB disable bit must NEVER EVER be cleared or the WSS dies */ > + snd_cmi8328_cfg_write(port, CFG1, CFG1_SB_DISABLE); > + if (snd_cmi8328_cfg_read(port, CFG1) != CFG1_SB_DISABLE) > + return -ENODEV; > + /* disable everything first */ > + snd_cmi8328_cfg_write(port, CFG2, 0); /* disable CDROM and MPU401 */ > + snd_cmi8328_cfg_write(port, CFG3, 0); /* disable CDROM IRQ and DMA */ > + > + if (irq[ndev] == SNDRV_AUTO_IRQ) { > + irq[ndev] = snd_legacy_find_free_irq(irqs); > + if (irq[ndev] < 0) { > + snd_printk(KERN_ERR "unable to find a free IRQ\n"); > + return -EBUSY; > + } > + } > + if (dma1[ndev] == SNDRV_AUTO_DMA) { > + dma1[ndev] = snd_legacy_find_free_dma(dma1s); > + if (dma1[ndev] < 0) { > + snd_printk(KERN_ERR "unable to find a free DMA1\n"); > + return -EBUSY; > + } > + } > + if (dma2[ndev] == SNDRV_AUTO_DMA) { > + dma2[ndev] = snd_legacy_find_free_dma(dma2s[dma1[ndev] % 4]); > + if (dma2[ndev] < 0) { > + snd_printk(KERN_WARNING "unable to find a free DMA2, full-duplex will not work\n"); > + dma2[ndev] = -1; > + } > + } > + /* configure WSS IRQ... */ > + pos = array_find(irqs, irq[ndev]); > + if (pos < 0) { > + snd_printk(KERN_ERR "invalid IRQ %d\n", irq[ndev]); > + return -EINVAL; > + } > + val = irq_bits[pos] << 3; > + /* ...and DMA... */ > + pos = array_find(dma1s, dma1[ndev]); > + if (pos < 0) { > + snd_printk(KERN_ERR "invalid DMA1 %d\n", dma1[ndev]); > + return -EINVAL; > + } > + val |= dma_bits[pos]; > + /* ...and DMA2 */ > + if (dma2[ndev] >= 0 && dma1[ndev] != dma2[ndev]) { > + pos = array_find(dma2s[dma1[ndev]], dma2[ndev]); > + if (pos < 0) { > + snd_printk(KERN_ERR "invalid DMA2 %d\n", dma2[ndev]); > + return -EINVAL; > + } > + val |= 0x04; /* enable separate capture DMA */ > + } > + outb(val, port); > + > + err = snd_card_create(index[ndev], id[ndev], THIS_MODULE, > + sizeof(struct snd_cmi8328), &card); > + if (err < 0) > + return err; > + cmi = card->private_data; > + cmi->card = card; > + cmi->port = port; > + cmi->wss_cfg = val; > + snd_card_set_dev(card, pdev); > + > + err = snd_wss_create(card, port + 4, -1, irq[ndev], dma1[ndev], > + dma2[ndev], WSS_HW_DETECT, 0, &cmi->wss); > + if (err < 0) > + goto error; > + > + err = snd_wss_pcm(cmi->wss, 0, NULL); > + if (err < 0) > + goto error; > + > + err = snd_wss_mixer(cmi->wss); > + if (err < 0) > + goto error; > + err = snd_cmi8328_mixer(cmi->wss); > + if (err < 0) > + goto error; > + > + if (snd_wss_timer(cmi->wss, 0, NULL) < 0) > + snd_printk(KERN_WARNING "error initializing WSS timer\n"); > + > + if (mpuport[ndev] == SNDRV_AUTO_PORT) { > + mpuport[ndev] = snd_legacy_find_free_ioport(mpu_ports, 2); > + if (mpuport[ndev] < 0) > + snd_printk(KERN_ERR "unable to find a free MPU401 port\n"); > + } > + if (mpuirq[ndev] == SNDRV_AUTO_IRQ) { > + mpuirq[ndev] = snd_legacy_find_free_irq(mpu_irqs); > + if (mpuirq[ndev] < 0) > + snd_printk(KERN_ERR "unable to find a free MPU401 IRQ\n"); > + } > + /* enable and configure MPU401 */ > + if (mpuport[ndev] > 0 && mpuirq[ndev] > 0) { > + val = CFG2_MPU_ENABLE; > + pos = array_find_l(mpu_ports, mpuport[ndev]); > + if (pos < 0) > + snd_printk(KERN_WARNING "invalid MPU401 port 0x%lx\n", > + mpuport[ndev]); > + else { > + val |= mpu_port_bits[pos] << 5; > + pos = array_find(mpu_irqs, mpuirq[ndev]); > + if (pos < 0) > + snd_printk(KERN_WARNING "invalid MPU401 IRQ %d\n", > + mpuirq[ndev]); > + else { > + val |= mpu_irq_bits[pos] << 3; > + snd_cmi8328_cfg_write(port, CFG2, val); > + if (snd_mpu401_uart_new(card, 0, > + MPU401_HW_MPU401, mpuport[ndev], > + 0, mpuirq[ndev], NULL) < 0) > + snd_printk(KERN_ERR "error initializing MPU401\n"); > + } > + } > + } > + /* OPL3 is hardwired to 0x388 and cannot be disabled */ > + if (snd_opl3_create(card, 0x388, 0x38a, OPL3_HW_AUTO, 0, &opl3) < 0) > + snd_printk(KERN_ERR "error initializing OPL3\n"); > + else > + if (snd_opl3_hwdep_new(opl3, 0, 1, NULL) < 0) > + snd_printk(KERN_WARNING "error initializing OPL3 hwdep\n"); > + > + strcpy(card->driver, "CMI8328"); > + strcpy(card->shortname, "C-Media CMI8328"); > + sprintf(card->longname, "%s at 0x%lx, irq %d, dma %d,%d", > + card->shortname, cmi->wss->port, irq[ndev], dma1[ndev], > + (dma2[ndev] >= 0) ? dma2[ndev] : dma1[ndev]); > + > + dev_set_drvdata(pdev, card); > + err = snd_card_register(card); > + if (err < 0) > + goto error; > +#ifdef SUPPORT_JOYSTICK > + if (!gameport[ndev]) > + return 0; > + /* gameport is hardwired to 0x200 */ > + res = request_region(0x200, 8, "CMI8328 gameport"); > + if (!res) > + snd_printk(KERN_WARNING "unable to allocate gameport I/O port\n"); > + else { > + struct gameport *gp = cmi->gameport = gameport_allocate_port(); > + if (!cmi->gameport) > + release_and_free_resource(res); > + else { > + gameport_set_name(gp, "CMI8328 Gameport"); > + gameport_set_phys(gp, "%s/gameport0", dev_name(pdev)); > + gameport_set_dev_parent(gp, pdev); > + gp->io = 0x200; > + gameport_set_port_data(gp, res); > + /* Enable gameport */ > + snd_cmi8328_cfg_write(port, CFG1, > + CFG1_SB_DISABLE | CFG1_GAMEPORT); > + gameport_register_port(gp); > + } > + } > +#endif > + return 0; > +error: > + snd_card_free(card); > + > + return err; > +} > + > +static int __devexit snd_cmi8328_remove(struct device *pdev, unsigned int dev) > +{ > + struct snd_card *card = dev_get_drvdata(pdev); > +#ifdef SUPPORT_JOYSTICK > + struct snd_cmi8328 *cmi = card->private_data; > + if (cmi->gameport) { > + struct resource *res = gameport_get_port_data(cmi->gameport); > + gameport_unregister_port(cmi->gameport); > + release_and_free_resource(res); > + } > +#endif > + /* disable everything */ > + snd_cmi8328_cfg_write(cmi->port, CFG1, CFG1_SB_DISABLE); > + snd_cmi8328_cfg_write(cmi->port, CFG2, 0); > + snd_cmi8328_cfg_write(cmi->port, CFG3, 0); > + snd_card_free(card); > + dev_set_drvdata(pdev, NULL); > + return 0; > +} > + > +#ifdef CONFIG_PM > +static int snd_cmi8328_suspend(struct device *pdev, unsigned int n, > + pm_message_t state) > +{ > + struct snd_card *card = dev_get_drvdata(pdev); > + struct snd_cmi8328 *cmi; > + > + if (!card) /* ignore absent devices */ > + return 0; > + cmi = card->private_data; > + snd_cmi8328_cfg_save(cmi->port, cmi->cfg); > + snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); > + snd_pcm_suspend_all(cmi->wss->pcm); > + cmi->wss->suspend(cmi->wss); > + > + return 0; > +} > + > +static int snd_cmi8328_resume(struct device *pdev, unsigned int n) > +{ > + struct snd_card *card = dev_get_drvdata(pdev); > + struct snd_cmi8328 *cmi; > + > + if (!card) /* ignore absent devices */ > + return 0; > + cmi = card->private_data; > + snd_cmi8328_cfg_restore(cmi->port, cmi->cfg); > + outb(cmi->wss_cfg, cmi->port); > + cmi->wss->resume(cmi->wss); > + snd_power_change_state(card, SNDRV_CTL_POWER_D0); > + > + return 0; > +} > +#endif > + > +static struct isa_driver snd_cmi8328_driver = { > + .probe = snd_cmi8328_probe, > + .remove = __devexit_p(snd_cmi8328_remove), > +#ifdef CONFIG_PM > + .suspend = snd_cmi8328_suspend, > + .resume = snd_cmi8328_resume, > +#endif > + .driver = { > + .name = "cmi8328" > + }, > +}; > + > +static int __init alsa_card_cmi8328_init(void) > +{ > + return isa_register_driver(&snd_cmi8328_driver, CMI8328_MAX); > +} > + > +static void __exit alsa_card_cmi8328_exit(void) > +{ > + isa_unregister_driver(&snd_cmi8328_driver); > +} > + > +module_init(alsa_card_cmi8328_init) > +module_exit(alsa_card_cmi8328_exit) > > > -- > Ondrej Zary > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >