From: Takashi Iwai <tiwai@suse.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Zwane Mwaikambo <zwane@arm.linux.org.uk>
Subject: Re: [PATCH] opl3sa2: fix adding second dma channel
Date: Wed, 25 Jan 2006 15:38:51 +0100 [thread overview]
Message-ID: <s5hzmlkbcec.wl%tiwai@suse.de> (raw)
In-Reply-To: <20060125004249.GC3234@mipter.zuzino.mipt.ru>
At Wed, 25 Jan 2006 03:42:49 +0300,
Alexey Dobriyan wrote:
>
> dma2 is a global array. sprintf below suggests there was a typo.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Thanks, I applied both patches to ALSA tree.
Takashi
> ---
>
> sound/isa/opl3sa2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/sound/isa/opl3sa2.c
> +++ b/sound/isa/opl3sa2.c
> @@ -721,7 +721,7 @@ static int __devinit snd_opl3sa2_probe(s
> }
> sprintf(card->longname, "%s at 0x%lx, irq %d, dma %d",
> card->shortname, chip->port, xirq, xdma1);
> - if (dma2 >= 0)
> + if (xdma2 >= 0)
> sprintf(card->longname + strlen(card->longname), "&%d", xdma2);
>
> return snd_card_register(card);
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2006-01-25 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 0:42 [PATCH] opl3sa2: fix adding second dma channel Alexey Dobriyan
2006-01-25 14:38 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzmlkbcec.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).