From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36653C433ED for ; Tue, 18 May 2021 22:38:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14D9A6113C for ; Tue, 18 May 2021 22:38:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352792AbhERWjk (ORCPT ); Tue, 18 May 2021 18:39:40 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:60422 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230251AbhERWji (ORCPT ); Tue, 18 May 2021 18:39:38 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 2DB0313D005; Tue, 18 May 2021 18:38:20 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=date:from :to:cc:subject:in-reply-to:message-id:references:mime-version :content-type; s=sasl; bh=5j1QweKqXcL61vmqOwGvwHyyoRPXFIgZ5di/bk eivc4=; b=SFAUJ2ihK8uJBsyjRofcLHTo18jLrEK1y2qA59nzz7tAwyqCMcirdo FUZx2MCEr75sfqMZDm9gJzxgYvV8ISbQEpNej9hdF04XiMasZ5d8xGGZmSLdXAMf rix3QgJvw4ybNM5GEehqpEubdp9ytZW/mYhApJS0NqixuTE6OIVo8= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 254DA13D004; Tue, 18 May 2021 18:38:20 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=fluxnic.net; h=date:from:to:cc:subject:in-reply-to:message-id:references:mime-version:content-type; s=2016-12.pbsmtp; bh=5j1QweKqXcL61vmqOwGvwHyyoRPXFIgZ5di/bkeivc4=; b=uCpfa+7iuUeLrgS3q8J0Fh1pqM+Ll6JdYd0HHhkHSP25wqkU1B/SWCYPmMlHFhJERBczQt8PBqnxj7TEULMr02cw69D01hd5CVAAFxdHzhYCwYqThI3gaSSvmF4YkemenTIO/wgkY1ns+W4+oBZWRYXNBMizRg2gwheiprnfyhg= Received: from yoda.home (unknown [96.21.170.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 217DF13D003; Tue, 18 May 2021 18:38:17 -0400 (EDT) (envelope-from nico@fluxnic.net) Received: from xanadu.home (xanadu.home [192.168.2.2]) by yoda.home (Postfix) with ESMTPSA id 639992DA0092; Tue, 18 May 2021 18:38:15 -0400 (EDT) Date: Tue, 18 May 2021 18:38:15 -0400 (EDT) From: Nicolas Pitre To: Linus Walleij cc: "Russell King (Oracle)" , Yanfei Xu , Mike Rapoport , Ard Biesheuvel , Andrew Morton , Hailong liu , Tian Tao , Linux ARM , linux-kernel Subject: Re: [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start In-Reply-To: Message-ID: References: <20210518120633.GW12395@shell.armlinux.org.uk> <8q526rs-853n-5q80-r9pn-87sso759r13@syhkavp.arg> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Pobox-Relay-ID: BD270060-B829-11EB-9684-E43E2BB96649-78420484!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 May 2021, Linus Walleij wrote: > On Wed, May 19, 2021 at 12:32 AM Nicolas Pitre wrote: > > On Tue, 18 May 2021, Nicolas Pitre wrote: > > > On Wed, 19 May 2021, Linus Walleij wrote: > > > > please fold in a comment > > > > with some explanation of that (240 << 20) thing, > > > > > > That's an alternative (and deprecated) way to write MB(240). > > > > And it seems that MB() isn't globally defined either. Oh well. > > I suppose a comment saying "set vmalloc to be 240 MB" is fair enough. The comment was some 5 lines below (not ideal I know). Nicolas