linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Coady <grant_lkml@dodo.com.au>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Grant Coady <gcoady.lk@gmail.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Mikael Pettersson <mikpe@it.uu.se>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ATA Kconfig cleanup: sort the driver list and modify some text
Date: Thu, 21 Aug 2008 10:16:49 +1000	[thread overview]
Message-ID: <tecpa4928hh8kahc53p019sr7nclg8kbjr@4ax.com> (raw)
In-Reply-To: <m3vdxvqnbb.fsf@maximus.localdomain>

On Thu, 21 Aug 2008 01:27:52 +0200, Krzysztof Halasa <khc@pm.waw.pl> wrote:

>Grant Coady <grant_lkml@dodo.com.au> writes:
>
>> --- linux-2.6.27-rc3a/drivers/ata/Kconfig	2008-07-14 07:51:29.000000000 +1000
>> +++ linux-2.6.27-rc3c/drivers/ata/Kconfig	2008-08-18 11:29:20.871422237 +1000
>> @@ -3,7 +3,7 @@
>>  #
>>  
>>  menuconfig ATA
>> -	tristate "Serial ATA (prod) and Parallel ATA (experimental) drivers"
>> +	tristate "Serial ATA and Parallel ATA (SATA/PATA) drivers"
>
>I don't think so. Maybe
>> +	tristate "Serial ATA (SATA) and Parallel ATA (PATA) drivers"

Yes, I think that's what I had before.
>
>>  config ATA_SFF
>>  	bool "ATA SFF support"
>>  	default y
>> @@ -93,123 +93,15 @@
>>  
>>  if ATA_SFF
>
>How the user compiling the kernel knows what ATA_SFF stands for?

They read the help text :)  

Perhaps add (legacy drivers) to the SFF menu item?  But that's not 
quite true either.  

>Why not "select ATA_SFF" instead (when any driver using this is
>selected)?

Because then the driver list is always visible?  I'll try it next time 
I look at the patch (when -rc4 is out), I think cleanups wait for next 
merge window anyway.  Perhaps I'll offer both alternatives and see which 
gets picked up.

Besides, I don't like the way select locks in stuff at the moment, means 
you have to turn off every option to get rid of the forced select option 
 -- I'd rather see turning off a 'select'ed item drop all of its 
dependencies.  

Cheers,
Grant.

  reply	other threads:[~2008-08-21  0:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-16  5:15 [PATCH 1/3] ATA Kconfig cleanup: hide ATA_SFF and add SATA/PATA menu items Grant Coady
2008-08-16 10:01 ` Mikael Pettersson
2008-08-16 10:32   ` Alan Cox
2008-08-17  4:20     ` Jeff Garzik
2008-08-18  1:47     ` [PATCH] ATA Kconfig cleanup: sort the driver list and modify some text Grant Coady
2008-08-18  8:56       ` Alan Cox
2008-08-20 23:27       ` Krzysztof Halasa
2008-08-21  0:16         ` Grant Coady [this message]
2008-08-21  0:49           ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tecpa4928hh8kahc53p019sr7nclg8kbjr@4ax.com \
    --to=grant_lkml@dodo.com.au \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gcoady.lk@gmail.com \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).