From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+d4faee732755bba9838e@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [rds?] WARNING in rds_conn_connect_if_down
Date: Sun, 3 Mar 2024 10:59:02 +0800 [thread overview]
Message-ID: <tencent_5436144A4A74DD76DD66D03C89363E96E009@qq.com> (raw)
In-Reply-To: <000000000000c0550506125e4118@google.com>
please test mp capable for rds
#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index fba82d36593a..7fe1a79bd63d 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -301,6 +301,10 @@ static int __rds_rdma_map(struct rds_sock *rs, struct rds_get_mr_args *args,
kfree(sg);
}
ret = PTR_ERR(trans_private);
+ printk("ret: %d, %s\n", ret, __func__);
+ /* Trigger connection so that its ready for the next retry */
+ if (ret == -ENODEV)
+ rds_conn_connect_if_down(cp->cp_conn);
goto out;
}
diff --git a/net/rds/send.c b/net/rds/send.c
index 5e57a1581dc6..9efda3283753 100644
--- a/net/rds/send.c
+++ b/net/rds/send.c
@@ -1314,9 +1314,6 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len)
/* Parse any control messages the user may have included. */
ret = rds_cmsg_send(rs, rm, msg, &allocated_mr, &vct);
if (ret) {
- /* Trigger connection so that its ready for the next retry */
- if (ret == -EAGAIN)
- rds_conn_connect_if_down(conn);
goto out;
}
next prev parent reply other threads:[~2024-03-03 3:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 20:53 [syzbot] [rds?] WARNING in rds_conn_connect_if_down syzbot
2024-02-27 14:58 ` syzbot
2024-02-27 22:41 ` Allison Henderson
2024-03-02 3:36 ` Edward Adam Davis
2024-03-02 4:01 ` syzbot
2024-03-03 2:59 ` Edward Adam Davis [this message]
2024-03-03 3:32 ` syzbot
2024-03-03 3:57 ` [PATCH] net/rds: fix " Edward Adam Davis
2024-03-03 4:18 ` Edward Adam Davis
2024-03-04 17:07 ` Simon Horman
2024-03-05 0:12 ` Edward Adam Davis
2024-03-05 12:20 ` Simon Horman
2024-03-05 0:13 ` [PATCH V2] " Edward Adam Davis
2024-03-06 12:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_5436144A4A74DD76DD66D03C89363E96E009@qq.com \
--to=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+d4faee732755bba9838e@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).