From: Edward Adam Davis <eadavis@qq.com>
To: gregkh@linuxfoundation.org
Cc: eadavis@qq.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
rafael@kernel.org,
syzbot+8e41bb0c055b209ebbf4@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH riscv64] kobject: fix WARNING in input_register_device
Date: Thu, 8 Feb 2024 19:37:56 +0800 [thread overview]
Message-ID: <tencent_6C6ACF8878B26D482FE56F649498E90EEF0A@qq.com> (raw)
In-Reply-To: <2024020812-snowbound-version-6bfa@gregkh>
On Thu, 8 Feb 2024 10:56:00, Greg KH wrote:
> > The input_add_uevent_modalias_var()->input_print_modalias() will add 1684 bytes
> > of data to env, which will result in insufficient memory allocated to the buf
> > members of env.
>
> What is "env"? And can you wrap your lines at 72 columns please?
env is an instance of struct kobj_uevent_env.
>
> > Reported-and-tested-by: syzbot+8e41bb0c055b209ebbf4@syzkaller.appspotmail.com
> > Signed-off-by: Edward Adam Davis <eadavis@qq.com>
> > ---
> > include/linux/kobject.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/kobject.h b/include/linux/kobject.h
> > index c30affcc43b4..74b37b6459cd 100644
> > --- a/include/linux/kobject.h
> > +++ b/include/linux/kobject.h
> > @@ -30,7 +30,7 @@
> >
> > #define UEVENT_HELPER_PATH_LEN 256
> > #define UEVENT_NUM_ENVP 64 /* number of env pointers */
> > -#define UEVENT_BUFFER_SIZE 2048 /* buffer for the variables */
> > +#define UEVENT_BUFFER_SIZE 2560 /* buffer for the variables */
>
> That's an odd number, why that? Why not just a page? What happens if
> some other path wants more?
An increase of 512 bytes is sufficient for the current issue. Do not consider
the problem of hypothetical existence.
>
> And what's causing the input stack to have so many variables all of a
> sudden, what changed to cause this? Is this a bugfix for a specific
> commit that needs to be backported to older kernels? Why did this
> buffer size all of a sudden be too small?
The result of my analysis is that several members of struct input_dev are too
large, such as its member keybit.
thanks,
edward.
next prev parent reply other threads:[~2024-02-08 11:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 19:54 [syzbot] [input?] [usb?] WARNING in input_register_device (2) syzbot
2024-02-08 8:56 ` Edward Adam Davis
2024-02-08 9:36 ` syzbot
2024-02-08 10:46 ` [PATCH riscv64] kobject: fix WARNING in input_register_device Edward Adam Davis
2024-02-08 10:56 ` Greg KH
2024-02-08 11:37 ` Edward Adam Davis [this message]
2024-02-08 12:25 ` Greg KH
2024-02-13 0:43 ` Edward Adam Davis
2024-02-13 7:20 ` Greg KH
2024-02-13 13:10 ` Edward Adam Davis
2024-02-08 12:25 ` Greg KH
2024-02-13 0:50 ` Edward Adam Davis
2024-02-13 7:21 ` Greg KH
2024-02-13 13:13 ` Edward Adam Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_6C6ACF8878B26D482FE56F649498E90EEF0A@qq.com \
--to=eadavis@qq.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=syzbot+8e41bb0c055b209ebbf4@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).