linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sun7i-a20-marsboard.dts: add marsboard-a20 support
@ 2021-12-24 16:43 conleylee
  2022-01-04 20:59 ` Rob Herring
                   ` (4 more replies)
  0 siblings, 5 replies; 19+ messages in thread
From: conleylee @ 2021-12-24 16:43 UTC (permalink / raw)
  To: mripard, wens; +Cc: devicetree, linux-arm-kernel, linux-kernel, Conley Lee

From: Conley Lee <conleylee@foxmail.com>

ARM dts: sun7i: Add Marsboard A20 board

This patch add support for Marsboard A20 board.

The Marsboard A20 is a A20 based SBC with 1G RAM, 8G Flash, micro SD
card slot , SATA socketm 10/100 ethernet, HDMI port, 4 USB2.0 ports, 2
USB2.0 OTG, USB WIFI(RTL8188EU) with antenna.

Signed-off-by: Conley Lee <conleylee@foxmail.com>
---
 .../devicetree/bindings/arm/sunxi.yaml        |   5 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/sun7i-a20-marsboard.dts     | 220 ++++++++++++++++++
 3 files changed, 226 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun7i-a20-marsboard.dts

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index 889128acf49a..4bd93ae26bd1 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -444,6 +444,11 @@ properties:
           - const: haoyu,a10-marsboard
           - const: allwinner,sun4i-a10
 
+      - description: HAOYU Electronics Marsboard A20
+        items:
+          - const: haoyu,a20-marsboard
+          - const: allwinner,sun7i-a20
+
       - description: MapleBoard MP130
         items:
           - const: mapleboard,mp130
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 0de64f237cd8..4628a2617313 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1219,6 +1219,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
 	sun7i-a20-icnova-swac.dtb \
 	sun7i-a20-lamobo-r1.dtb \
 	sun7i-a20-linutronix-testbox-v2.dtb \
+	sun7i-a20-marsboard.dtb \
 	sun7i-a20-m3.dtb \
 	sun7i-a20-mk808c.dtb \
 	sun7i-a20-olimex-som-evb.dtb \
diff --git a/arch/arm/boot/dts/sun7i-a20-marsboard.dts b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
new file mode 100644
index 000000000000..159e69e148e7
--- /dev/null
+++ b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
@@ -0,0 +1,220 @@
+/*
+ * Copyright 2021 Conley Lee
+ * Conley Lee <conleylee@foxmail.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include "sun7i-a20.dtsi"
+#include "sunxi-common-regulators.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+/ {
+	model = "HAOYU Electronics Marsboard A20";
+	compatible = "haoyu,a20-marsboard", "allwinner,sun7i-a20";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	hdmi-connector {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con_in: endpoint {
+				remote-endpoint = <&hdmi_out_con>;
+			};
+		};
+	};
+};
+
+&ahci {
+	target-supply = <&reg_ahci_5v>;
+	status = "okay";
+};
+
+&codec {
+	status = "okay";
+};
+
+&cpu0 {
+	cpu-supply = <&reg_dcdc2>;
+};
+
+&de {
+	status = "okay";
+};
+
+&ehci0 {
+	status = "okay";
+};
+
+&ehci1 {
+	status = "okay";
+};
+
+&gmac_mii_pins {
+	pins = "PA0", "PA1", "PA2",
+	"PA3", "PA4", "PA5", "PA6",
+	"PA7", "PA8", "PA9", "PA10",
+	"PA11", "PA12", "PA13", "PA14",
+	"PA15", "PA16", "PA17";
+};
+
+&gmac {
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac_mii_pins>;
+	phy-handle = <&phy0>;
+	phy-mode = "mii";
+	status = "okay";
+};
+
+&hdmi {
+	status = "okay";
+};
+
+&hdmi_out {
+	hdmi_out_con: endpoint {
+		remote-endpoint = <&hdmi_con_in>;
+	};
+};
+
+&i2c0 {
+	status = "okay";
+
+	axp209: pmic@34 {
+		reg = <0x34>;
+		interrupt-parent = <&nmi_intc>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
+
+&mmc0 {
+	vmmc-supply = <&reg_vcc3v3>;
+	bus-width = <4>;
+	cd-gpios = <&pio 7 10 GPIO_ACTIVE_LOW>; /* PH10 */
+	status = "okay";
+};
+
+&gmac_mdio {
+	phy0: ethernet-phy@0 {
+		reg = <0>;
+	};
+};
+
+&ohci0 {
+	status = "okay";
+};
+
+&ohci1 {
+	status = "okay";
+};
+
+&otg_sram {
+	status = "okay";
+};
+
+&reg_ahci_5v {
+	status = "okay";
+};
+
+#include "axp209.dtsi"
+
+&ac_power_supply {
+	status = "okay";
+};
+
+&reg_dcdc2 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1450000>;
+	regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc3 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1400000>;
+	regulator-name = "vdd-int-dll";
+};
+
+&reg_ldo1 {
+	regulator-name = "vdd-rtc";
+};
+
+&reg_ldo2 {
+	regulator-always-on;
+	regulator-min-microvolt = <3000000>;
+	regulator-max-microvolt = <3000000>;
+	regulator-name = "avcc";
+};
+
+&reg_usb1_vbus {
+	status = "okay";
+};
+
+&reg_usb2_vbus {
+	status = "okay";
+};
+
+&uart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart0_pb_pins>;
+	status = "okay";
+};
+
+&usb_otg {
+	dr_mode = "otg";
+	status = "okay";
+};
+
+&usbphy {
+	usb0_id_det-gpios = <&pio 7 4 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH4 */
+	usb1_vbus-supply = <&reg_usb1_vbus>;
+	usb2_vbus-supply = <&reg_usb2_vbus>;
+	status = "okay";
+};
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH] sun7i-a20-marsboard.dts: add marsboard-a20 support
  2021-12-24 16:43 [PATCH] sun7i-a20-marsboard.dts: add marsboard-a20 support conleylee
@ 2022-01-04 20:59 ` Rob Herring
  2022-01-05  2:45   ` [PATCH v2 1/2] " conleylee
       [not found]   ` <20220105024551.807713-1-conleylee@foxmail.com>
  2022-01-12  3:13 ` [PATCH v3 0/2] dt-bindings: arm: allwinner: add marsboard A20 Conley Lee
                   ` (3 subsequent siblings)
  4 siblings, 2 replies; 19+ messages in thread
From: Rob Herring @ 2022-01-04 20:59 UTC (permalink / raw)
  To: conleylee; +Cc: mripard, wens, devicetree, linux-arm-kernel, linux-kernel

On Sat, Dec 25, 2021 at 12:43:41AM +0800, conleylee@foxmail.com wrote:
> From: Conley Lee <conleylee@foxmail.com>
> 
> ARM dts: sun7i: Add Marsboard A20 board
> 
> This patch add support for Marsboard A20 board.
> 
> The Marsboard A20 is a A20 based SBC with 1G RAM, 8G Flash, micro SD
> card slot , SATA socketm 10/100 ethernet, HDMI port, 4 USB2.0 ports, 2
> USB2.0 OTG, USB WIFI(RTL8188EU) with antenna.
> 
> Signed-off-by: Conley Lee <conleylee@foxmail.com>
> ---
>  .../devicetree/bindings/arm/sunxi.yaml        |   5 +
>  arch/arm/boot/dts/Makefile                    |   1 +
>  arch/arm/boot/dts/sun7i-a20-marsboard.dts     | 220 ++++++++++++++++++

Bindings and dts files should be separate patches.

>  3 files changed, 226 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun7i-a20-marsboard.dts
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 889128acf49a..4bd93ae26bd1 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -444,6 +444,11 @@ properties:
>            - const: haoyu,a10-marsboard
>            - const: allwinner,sun4i-a10
>  
> +      - description: HAOYU Electronics Marsboard A20
> +        items:
> +          - const: haoyu,a20-marsboard
> +          - const: allwinner,sun7i-a20
> +
>        - description: MapleBoard MP130
>          items:
>            - const: mapleboard,mp130
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 0de64f237cd8..4628a2617313 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1219,6 +1219,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
>  	sun7i-a20-icnova-swac.dtb \
>  	sun7i-a20-lamobo-r1.dtb \
>  	sun7i-a20-linutronix-testbox-v2.dtb \
> +	sun7i-a20-marsboard.dtb \
>  	sun7i-a20-m3.dtb \
>  	sun7i-a20-mk808c.dtb \
>  	sun7i-a20-olimex-som-evb.dtb \
> diff --git a/arch/arm/boot/dts/sun7i-a20-marsboard.dts b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
> new file mode 100644
> index 000000000000..159e69e148e7
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
> @@ -0,0 +1,220 @@
> +/*
> + * Copyright 2021 Conley Lee
> + * Conley Lee <conleylee@foxmail.com>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.

Use SPDX tag instead.

> + */
> +
> +/dts-v1/;
> +#include "sun7i-a20.dtsi"
> +#include "sunxi-common-regulators.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> +	model = "HAOYU Electronics Marsboard A20";
> +	compatible = "haoyu,a20-marsboard", "allwinner,sun7i-a20";
> +
> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
> +	hdmi-connector {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint = <&hdmi_out_con>;
> +			};
> +		};
> +	};
> +};
> +
> +&ahci {
> +	target-supply = <&reg_ahci_5v>;
> +	status = "okay";
> +};
> +
> +&codec {
> +	status = "okay";
> +};
> +
> +&cpu0 {
> +	cpu-supply = <&reg_dcdc2>;
> +};
> +
> +&de {
> +	status = "okay";
> +};
> +
> +&ehci0 {
> +	status = "okay";
> +};
> +
> +&ehci1 {
> +	status = "okay";
> +};
> +
> +&gmac_mii_pins {
> +	pins = "PA0", "PA1", "PA2",
> +	"PA3", "PA4", "PA5", "PA6",
> +	"PA7", "PA8", "PA9", "PA10",
> +	"PA11", "PA12", "PA13", "PA14",
> +	"PA15", "PA16", "PA17";
> +};
> +
> +&gmac {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&gmac_mii_pins>;
> +	phy-handle = <&phy0>;
> +	phy-mode = "mii";
> +	status = "okay";
> +};
> +
> +&hdmi {
> +	status = "okay";
> +};
> +
> +&hdmi_out {
> +	hdmi_out_con: endpoint {
> +		remote-endpoint = <&hdmi_con_in>;
> +	};
> +};
> +
> +&i2c0 {
> +	status = "okay";
> +
> +	axp209: pmic@34 {
> +		reg = <0x34>;
> +		interrupt-parent = <&nmi_intc>;
> +		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +	};
> +};
> +
> +&mmc0 {
> +	vmmc-supply = <&reg_vcc3v3>;
> +	bus-width = <4>;
> +	cd-gpios = <&pio 7 10 GPIO_ACTIVE_LOW>; /* PH10 */
> +	status = "okay";
> +};
> +
> +&gmac_mdio {
> +	phy0: ethernet-phy@0 {
> +		reg = <0>;
> +	};
> +};
> +
> +&ohci0 {
> +	status = "okay";
> +};
> +
> +&ohci1 {
> +	status = "okay";
> +};
> +
> +&otg_sram {
> +	status = "okay";
> +};
> +
> +&reg_ahci_5v {
> +	status = "okay";
> +};
> +
> +#include "axp209.dtsi"
> +
> +&ac_power_supply {
> +	status = "okay";
> +};
> +
> +&reg_dcdc2 {
> +	regulator-always-on;
> +	regulator-min-microvolt = <1000000>;
> +	regulator-max-microvolt = <1450000>;
> +	regulator-name = "vdd-cpu";
> +};
> +
> +&reg_dcdc3 {
> +	regulator-always-on;
> +	regulator-min-microvolt = <1000000>;
> +	regulator-max-microvolt = <1400000>;
> +	regulator-name = "vdd-int-dll";
> +};
> +
> +&reg_ldo1 {
> +	regulator-name = "vdd-rtc";
> +};
> +
> +&reg_ldo2 {
> +	regulator-always-on;
> +	regulator-min-microvolt = <3000000>;
> +	regulator-max-microvolt = <3000000>;
> +	regulator-name = "avcc";
> +};
> +
> +&reg_usb1_vbus {
> +	status = "okay";
> +};
> +
> +&reg_usb2_vbus {
> +	status = "okay";
> +};
> +
> +&uart0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&uart0_pb_pins>;
> +	status = "okay";
> +};
> +
> +&usb_otg {
> +	dr_mode = "otg";
> +	status = "okay";
> +};
> +
> +&usbphy {
> +	usb0_id_det-gpios = <&pio 7 4 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH4 */
> +	usb1_vbus-supply = <&reg_usb1_vbus>;
> +	usb2_vbus-supply = <&reg_usb2_vbus>;
> +	status = "okay";
> +};
> -- 
> 2.34.1
> 
> 

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH v2 1/2] sun7i-a20-marsboard.dts: add marsboard-a20 support
  2022-01-04 20:59 ` Rob Herring
@ 2022-01-05  2:45   ` conleylee
  2022-01-11 10:35     ` Maxime Ripard
       [not found]   ` <20220105024551.807713-1-conleylee@foxmail.com>
  1 sibling, 1 reply; 19+ messages in thread
From: conleylee @ 2022-01-05  2:45 UTC (permalink / raw)
  To: robh, mripard, wens; +Cc: devicetree, linux-arm-kernel, linux-kernel, conley

From: conley <conleylee@foxmail.com>

ARM dts: sun7i: Add Marsboard A20 board

This patch add support for Marsboard A20 board.

The Marsboard A20 is a A20 based SBC with 1G RAM, 8G Flash, micro SD
card slot , SATA socketm 10/100 ethernet, HDMI port, 4 USB2.0 ports, 2
USB2.0 OTG, USB WIFI(RTL8188EU) with antenna.

Change since v1.
  - Spearate biddings and dts as two patches.
  - use SPDX tag

Signed-off-by: conley <conleylee@foxmail.com>
---
 arch/arm/boot/dts/Makefile                |   1 +
 arch/arm/boot/dts/sun7i-a20-marsboard.dts | 183 ++++++++++++++++++++++
 2 files changed, 184 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun7i-a20-marsboard.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 0de64f237cd8..4628a2617313 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1219,6 +1219,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
 	sun7i-a20-icnova-swac.dtb \
 	sun7i-a20-lamobo-r1.dtb \
 	sun7i-a20-linutronix-testbox-v2.dtb \
+	sun7i-a20-marsboard.dtb \
 	sun7i-a20-m3.dtb \
 	sun7i-a20-mk808c.dtb \
 	sun7i-a20-olimex-som-evb.dtb \
diff --git a/arch/arm/boot/dts/sun7i-a20-marsboard.dts b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
new file mode 100644
index 000000000000..7ab6aa30fee6
--- /dev/null
+++ b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
@@ -0,0 +1,183 @@
+// SPDX-License-Identifier: LGPL-2.1+
+/*
+ * Copyright 2021 Conley Lee
+ * Conley Lee <conleylee@foxmail.com>
+ */
+
+/dts-v1/;
+#include "sun7i-a20.dtsi"
+#include "sunxi-common-regulators.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+/ {
+	model = "HAOYU Electronics Marsboard A20";
+	compatible = "haoyu,a20-marsboard", "allwinner,sun7i-a20";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	hdmi-connector {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con_in: endpoint {
+				remote-endpoint = <&hdmi_out_con>;
+			};
+		};
+	};
+};
+
+&ahci {
+	target-supply = <&reg_ahci_5v>;
+	status = "okay";
+};
+
+&codec {
+	status = "okay";
+};
+
+&cpu0 {
+	cpu-supply = <&reg_dcdc2>;
+};
+
+&de {
+	status = "okay";
+};
+
+&ehci0 {
+	status = "okay";
+};
+
+&ehci1 {
+	status = "okay";
+};
+
+&gmac_mii_pins {
+	pins = "PA0", "PA1", "PA2",
+	"PA3", "PA4", "PA5", "PA6",
+	"PA7", "PA8", "PA9", "PA10",
+	"PA11", "PA12", "PA13", "PA14",
+	"PA15", "PA16", "PA17";
+};
+
+&gmac {
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac_mii_pins>;
+	phy-handle = <&phy0>;
+	phy-mode = "mii";
+	status = "okay";
+};
+
+&hdmi {
+	status = "okay";
+};
+
+&hdmi_out {
+	hdmi_out_con: endpoint {
+		remote-endpoint = <&hdmi_con_in>;
+	};
+};
+
+&i2c0 {
+	status = "okay";
+
+	axp209: pmic@34 {
+		reg = <0x34>;
+		interrupt-parent = <&nmi_intc>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
+
+&mmc0 {
+	vmmc-supply = <&reg_vcc3v3>;
+	bus-width = <4>;
+	cd-gpios = <&pio 7 10 GPIO_ACTIVE_LOW>; /* PH10 */
+	status = "okay";
+};
+
+&gmac_mdio {
+	phy0: ethernet-phy@0 {
+		reg = <0>;
+	};
+};
+
+&ohci0 {
+	status = "okay";
+};
+
+&ohci1 {
+	status = "okay";
+};
+
+&otg_sram {
+	status = "okay";
+};
+
+&reg_ahci_5v {
+	status = "okay";
+};
+
+#include "axp209.dtsi"
+
+&ac_power_supply {
+	status = "okay";
+};
+
+&reg_dcdc2 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1450000>;
+	regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc3 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1400000>;
+	regulator-name = "vdd-int-dll";
+};
+
+&reg_ldo1 {
+	regulator-name = "vdd-rtc";
+};
+
+&reg_ldo2 {
+	regulator-always-on;
+	regulator-min-microvolt = <3000000>;
+	regulator-max-microvolt = <3000000>;
+	regulator-name = "avcc";
+};
+
+&reg_usb1_vbus {
+	status = "okay";
+};
+
+&reg_usb2_vbus {
+	status = "okay";
+};
+
+&uart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart0_pb_pins>;
+	status = "okay";
+};
+
+&usb_otg {
+	dr_mode = "otg";
+	status = "okay";
+};
+
+&usbphy {
+	usb0_id_det-gpios = <&pio 7 4 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH4 */
+	usb1_vbus-supply = <&reg_usb1_vbus>;
+	usb2_vbus-supply = <&reg_usb2_vbus>;
+	status = "okay";
+};
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 2/2] sunxi.yaml: add HAOYU Electronics Marsboard A20
       [not found]   ` <20220105024551.807713-1-conleylee@foxmail.com>
@ 2022-01-05  2:45     ` conleylee
  2022-01-12  1:24       ` Rob Herring
  2022-01-12  1:25       ` Rob Herring
  0 siblings, 2 replies; 19+ messages in thread
From: conleylee @ 2022-01-05  2:45 UTC (permalink / raw)
  To: robh, mripard, wens; +Cc: devicetree, linux-arm-kernel, linux-kernel, conley

From: conley <conleylee@foxmail.com>

Signed-off-by: conley <conleylee@foxmail.com>
---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index 889128acf49a..4bd93ae26bd1 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -444,6 +444,11 @@ properties:
           - const: haoyu,a10-marsboard
           - const: allwinner,sun4i-a10
 
+      - description: HAOYU Electronics Marsboard A20
+        items:
+          - const: haoyu,a20-marsboard
+          - const: allwinner,sun7i-a20
+
       - description: MapleBoard MP130
         items:
           - const: mapleboard,mp130
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 1/2] sun7i-a20-marsboard.dts: add marsboard-a20 support
  2022-01-05  2:45   ` [PATCH v2 1/2] " conleylee
@ 2022-01-11 10:35     ` Maxime Ripard
  2022-01-12  2:37       ` Conley Lee
  0 siblings, 1 reply; 19+ messages in thread
From: Maxime Ripard @ 2022-01-11 10:35 UTC (permalink / raw)
  To: conleylee; +Cc: robh, wens, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 3418 bytes --]

Hi,

On Wed, Jan 05, 2022 at 10:45:50AM +0800, conleylee@foxmail.com wrote:
> From: conley <conleylee@foxmail.com>

This should be your full name in the author and signed-off-by

> ARM dts: sun7i: Add Marsboard A20 board
> 
> This patch add support for Marsboard A20 board.
> 
> The Marsboard A20 is a A20 based SBC with 1G RAM, 8G Flash, micro SD
> card slot , SATA socketm 10/100 ethernet, HDMI port, 4 USB2.0 ports, 2
> USB2.0 OTG, USB WIFI(RTL8188EU) with antenna.
> 
> Change since v1.
>   - Spearate biddings and dts as two patches.
>   - use SPDX tag

And the changelog should be after the --- below

> Signed-off-by: conley <conleylee@foxmail.com>
> ---
>  arch/arm/boot/dts/Makefile                |   1 +
>  arch/arm/boot/dts/sun7i-a20-marsboard.dts | 183 ++++++++++++++++++++++
>  2 files changed, 184 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun7i-a20-marsboard.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 0de64f237cd8..4628a2617313 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1219,6 +1219,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
>  	sun7i-a20-icnova-swac.dtb \
>  	sun7i-a20-lamobo-r1.dtb \
>  	sun7i-a20-linutronix-testbox-v2.dtb \
> +	sun7i-a20-marsboard.dtb \
>  	sun7i-a20-m3.dtb \
>  	sun7i-a20-mk808c.dtb \
>  	sun7i-a20-olimex-som-evb.dtb \
> diff --git a/arch/arm/boot/dts/sun7i-a20-marsboard.dts b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
> new file mode 100644
> index 000000000000..7ab6aa30fee6
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
> @@ -0,0 +1,183 @@
> +// SPDX-License-Identifier: LGPL-2.1+

The license for DT files is usually a dual-license with GPL and MIT,
which would be:

SPDX-License-Identifier: (GPL-2.0+ OR MIT)

You can't link to a DT, so GPL and LGPL should be equivalent here, and
MIT is useful for other projects (like the *BSD) that reuse the DT.

> +/*
> + * Copyright 2021 Conley Lee
> + * Conley Lee <conleylee@foxmail.com>
> + */
> +
> +/dts-v1/;
> +#include "sun7i-a20.dtsi"
> +#include "sunxi-common-regulators.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> +	model = "HAOYU Electronics Marsboard A20";
> +	compatible = "haoyu,a20-marsboard", "allwinner,sun7i-a20";

Is there multiple boards called marsboard?

If not, then the compatible should be haoyu,marsboard.

The file name should be sun7i-a20-haoyu-marsboard too.

> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
> +	hdmi-connector {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint = <&hdmi_out_con>;
> +			};
> +		};
> +	};
> +};
> +
> +&ahci {
> +	target-supply = <&reg_ahci_5v>;
> +	status = "okay";
> +};
> +
> +&codec {
> +	status = "okay";
> +};
> +
> +&cpu0 {
> +	cpu-supply = <&reg_dcdc2>;
> +};
> +
> +&de {
> +	status = "okay";
> +};
> +
> +&ehci0 {
> +	status = "okay";
> +};
> +
> +&ehci1 {
> +	status = "okay";
> +};
> +
> +&gmac_mii_pins {
> +	pins = "PA0", "PA1", "PA2",
> +	"PA3", "PA4", "PA5", "PA6",
> +	"PA7", "PA8", "PA9", "PA10",
> +	"PA11", "PA12", "PA13", "PA14",
> +	"PA15", "PA16", "PA17";
> +};

Why do you need that node?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 2/2] sunxi.yaml: add HAOYU Electronics Marsboard A20
  2022-01-05  2:45     ` [PATCH v2 2/2] sunxi.yaml: add HAOYU Electronics Marsboard A20 conleylee
@ 2022-01-12  1:24       ` Rob Herring
  2022-01-12  1:25       ` Rob Herring
  1 sibling, 0 replies; 19+ messages in thread
From: Rob Herring @ 2022-01-12  1:24 UTC (permalink / raw)
  To: conleylee; +Cc: mripard, wens, devicetree, linux-arm-kernel, linux-kernel

On Wed, Jan 05, 2022 at 10:45:51AM +0800, conleylee@foxmail.com wrote:
> From: conley <conleylee@foxmail.com>

Need a full name here and a commit message.

> 
> Signed-off-by: conley <conleylee@foxmail.com>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 889128acf49a..4bd93ae26bd1 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -444,6 +444,11 @@ properties:
>            - const: haoyu,a10-marsboard
>            - const: allwinner,sun4i-a10
>  
> +      - description: HAOYU Electronics Marsboard A20
> +        items:
> +          - const: haoyu,a20-marsboard
> +          - const: allwinner,sun7i-a20
> +
>        - description: MapleBoard MP130
>          items:
>            - const: mapleboard,mp130
> -- 
> 2.31.1
> 
> 

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 2/2] sunxi.yaml: add HAOYU Electronics Marsboard A20
  2022-01-05  2:45     ` [PATCH v2 2/2] sunxi.yaml: add HAOYU Electronics Marsboard A20 conleylee
  2022-01-12  1:24       ` Rob Herring
@ 2022-01-12  1:25       ` Rob Herring
  1 sibling, 0 replies; 19+ messages in thread
From: Rob Herring @ 2022-01-12  1:25 UTC (permalink / raw)
  To: conleylee; +Cc: mripard, wens, devicetree, linux-arm-kernel, linux-kernel

On Wed, Jan 05, 2022 at 10:45:51AM +0800, conleylee@foxmail.com wrote:
> From: conley <conleylee@foxmail.com>

And for the subject: 'dt-bindings: arm: allwinner: ...'

(Follow the subject style for the dir/subsystem.)

> 
> Signed-off-by: conley <conleylee@foxmail.com>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 889128acf49a..4bd93ae26bd1 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -444,6 +444,11 @@ properties:
>            - const: haoyu,a10-marsboard
>            - const: allwinner,sun4i-a10
>  
> +      - description: HAOYU Electronics Marsboard A20
> +        items:
> +          - const: haoyu,a20-marsboard
> +          - const: allwinner,sun7i-a20
> +
>        - description: MapleBoard MP130
>          items:
>            - const: mapleboard,mp130
> -- 
> 2.31.1
> 
> 

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 1/2] sun7i-a20-marsboard.dts: add marsboard-a20 support
  2022-01-11 10:35     ` Maxime Ripard
@ 2022-01-12  2:37       ` Conley Lee
  2022-01-14  9:20         ` Maxime Ripard
  0 siblings, 1 reply; 19+ messages in thread
From: Conley Lee @ 2022-01-12  2:37 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: robh, wens, devicetree, linux-arm-kernel, linux-kernel

On 01/11/22 at 11:35上午, Maxime Ripard wrote:
> Date: Tue, 11 Jan 2022 11:35:42 +0100
> From: Maxime Ripard <maxime@cerno.tech>
> To: conleylee@foxmail.com
> Cc: robh@kernel.org, wens@csie.org, devicetree@vger.kernel.org,
>  linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 1/2] sun7i-a20-marsboard.dts: add marsboard-a20
>  support
> 
> Hi,
> 
> On Wed, Jan 05, 2022 at 10:45:50AM +0800, conleylee@foxmail.com wrote:
> > From: conley <conleylee@foxmail.com>
> 
> This should be your full name in the author and signed-off-by
> 
> > ARM dts: sun7i: Add Marsboard A20 board
> > 
> > This patch add support for Marsboard A20 board.
> > 
> > The Marsboard A20 is a A20 based SBC with 1G RAM, 8G Flash, micro SD
> > card slot , SATA socketm 10/100 ethernet, HDMI port, 4 USB2.0 ports, 2
> > USB2.0 OTG, USB WIFI(RTL8188EU) with antenna.
> > 
> > Change since v1.
> >   - Spearate biddings and dts as two patches.
> >   - use SPDX tag
> 
> And the changelog should be after the --- below
> 
> > Signed-off-by: conley <conleylee@foxmail.com>
> > ---
> >  arch/arm/boot/dts/Makefile                |   1 +
> >  arch/arm/boot/dts/sun7i-a20-marsboard.dts | 183 ++++++++++++++++++++++
> >  2 files changed, 184 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/sun7i-a20-marsboard.dts
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 0de64f237cd8..4628a2617313 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -1219,6 +1219,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
> >  	sun7i-a20-icnova-swac.dtb \
> >  	sun7i-a20-lamobo-r1.dtb \
> >  	sun7i-a20-linutronix-testbox-v2.dtb \
> > +	sun7i-a20-marsboard.dtb \
> >  	sun7i-a20-m3.dtb \
> >  	sun7i-a20-mk808c.dtb \
> >  	sun7i-a20-olimex-som-evb.dtb \
> > diff --git a/arch/arm/boot/dts/sun7i-a20-marsboard.dts b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
> > new file mode 100644
> > index 000000000000..7ab6aa30fee6
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
> > @@ -0,0 +1,183 @@
> > +// SPDX-License-Identifier: LGPL-2.1+
> 
> The license for DT files is usually a dual-license with GPL and MIT,
> which would be:
> 
> SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> 
> You can't link to a DT, so GPL and LGPL should be equivalent here, and
> MIT is useful for other projects (like the *BSD) that reuse the DT.
> 
> > +/*
> > + * Copyright 2021 Conley Lee
> > + * Conley Lee <conleylee@foxmail.com>
> > + */
> > +
> > +/dts-v1/;
> > +#include "sun7i-a20.dtsi"
> > +#include "sunxi-common-regulators.dtsi"
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +/ {
> > +	model = "HAOYU Electronics Marsboard A20";
> > +	compatible = "haoyu,a20-marsboard", "allwinner,sun7i-a20";
> 
> Is there multiple boards called marsboard?
> 
> If not, then the compatible should be haoyu,marsboard.
> 
> The file name should be sun7i-a20-haoyu-marsboard too.
> 
> > +	aliases {
> > +		serial0 = &uart0;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path = "serial0:115200n8";
> > +	};
> > +
> > +	hdmi-connector {
> > +		compatible = "hdmi-connector";
> > +		type = "a";
> > +
> > +		port {
> > +			hdmi_con_in: endpoint {
> > +				remote-endpoint = <&hdmi_out_con>;
> > +			};
> > +		};
> > +	};
> > +};
> > +
> > +&ahci {
> > +	target-supply = <&reg_ahci_5v>;
> > +	status = "okay";
> > +};
> > +
> > +&codec {
> > +	status = "okay";
> > +};
> > +
> > +&cpu0 {
> > +	cpu-supply = <&reg_dcdc2>;
> > +};
> > +
> > +&de {
> > +	status = "okay";
> > +};
> > +
> > +&ehci0 {
> > +	status = "okay";
> > +};
> > +
> > +&ehci1 {
> > +	status = "okay";
> > +};
> > +
> > +&gmac_mii_pins {
> > +	pins = "PA0", "PA1", "PA2",
> > +	"PA3", "PA4", "PA5", "PA6",
> > +	"PA7", "PA8", "PA9", "PA10",
> > +	"PA11", "PA12", "PA13", "PA14",
> > +	"PA15", "PA16", "PA17";
> > +};
> 
> Why do you need that node?
> 
> Maxime

1. There are two boards called marsboard, another one is based on
   sun4i-a10.
2. About the gmac_mii_pins node: the pin PA17 is connected to PHY
   as EXTERR signal on sun7i-a20-marsboard, it's different from 
   the definetion in dtsi.

Thanks ~

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH v3 0/2] dt-bindings: arm: allwinner: add marsboard A20
  2021-12-24 16:43 [PATCH] sun7i-a20-marsboard.dts: add marsboard-a20 support conleylee
  2022-01-04 20:59 ` Rob Herring
@ 2022-01-12  3:13 ` Conley Lee
       [not found] ` <20220112031347.2492813-1-conleylee@foxmail.com>
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 19+ messages in thread
From: Conley Lee @ 2022-01-12  3:13 UTC (permalink / raw)
  To: mripard, wens; +Cc: devicetree, linux-arm-kernel, linux-kernel, Conley Lee

ARM dts: sun7i: Add Marsboard A20 board

This patch add support for Marsboard A20 board, patch 1 is for the
dts file and patch 2 is for the biddings

The Marsboard A20 is a A20 based SBC with 1G RAM, 8G Flash, micro SD
card slot , SATA socketm 10/100 ethernet, HDMI port, 4 USB2.0 ports, 2
USB2.0 OTG, USB WIFI(RTL8188EU) with antenna.

Change since v1.
  - Spearate biddings and dts as two patches.
  - use SPDX tag

Change since v2.
  - reformat patch
  - dual-license with GPL and MIT
  - rename dts filename to sun7i-a20-haoyu-marsboard.dts

Conley Lee (2):
  sun7i-a20-haoyu-marsboard.dts: add marsboard-a20 support
  sunxi.yaml: add HAOYU Electronics Marsboard A20

 .../devicetree/bindings/arm/sunxi.yaml        |   5 +
 arch/arm/boot/dts/Makefile                    |   1 +
 .../boot/dts/sun7i-a20-haoyu-marsboard.dts    | 183 ++++++++++++++++++
 3 files changed, 189 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts

-- 
2.31.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH v3 1/2] sun7i-a20-haoyu-marsboard.dts: add marsboard-a20 support
       [not found] ` <20220112031347.2492813-1-conleylee@foxmail.com>
@ 2022-01-12  3:13   ` Conley Lee
  2022-01-14  9:21     ` Maxime Ripard
  2022-01-14  9:22     ` Maxime Ripard
  2022-01-12  3:13   ` [PATCH v3 2/2] sunxi.yaml: add HAOYU Electronics Marsboard A20 Conley Lee
  1 sibling, 2 replies; 19+ messages in thread
From: Conley Lee @ 2022-01-12  3:13 UTC (permalink / raw)
  To: mripard, wens; +Cc: devicetree, linux-arm-kernel, linux-kernel, Conley Lee

Add sun7i-a20-haoyu-marsboard.dts to support haoyu marsboard a20 SBC

Signed-off-by: Conley Lee <conleylee@foxmail.com>
---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../boot/dts/sun7i-a20-haoyu-marsboard.dts    | 183 ++++++++++++++++++
 2 files changed, 184 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 0de64f237cd8..5f1602d62927 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1219,6 +1219,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
 	sun7i-a20-icnova-swac.dtb \
 	sun7i-a20-lamobo-r1.dtb \
 	sun7i-a20-linutronix-testbox-v2.dtb \
+	sun7i-a20-haoyu-marsboard.dtb \
 	sun7i-a20-m3.dtb \
 	sun7i-a20-mk808c.dtb \
 	sun7i-a20-olimex-som-evb.dtb \
diff --git a/arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts b/arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts
new file mode 100644
index 000000000000..4c6c6ae0c459
--- /dev/null
+++ b/arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts
@@ -0,0 +1,183 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2021 Conley Lee
+ * Conley Lee <conleylee@foxmail.com>
+ */
+
+/dts-v1/;
+#include "sun7i-a20.dtsi"
+#include "sunxi-common-regulators.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+/ {
+	model = "HAOYU Electronics Marsboard A20";
+	compatible = "haoyu,a20-marsboard", "allwinner,sun7i-a20";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	hdmi-connector {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con_in: endpoint {
+				remote-endpoint = <&hdmi_out_con>;
+			};
+		};
+	};
+};
+
+&ahci {
+	target-supply = <&reg_ahci_5v>;
+	status = "okay";
+};
+
+&codec {
+	status = "okay";
+};
+
+&cpu0 {
+	cpu-supply = <&reg_dcdc2>;
+};
+
+&de {
+	status = "okay";
+};
+
+&ehci0 {
+	status = "okay";
+};
+
+&ehci1 {
+	status = "okay";
+};
+
+&gmac_mii_pins {
+	pins = "PA0", "PA1", "PA2",
+	"PA3", "PA4", "PA5", "PA6",
+	"PA7", "PA8", "PA9", "PA10",
+	"PA11", "PA12", "PA13", "PA14",
+	"PA15", "PA16", "PA17";
+};
+
+&gmac {
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac_mii_pins>;
+	phy-handle = <&phy0>;
+	phy-mode = "mii";
+	status = "okay";
+};
+
+&hdmi {
+	status = "okay";
+};
+
+&hdmi_out {
+	hdmi_out_con: endpoint {
+		remote-endpoint = <&hdmi_con_in>;
+	};
+};
+
+&i2c0 {
+	status = "okay";
+
+	axp209: pmic@34 {
+		reg = <0x34>;
+		interrupt-parent = <&nmi_intc>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
+
+&mmc0 {
+	vmmc-supply = <&reg_vcc3v3>;
+	bus-width = <4>;
+	cd-gpios = <&pio 7 10 GPIO_ACTIVE_LOW>; /* PH10 */
+	status = "okay";
+};
+
+&gmac_mdio {
+	phy0: ethernet-phy@0 {
+		reg = <0>;
+	};
+};
+
+&ohci0 {
+	status = "okay";
+};
+
+&ohci1 {
+	status = "okay";
+};
+
+&otg_sram {
+	status = "okay";
+};
+
+&reg_ahci_5v {
+	status = "okay";
+};
+
+#include "axp209.dtsi"
+
+&ac_power_supply {
+	status = "okay";
+};
+
+&reg_dcdc2 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1450000>;
+	regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc3 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1400000>;
+	regulator-name = "vdd-int-dll";
+};
+
+&reg_ldo1 {
+	regulator-name = "vdd-rtc";
+};
+
+&reg_ldo2 {
+	regulator-always-on;
+	regulator-min-microvolt = <3000000>;
+	regulator-max-microvolt = <3000000>;
+	regulator-name = "avcc";
+};
+
+&reg_usb1_vbus {
+	status = "okay";
+};
+
+&reg_usb2_vbus {
+	status = "okay";
+};
+
+&uart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart0_pb_pins>;
+	status = "okay";
+};
+
+&usb_otg {
+	dr_mode = "otg";
+	status = "okay";
+};
+
+&usbphy {
+	usb0_id_det-gpios = <&pio 7 4 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH4 */
+	usb1_vbus-supply = <&reg_usb1_vbus>;
+	usb2_vbus-supply = <&reg_usb2_vbus>;
+	status = "okay";
+};
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v3 2/2] sunxi.yaml: add HAOYU Electronics Marsboard A20
       [not found] ` <20220112031347.2492813-1-conleylee@foxmail.com>
  2022-01-12  3:13   ` [PATCH v3 1/2] sun7i-a20-haoyu-marsboard.dts: add marsboard-a20 support Conley Lee
@ 2022-01-12  3:13   ` Conley Lee
  2022-01-14  9:22     ` Maxime Ripard
  1 sibling, 1 reply; 19+ messages in thread
From: Conley Lee @ 2022-01-12  3:13 UTC (permalink / raw)
  To: mripard, wens; +Cc: devicetree, linux-arm-kernel, linux-kernel, Conley Lee

add haoyu,a20-marsboard bindings

Signed-off-by: Conley Lee <conleylee@foxmail.com>
---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index 889128acf49a..4bd93ae26bd1 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -444,6 +444,11 @@ properties:
           - const: haoyu,a10-marsboard
           - const: allwinner,sun4i-a10
 
+      - description: HAOYU Electronics Marsboard A20
+        items:
+          - const: haoyu,a20-marsboard
+          - const: allwinner,sun7i-a20
+
       - description: MapleBoard MP130
         items:
           - const: mapleboard,mp130
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 1/2] sun7i-a20-marsboard.dts: add marsboard-a20 support
  2022-01-12  2:37       ` Conley Lee
@ 2022-01-14  9:20         ` Maxime Ripard
  0 siblings, 0 replies; 19+ messages in thread
From: Maxime Ripard @ 2022-01-14  9:20 UTC (permalink / raw)
  To: Conley Lee; +Cc: robh, wens, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 4767 bytes --]

Hi,

On Wed, Jan 12, 2022 at 10:37:55AM +0800, Conley Lee wrote:
> On 01/11/22 at 11:35上午, Maxime Ripard wrote:
> > Date: Tue, 11 Jan 2022 11:35:42 +0100
> > From: Maxime Ripard <maxime@cerno.tech>
> > To: conleylee@foxmail.com
> > Cc: robh@kernel.org, wens@csie.org, devicetree@vger.kernel.org,
> >  linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v2 1/2] sun7i-a20-marsboard.dts: add marsboard-a20
> >  support
> > 
> > Hi,
> > 
> > On Wed, Jan 05, 2022 at 10:45:50AM +0800, conleylee@foxmail.com wrote:
> > > From: conley <conleylee@foxmail.com>
> > 
> > This should be your full name in the author and signed-off-by
> > 
> > > ARM dts: sun7i: Add Marsboard A20 board
> > > 
> > > This patch add support for Marsboard A20 board.
> > > 
> > > The Marsboard A20 is a A20 based SBC with 1G RAM, 8G Flash, micro SD
> > > card slot , SATA socketm 10/100 ethernet, HDMI port, 4 USB2.0 ports, 2
> > > USB2.0 OTG, USB WIFI(RTL8188EU) with antenna.
> > > 
> > > Change since v1.
> > >   - Spearate biddings and dts as two patches.
> > >   - use SPDX tag
> > 
> > And the changelog should be after the --- below
> > 
> > > Signed-off-by: conley <conleylee@foxmail.com>
> > > ---
> > >  arch/arm/boot/dts/Makefile                |   1 +
> > >  arch/arm/boot/dts/sun7i-a20-marsboard.dts | 183 ++++++++++++++++++++++
> > >  2 files changed, 184 insertions(+)
> > >  create mode 100644 arch/arm/boot/dts/sun7i-a20-marsboard.dts
> > > 
> > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > > index 0de64f237cd8..4628a2617313 100644
> > > --- a/arch/arm/boot/dts/Makefile
> > > +++ b/arch/arm/boot/dts/Makefile
> > > @@ -1219,6 +1219,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
> > >  	sun7i-a20-icnova-swac.dtb \
> > >  	sun7i-a20-lamobo-r1.dtb \
> > >  	sun7i-a20-linutronix-testbox-v2.dtb \
> > > +	sun7i-a20-marsboard.dtb \
> > >  	sun7i-a20-m3.dtb \
> > >  	sun7i-a20-mk808c.dtb \
> > >  	sun7i-a20-olimex-som-evb.dtb \
> > > diff --git a/arch/arm/boot/dts/sun7i-a20-marsboard.dts b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
> > > new file mode 100644
> > > index 000000000000..7ab6aa30fee6
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/sun7i-a20-marsboard.dts
> > > @@ -0,0 +1,183 @@
> > > +// SPDX-License-Identifier: LGPL-2.1+
> > 
> > The license for DT files is usually a dual-license with GPL and MIT,
> > which would be:
> > 
> > SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > 
> > You can't link to a DT, so GPL and LGPL should be equivalent here, and
> > MIT is useful for other projects (like the *BSD) that reuse the DT.
> > 
> > > +/*
> > > + * Copyright 2021 Conley Lee
> > > + * Conley Lee <conleylee@foxmail.com>
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include "sun7i-a20.dtsi"
> > > +#include "sunxi-common-regulators.dtsi"
> > > +
> > > +#include <dt-bindings/gpio/gpio.h>
> > > +#include <dt-bindings/interrupt-controller/irq.h>
> > > +
> > > +/ {
> > > +	model = "HAOYU Electronics Marsboard A20";
> > > +	compatible = "haoyu,a20-marsboard", "allwinner,sun7i-a20";
> > 
> > Is there multiple boards called marsboard?
> > 
> > If not, then the compatible should be haoyu,marsboard.
> > 
> > The file name should be sun7i-a20-haoyu-marsboard too.
> > 
> > > +	aliases {
> > > +		serial0 = &uart0;
> > > +	};
> > > +
> > > +	chosen {
> > > +		stdout-path = "serial0:115200n8";
> > > +	};
> > > +
> > > +	hdmi-connector {
> > > +		compatible = "hdmi-connector";
> > > +		type = "a";
> > > +
> > > +		port {
> > > +			hdmi_con_in: endpoint {
> > > +				remote-endpoint = <&hdmi_out_con>;
> > > +			};
> > > +		};
> > > +	};
> > > +};
> > > +
> > > +&ahci {
> > > +	target-supply = <&reg_ahci_5v>;
> > > +	status = "okay";
> > > +};
> > > +
> > > +&codec {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&cpu0 {
> > > +	cpu-supply = <&reg_dcdc2>;
> > > +};
> > > +
> > > +&de {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&ehci0 {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&ehci1 {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&gmac_mii_pins {
> > > +	pins = "PA0", "PA1", "PA2",
> > > +	"PA3", "PA4", "PA5", "PA6",
> > > +	"PA7", "PA8", "PA9", "PA10",
> > > +	"PA11", "PA12", "PA13", "PA14",
> > > +	"PA15", "PA16", "PA17";
> > > +};
> > 
> > Why do you need that node?
>
> 1. There are two boards called marsboard, another one is based on
>    sun4i-a10.

Ok

> 2. About the gmac_mii_pins node: the pin PA17 is connected to PHY
>    as EXTERR signal on sun7i-a20-marsboard, it's different from 
>    the definetion in dtsi.

The A20-Olinuxino-Micro has the same thing then, please do it like they did.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v3 1/2] sun7i-a20-haoyu-marsboard.dts: add marsboard-a20 support
  2022-01-12  3:13   ` [PATCH v3 1/2] sun7i-a20-haoyu-marsboard.dts: add marsboard-a20 support Conley Lee
@ 2022-01-14  9:21     ` Maxime Ripard
  2022-01-14  9:22     ` Maxime Ripard
  1 sibling, 0 replies; 19+ messages in thread
From: Maxime Ripard @ 2022-01-14  9:21 UTC (permalink / raw)
  To: Conley Lee; +Cc: wens, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2612 bytes --]

On Wed, Jan 12, 2022 at 11:13:46AM +0800, Conley Lee wrote:
> Add sun7i-a20-haoyu-marsboard.dts to support haoyu marsboard a20 SBC

A description of the board would be nice

> Signed-off-by: Conley Lee <conleylee@foxmail.com>
> ---
>  arch/arm/boot/dts/Makefile                    |   1 +
>  .../boot/dts/sun7i-a20-haoyu-marsboard.dts    | 183 ++++++++++++++++++
>  2 files changed, 184 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 0de64f237cd8..5f1602d62927 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1219,6 +1219,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
>  	sun7i-a20-icnova-swac.dtb \
>  	sun7i-a20-lamobo-r1.dtb \
>  	sun7i-a20-linutronix-testbox-v2.dtb \
> +	sun7i-a20-haoyu-marsboard.dtb \

This should be ordered alphabetically

>  	sun7i-a20-m3.dtb \
>  	sun7i-a20-mk808c.dtb \
>  	sun7i-a20-olimex-som-evb.dtb \
> diff --git a/arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts b/arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts
> new file mode 100644
> index 000000000000..4c6c6ae0c459
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts
> @@ -0,0 +1,183 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2021 Conley Lee
> + * Conley Lee <conleylee@foxmail.com>
> + */
> +
> +/dts-v1/;
> +#include "sun7i-a20.dtsi"
> +#include "sunxi-common-regulators.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> +	model = "HAOYU Electronics Marsboard A20";
> +	compatible = "haoyu,a20-marsboard", "allwinner,sun7i-a20";
> +
> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
> +	hdmi-connector {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint = <&hdmi_out_con>;
> +			};
> +		};
> +	};
> +};
> +
> +&ahci {
> +	target-supply = <&reg_ahci_5v>;
> +	status = "okay";
> +};
> +
> +&codec {
> +	status = "okay";
> +};
> +
> +&cpu0 {
> +	cpu-supply = <&reg_dcdc2>;
> +};
> +
> +&de {
> +	status = "okay";
> +};
> +
> +&ehci0 {
> +	status = "okay";
> +};
> +
> +&ehci1 {
> +	status = "okay";
> +};
> +
> +&gmac_mii_pins {
> +	pins = "PA0", "PA1", "PA2",
> +	"PA3", "PA4", "PA5", "PA6",
> +	"PA7", "PA8", "PA9", "PA10",
> +	"PA11", "PA12", "PA13", "PA14",
> +	"PA15", "PA16", "PA17";
> +};

See my comment on v3

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v3 1/2] sun7i-a20-haoyu-marsboard.dts: add marsboard-a20 support
  2022-01-12  3:13   ` [PATCH v3 1/2] sun7i-a20-haoyu-marsboard.dts: add marsboard-a20 support Conley Lee
  2022-01-14  9:21     ` Maxime Ripard
@ 2022-01-14  9:22     ` Maxime Ripard
  1 sibling, 0 replies; 19+ messages in thread
From: Maxime Ripard @ 2022-01-14  9:22 UTC (permalink / raw)
  To: Conley Lee; +Cc: wens, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

On Wed, Jan 12, 2022 at 11:13:46AM +0800, Conley Lee wrote:
> Add sun7i-a20-haoyu-marsboard.dts to support haoyu marsboard a20 SBC
> 
> Signed-off-by: Conley Lee <conleylee@foxmail.com>

Also, the commit title prefix must be ARM: dts: sun7i: Add A20-Marsboard

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v3 2/2] sunxi.yaml: add HAOYU Electronics Marsboard A20
  2022-01-12  3:13   ` [PATCH v3 2/2] sunxi.yaml: add HAOYU Electronics Marsboard A20 Conley Lee
@ 2022-01-14  9:22     ` Maxime Ripard
  0 siblings, 0 replies; 19+ messages in thread
From: Maxime Ripard @ 2022-01-14  9:22 UTC (permalink / raw)
  To: Conley Lee; +Cc: wens, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

On Wed, Jan 12, 2022 at 11:13:47AM +0800, Conley Lee wrote:
> add haoyu,a20-marsboard bindings
> 
> Signed-off-by: Conley Lee <conleylee@foxmail.com>

The prefix should be dt-bindings: arm: sunxi

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH v4 1/2] arm: dts: sun7i: Add A20-Marsboard
  2021-12-24 16:43 [PATCH] sun7i-a20-marsboard.dts: add marsboard-a20 support conleylee
                   ` (2 preceding siblings ...)
       [not found] ` <20220112031347.2492813-1-conleylee@foxmail.com>
@ 2022-01-14 16:31 ` Conley Lee
  2022-01-19  8:59   ` (subset) " Maxime Ripard
       [not found] ` <20220114163148.2854265-1-conleylee@foxmail.com>
  4 siblings, 1 reply; 19+ messages in thread
From: Conley Lee @ 2022-01-14 16:31 UTC (permalink / raw)
  To: maxime, mripard, wens, robh
  Cc: devicetree, linux-arm-kernel, linux-kernel, Conley Lee

The Marsboard A20 is a A20 based SBC with 1G RAM, 8G Flash, micro SD
card slot , SATA socketm 10/100 ethernet, HDMI port, 4 USB2.0 ports, 2
USB2.0 OTG, USB WIFI(RTL8188EU) with antenna.

Signed-off-by: Conley Lee <conleylee@foxmail.com>
---
Change since v1.
  - Spearate biddings and dts as two patches.
  - use SPDX tag

Change since v2.
  - reformat patch
  - dual-license with GPL and MIT
  - rename dts filename to sun7i-a20-haoyu-marsboard.dts
Change since v3.
  - reformat patch
  - order dtb alphabetically
  - add gmac_txerr node and remove gmac_mii_pins node in
    sun7i-a20-marsboard.dts
---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../boot/dts/sun7i-a20-haoyu-marsboard.dts    | 183 ++++++++++++++++++
 2 files changed, 184 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 0de64f237cd8..1850ff7c9006 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1213,6 +1213,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
 	sun7i-a20-bananapro.dtb \
 	sun7i-a20-cubieboard2.dtb \
 	sun7i-a20-cubietruck.dtb \
+	sun7i-a20-haoyu-marsboard.dtb \
 	sun7i-a20-hummingbird.dtb \
 	sun7i-a20-itead-ibox.dtb \
 	sun7i-a20-i12-tvbox.dtb \
diff --git a/arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts b/arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts
new file mode 100644
index 000000000000..056dbc415de7
--- /dev/null
+++ b/arch/arm/boot/dts/sun7i-a20-haoyu-marsboard.dts
@@ -0,0 +1,183 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2021 Conley Lee
+ * Conley Lee <conleylee@foxmail.com>
+ */
+
+/dts-v1/;
+#include "sun7i-a20.dtsi"
+#include "sunxi-common-regulators.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+/ {
+	model = "HAOYU Electronics Marsboard A20";
+	compatible = "haoyu,a20-marsboard", "allwinner,sun7i-a20";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	hdmi-connector {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con_in: endpoint {
+				remote-endpoint = <&hdmi_out_con>;
+			};
+		};
+	};
+};
+
+&ahci {
+	target-supply = <&reg_ahci_5v>;
+	status = "okay";
+};
+
+&codec {
+	status = "okay";
+};
+
+&cpu0 {
+	cpu-supply = <&reg_dcdc2>;
+};
+
+&de {
+	status = "okay";
+};
+
+&ehci0 {
+	status = "okay";
+};
+
+&ehci1 {
+	status = "okay";
+};
+
+&gmac {
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac_mii_pins>, <&gmac_txerr>;
+	phy-handle = <&phy0>;
+	phy-mode = "mii";
+	status = "okay";
+};
+
+&hdmi {
+	status = "okay";
+};
+
+&hdmi_out {
+	hdmi_out_con: endpoint {
+		remote-endpoint = <&hdmi_con_in>;
+	};
+};
+
+&i2c0 {
+	status = "okay";
+
+	axp209: pmic@34 {
+		reg = <0x34>;
+		interrupt-parent = <&nmi_intc>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
+
+&mmc0 {
+	vmmc-supply = <&reg_vcc3v3>;
+	bus-width = <4>;
+	cd-gpios = <&pio 7 10 GPIO_ACTIVE_LOW>; /* PH10 */
+	status = "okay";
+};
+
+&gmac_mdio {
+	phy0: ethernet-phy@0 {
+		reg = <0>;
+	};
+};
+
+&ohci0 {
+	status = "okay";
+};
+
+&ohci1 {
+	status = "okay";
+};
+
+&otg_sram {
+	status = "okay";
+};
+
+&pio {
+	gmac_txerr: gmac-txerr-pin {
+		pins = "PA17";
+		function = "gmac";
+	};
+};
+
+
+&reg_ahci_5v {
+	status = "okay";
+};
+
+#include "axp209.dtsi"
+
+&ac_power_supply {
+	status = "okay";
+};
+
+&reg_dcdc2 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1450000>;
+	regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc3 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1400000>;
+	regulator-name = "vdd-int-dll";
+};
+
+&reg_ldo1 {
+	regulator-name = "vdd-rtc";
+};
+
+&reg_ldo2 {
+	regulator-always-on;
+	regulator-min-microvolt = <3000000>;
+	regulator-max-microvolt = <3000000>;
+	regulator-name = "avcc";
+};
+
+&reg_usb1_vbus {
+	status = "okay";
+};
+
+&reg_usb2_vbus {
+	status = "okay";
+};
+
+&uart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart0_pb_pins>;
+	status = "okay";
+};
+
+&usb_otg {
+	dr_mode = "otg";
+	status = "okay";
+};
+
+&usbphy {
+	usb0_id_det-gpios = <&pio 7 4 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH4 */
+	usb1_vbus-supply = <&reg_usb1_vbus>;
+	usb2_vbus-supply = <&reg_usb2_vbus>;
+	status = "okay";
+};
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v4 2/2] dt-bindings: arm: sunxi: add haoyu,a20-marsboard
       [not found] ` <20220114163148.2854265-1-conleylee@foxmail.com>
@ 2022-01-14 16:31   ` Conley Lee
  2022-01-19  8:59     ` (subset) " Maxime Ripard
  0 siblings, 1 reply; 19+ messages in thread
From: Conley Lee @ 2022-01-14 16:31 UTC (permalink / raw)
  To: maxime, mripard, wens, robh
  Cc: devicetree, linux-arm-kernel, linux-kernel, conley

From: conley <conleylee@foxmail.com>

add haoyu,a20-marsboard dt-bindings

Signed-off-by: conley <conleylee@foxmail.com>
---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index 889128acf49a..4bd93ae26bd1 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -444,6 +444,11 @@ properties:
           - const: haoyu,a10-marsboard
           - const: allwinner,sun4i-a10
 
+      - description: HAOYU Electronics Marsboard A20
+        items:
+          - const: haoyu,a20-marsboard
+          - const: allwinner,sun7i-a20
+
       - description: MapleBoard MP130
         items:
           - const: mapleboard,mp130
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: (subset) [PATCH v4 1/2] arm: dts: sun7i: Add A20-Marsboard
  2022-01-14 16:31 ` [PATCH v4 1/2] arm: dts: sun7i: Add A20-Marsboard Conley Lee
@ 2022-01-19  8:59   ` Maxime Ripard
  0 siblings, 0 replies; 19+ messages in thread
From: Maxime Ripard @ 2022-01-19  8:59 UTC (permalink / raw)
  To: mripard, Conley Lee, wens, robh
  Cc: Maxime Ripard, linux-kernel, devicetree, linux-arm-kernel

On Sat, 15 Jan 2022 00:31:47 +0800, Conley Lee wrote:
> The Marsboard A20 is a A20 based SBC with 1G RAM, 8G Flash, micro SD
> card slot , SATA socketm 10/100 ethernet, HDMI port, 4 USB2.0 ports, 2
> USB2.0 OTG, USB WIFI(RTL8188EU) with antenna.
> 
> 

Applied to local tree (sunxi/dt-for-5.18).

Thanks!
Maxime

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: (subset) [PATCH v4 2/2] dt-bindings: arm: sunxi: add haoyu,a20-marsboard
  2022-01-14 16:31   ` [PATCH v4 2/2] dt-bindings: arm: sunxi: add haoyu,a20-marsboard Conley Lee
@ 2022-01-19  8:59     ` Maxime Ripard
  0 siblings, 0 replies; 19+ messages in thread
From: Maxime Ripard @ 2022-01-19  8:59 UTC (permalink / raw)
  To: mripard, Conley Lee, wens, robh
  Cc: Maxime Ripard, linux-arm-kernel, linux-kernel, devicetree

On Sat, 15 Jan 2022 00:31:48 +0800, Conley Lee wrote:
> From: conley <conleylee@foxmail.com>
> 
> add haoyu,a20-marsboard dt-bindings
> 
> 

Applied to local tree (sunxi/dt-for-5.18).

Thanks!
Maxime

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2022-01-19  9:00 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-24 16:43 [PATCH] sun7i-a20-marsboard.dts: add marsboard-a20 support conleylee
2022-01-04 20:59 ` Rob Herring
2022-01-05  2:45   ` [PATCH v2 1/2] " conleylee
2022-01-11 10:35     ` Maxime Ripard
2022-01-12  2:37       ` Conley Lee
2022-01-14  9:20         ` Maxime Ripard
     [not found]   ` <20220105024551.807713-1-conleylee@foxmail.com>
2022-01-05  2:45     ` [PATCH v2 2/2] sunxi.yaml: add HAOYU Electronics Marsboard A20 conleylee
2022-01-12  1:24       ` Rob Herring
2022-01-12  1:25       ` Rob Herring
2022-01-12  3:13 ` [PATCH v3 0/2] dt-bindings: arm: allwinner: add marsboard A20 Conley Lee
     [not found] ` <20220112031347.2492813-1-conleylee@foxmail.com>
2022-01-12  3:13   ` [PATCH v3 1/2] sun7i-a20-haoyu-marsboard.dts: add marsboard-a20 support Conley Lee
2022-01-14  9:21     ` Maxime Ripard
2022-01-14  9:22     ` Maxime Ripard
2022-01-12  3:13   ` [PATCH v3 2/2] sunxi.yaml: add HAOYU Electronics Marsboard A20 Conley Lee
2022-01-14  9:22     ` Maxime Ripard
2022-01-14 16:31 ` [PATCH v4 1/2] arm: dts: sun7i: Add A20-Marsboard Conley Lee
2022-01-19  8:59   ` (subset) " Maxime Ripard
     [not found] ` <20220114163148.2854265-1-conleylee@foxmail.com>
2022-01-14 16:31   ` [PATCH v4 2/2] dt-bindings: arm: sunxi: add haoyu,a20-marsboard Conley Lee
2022-01-19  8:59     ` (subset) " Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).