linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Paul Gortmaker <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: paul.gortmaker@windriver.com, kernel@savoirfairelinux.com,
	fengguang.wu@intel.com, tglx@linutronix.de, mingo@kernel.org,
	hpa@zytor.com, peterz@infradead.org,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: [tip:x86/headers] x86/platform: Delete extraneous MODULE_* tags fromm ts5500
Date: Sat, 16 Jul 2016 13:52:55 -0700	[thread overview]
Message-ID: <tip-00677f826bd0c1befb87b8cfa10f30bde1cc2f32@git.kernel.org> (raw)
In-Reply-To: <20160715235318.GD10758@windriver.com>

Commit-ID:  00677f826bd0c1befb87b8cfa10f30bde1cc2f32
Gitweb:     http://git.kernel.org/tip/00677f826bd0c1befb87b8cfa10f30bde1cc2f32
Author:     Paul Gortmaker <paul.gortmaker@windriver.com>
AuthorDate: Fri, 15 Jul 2016 19:53:18 -0400
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 16 Jul 2016 22:41:00 +0200

x86/platform: Delete extraneous MODULE_* tags fromm ts5500

This file doesn't do anything modular and hence while the tristate
Kconfig used for the gpio portion is fine, it recently got swept up in
an audit of files using the module.h header but not using any modular
registration functions.

However it is not compiled in any of the normal build coverage, and
so some remaining extraneous MODULE macro use were not found until a
randconfig from the kbuild robot came across it.

Here we remove the remaining no-op MODULE macros from the built in
portion of code relating to this Kconfig option.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Savoir-faire Linux Inc. <kernel@savoirfairelinux.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kbuild-all@01.org
Cc: linux-kernel@vger.kernel.org
Fixes: cc3ae7b0af27 ("x86/platform: Audit and remove any unnecessary uses of module.h")
Link: http://lkml.kernel.org/r/20160715235318.GD10758@windriver.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/platform/ts5500/ts5500.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/x86/platform/ts5500/ts5500.c b/arch/x86/platform/ts5500/ts5500.c
index 952191b..fd39301 100644
--- a/arch/x86/platform/ts5500/ts5500.c
+++ b/arch/x86/platform/ts5500/ts5500.c
@@ -345,7 +345,3 @@ error:
 	return err;
 }
 device_initcall(ts5500_init);
-
-MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Savoir-faire Linux Inc. <kernel@savoirfairelinux.com>");
-MODULE_DESCRIPTION("Technologic Systems TS-5500 platform driver");

      reply	other threads:[~2016-07-16 20:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15 19:53 [tip:x86/headers 6/9] arch/x86/platform/ts5500/ts5500.c:349:16: error: expected declaration specifiers or '...' before string constant kbuild test robot
2016-07-15 23:53 ` Paul Gortmaker
2016-07-16 20:52   ` tip-bot for Paul Gortmaker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-00677f826bd0c1befb87b8cfa10f30bde1cc2f32@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=fengguang.wu@intel.com \
    --cc=hpa@zytor.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).