From: Ingo Molnar <mingo@elte.hu>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
penberg@cs.helsinki.fi, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/mm] x86: set_highmem_pages_init() cleanup, fix !CONFIG_NUMA && CONFIG_HIGHMEM=y
Date: Tue, 3 Mar 2009 14:36:31 GMT [thread overview]
Message-ID: <tip-03787ceed8f7bf06af29f3b213017d89f8e9423d@git.kernel.org> (raw)
In-Reply-To: <1236082212.2675.24.camel@penberg-laptop>
Commit-ID: 03787ceed8f7bf06af29f3b213017d89f8e9423d
Gitweb: http://git.kernel.org/tip/03787ceed8f7bf06af29f3b213017d89f8e9423d
Author: "Ingo Molnar" <mingo@elte.hu>
AuthorDate: Tue, 3 Mar 2009 15:32:24 +0100
Commit: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 3 Mar 2009 15:32:24 +0100
x86: set_highmem_pages_init() cleanup, fix !CONFIG_NUMA && CONFIG_HIGHMEM=y
Impact: build fix
arch/x86/mm/highmem_32.c:187: error: static declaration of 'set_highmem_pages_init' follows non-static declaration
arch/x86/include/asm/numa_32.h:8: error: previous declaration of 'set_highmem_pages_init' was here
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
LKML-Reference: <1236082212.2675.24.camel@penberg-laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/mm/highmem_32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/highmem_32.c b/arch/x86/mm/highmem_32.c
index 13a823c..00f127c 100644
--- a/arch/x86/mm/highmem_32.c
+++ b/arch/x86/mm/highmem_32.c
@@ -183,7 +183,7 @@ void __init set_highmem_pages_init(void)
totalram_pages += totalhigh_pages;
}
#else
-static void __init set_highmem_pages_init(void)
+void __init set_highmem_pages_init(void)
{
add_highpages_with_active_regions(0, highstart_pfn, highend_pfn);
next prev parent reply other threads:[~2009-03-03 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 12:10 [PATCH] x86: set_highmem_pages_init() cleanup Pekka Enberg
2009-03-03 12:15 ` Ingo Molnar
2009-03-04 8:16 ` Pekka Enberg
2009-03-04 17:59 ` Ingo Molnar
2009-03-04 18:01 ` Ingo Molnar
2009-03-04 19:21 ` [tip:x86/mm] x86: set_highmem_pages_init() cleanup, #2 Pekka Enberg
2009-03-03 12:15 ` [tip:x86/mm] x86: set_highmem_pages_init() cleanup Pekka Enberg
2009-03-03 14:36 ` Ingo Molnar [this message]
2009-03-03 19:17 ` [tip:x86/mm] x86: set_highmem_pages_init() cleanup, fix !CONFIG_NUMA && CONFIG_HIGHMEM=y Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-03787ceed8f7bf06af29f3b213017d89f8e9423d@git.kernel.org \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=penberg@cs.helsinki.fi \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).