From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753477AbdFVQ6Y (ORCPT ); Thu, 22 Jun 2017 12:58:24 -0400 Received: from terminus.zytor.com ([65.50.211.136]:33253 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbdFVQ6V (ORCPT ); Thu, 22 Jun 2017 12:58:21 -0400 Date: Thu, 22 Jun 2017 09:53:44 -0700 From: tip-bot for Thomas Gleixner Message-ID: Cc: mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com, marc.zyngier@arm.com, mpe@ellerman.id.au, hch@lst.de, axboe@kernel.dk, keith.busch@intel.com, linux-kernel@vger.kernel.org, peterz@infradead.org Reply-To: mpe@ellerman.id.au, marc.zyngier@arm.com, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, keith.busch@intel.com, axboe@kernel.dk, hch@lst.de In-Reply-To: <20170619235445.198042748@linutronix.de> References: <20170619235445.198042748@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] genirq/cpuhotplug: Remove irq disabling logic Git-Commit-ID: 0dd945ff4647a1f29c6ae8f4f9a69c8f37c994cf X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Archived-At: List-Archive: List-Post: Commit-ID: 0dd945ff4647a1f29c6ae8f4f9a69c8f37c994cf Gitweb: http://git.kernel.org/tip/0dd945ff4647a1f29c6ae8f4f9a69c8f37c994cf Author: Thomas Gleixner AuthorDate: Tue, 20 Jun 2017 01:37:25 +0200 Committer: Thomas Gleixner CommitDate: Thu, 22 Jun 2017 18:21:16 +0200 genirq/cpuhotplug: Remove irq disabling logic This is called from stop_machine() with interrupts disabled. No point in disabling them some more. Signed-off-by: Thomas Gleixner Cc: Jens Axboe Cc: Marc Zyngier Cc: Michael Ellerman Cc: Keith Busch Cc: Peter Zijlstra Cc: Christoph Hellwig Link: http://lkml.kernel.org/r/20170619235445.198042748@linutronix.de --- kernel/irq/cpuhotplug.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c index 011f8c4..7051398 100644 --- a/kernel/irq/cpuhotplug.c +++ b/kernel/irq/cpuhotplug.c @@ -59,11 +59,8 @@ static bool migrate_one_irq(struct irq_desc *desc) */ void irq_migrate_all_off_this_cpu(void) { - unsigned int irq; struct irq_desc *desc; - unsigned long flags; - - local_irq_save(flags); + unsigned int irq; for_each_active_irq(irq) { bool affinity_broken; @@ -73,10 +70,9 @@ void irq_migrate_all_off_this_cpu(void) affinity_broken = migrate_one_irq(desc); raw_spin_unlock(&desc->lock); - if (affinity_broken) - pr_warn_ratelimited("IRQ%u no longer affine to CPU%u\n", + if (affinity_broken) { + pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n", irq, smp_processor_id()); + } } - - local_irq_restore(flags); }