From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938729AbeBUQ7d (ORCPT ); Wed, 21 Feb 2018 11:59:33 -0500 Received: from terminus.zytor.com ([198.137.202.136]:40371 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933341AbeBUQ7c (ORCPT ); Wed, 21 Feb 2018 11:59:32 -0500 Date: Wed, 21 Feb 2018 08:58:44 -0800 From: tip-bot for Dominik Brodowski Message-ID: Cc: jpoimboe@redhat.com, linux-kernel@vger.kernel.org, linux@dominikbrodowski.net, mingo@kernel.org, bp@alien8.de, luto@kernel.org, tglx@linutronix.de, peterz@infradead.org, dvlasenk@redhat.com, hpa@zytor.com, dwmw2@infradead.org, brgerst@gmail.com, torvalds@linux-foundation.org Reply-To: bp@alien8.de, linux-kernel@vger.kernel.org, linux@dominikbrodowski.net, mingo@kernel.org, jpoimboe@redhat.com, dwmw2@infradead.org, brgerst@gmail.com, torvalds@linux-foundation.org, peterz@infradead.org, dvlasenk@redhat.com, hpa@zytor.com, luto@kernel.org, tglx@linutronix.de In-Reply-To: <20180220210113.6725-2-linux@dominikbrodowski.net> References: <20180220210113.6725-2-linux@dominikbrodowski.net> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/pti] x86/entry/64: Move PUSH_AND_CLEAR_REGS from interrupt macro to helper function Git-Commit-ID: 0e34d226342c27c4f96138b211547d423e4be8a1 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 0e34d226342c27c4f96138b211547d423e4be8a1 Gitweb: https://git.kernel.org/tip/0e34d226342c27c4f96138b211547d423e4be8a1 Author: Dominik Brodowski AuthorDate: Tue, 20 Feb 2018 22:01:08 +0100 Committer: Ingo Molnar CommitDate: Wed, 21 Feb 2018 16:54:03 +0100 x86/entry/64: Move PUSH_AND_CLEAR_REGS from interrupt macro to helper function The PUSH_AND_CLEAR_REGS macro is able to insert the GP registers "above" the original return address. This allows us to move a sizeable part of the interrupt entry macro to an interrupt entry helper function: text data bss dec hex filename 21088 0 0 21088 5260 entry_64.o-orig 18006 0 0 18006 4656 entry_64.o Suggested-by: Linus Torvalds Signed-off-by: Dominik Brodowski Acked-by: Thomas Gleixner Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: David Woodhouse Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Josh Poimboeuf Cc: Peter Zijlstra Cc: dan.j.williams@intel.com Link: http://lkml.kernel.org/r/20180220210113.6725-2-linux@dominikbrodowski.net Signed-off-by: Ingo Molnar --- arch/x86/entry/entry_64.S | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 7a53879..b0ae0c3 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -525,6 +525,14 @@ END(irq_entries_start) * * Entry runs with interrupts off. */ +ENTRY(interrupt_entry) + UNWIND_HINT_FUNC + + PUSH_AND_CLEAR_REGS save_ret=1 + ENCODE_FRAME_POINTER 8 + + ret +END(interrupt_entry) /* 0(%rsp): ~(interrupt number) */ .macro interrupt func @@ -536,8 +544,7 @@ END(irq_entries_start) call switch_to_thread_stack 1: - PUSH_AND_CLEAR_REGS - ENCODE_FRAME_POINTER + call interrupt_entry testb $3, CS(%rsp) jz 1f