From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752927AbcHQNis (ORCPT ); Wed, 17 Aug 2016 09:38:48 -0400 Received: from terminus.zytor.com ([198.137.202.10]:60752 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752798AbcHQNir (ORCPT ); Wed, 17 Aug 2016 09:38:47 -0400 Date: Wed, 17 Aug 2016 06:37:51 -0700 From: tip-bot for Gregory CLEMENT Message-ID: Cc: mingo@kernel.org, ralph.sennhauser@gmail.com, daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org, sr@denx.de, tglx@linutronix.de, hpa@zytor.com, peterz@infradead.org, torvalds@linux-foundation.org, gregory.clement@free-electrons.com Reply-To: gregory.clement@free-electrons.com, peterz@infradead.org, torvalds@linux-foundation.org, hpa@zytor.com, sr@denx.de, linux-kernel@vger.kernel.org, tglx@linutronix.de, daniel.lezcano@linaro.org, ralph.sennhauser@gmail.com, mingo@kernel.org In-Reply-To: <1471429296-9053-1-git-send-email-daniel.lezcano@linaro.org> References: <1471429296-9053-1-git-send-email-daniel.lezcano@linaro.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:timers/urgent] clocksource/drivers/time-armada-370-xp: Fix the clock reference Git-Commit-ID: 0e62fd836e4c2908cc1e32c68806529b4f859955 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 0e62fd836e4c2908cc1e32c68806529b4f859955 Gitweb: http://git.kernel.org/tip/0e62fd836e4c2908cc1e32c68806529b4f859955 Author: Gregory CLEMENT AuthorDate: Wed, 17 Aug 2016 12:21:33 +0200 Committer: Ingo Molnar CommitDate: Wed, 17 Aug 2016 13:08:31 +0200 clocksource/drivers/time-armada-370-xp: Fix the clock reference While converting the init function to return an error, the wrong clock was get. This leads to the wrong clock rate and slows down the kernel. For example, it affects typical boot time: - without fix: over 1 minute - with fix: 15 seconds Tested-by: Stefan Roese Tested-by: Ralph Sennhauser Signed-off-by: Gregory CLEMENT Signed-off-by: Daniel Lezcano Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Fixes: 12549e27c63c ("clocksource/drivers/time-armada-370-xp: Convert init function to return error") Link: http://lkml.kernel.org/r/1471429296-9053-1-git-send-email-daniel.lezcano@linaro.org [ Refined the changelog. ] Signed-off-by: Ingo Molnar --- drivers/clocksource/time-armada-370-xp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c index 719b478..3c39e6f 100644 --- a/drivers/clocksource/time-armada-370-xp.c +++ b/drivers/clocksource/time-armada-370-xp.c @@ -338,7 +338,6 @@ static int __init armada_xp_timer_init(struct device_node *np) struct clk *clk = of_clk_get_by_name(np, "fixed"); int ret; - clk = of_clk_get(np, 0); if (IS_ERR(clk)) { pr_err("Failed to get clock"); return PTR_ERR(clk);