From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759723AbcBYFvo (ORCPT ); Thu, 25 Feb 2016 00:51:44 -0500 Received: from torg.zytor.com ([198.137.202.12]:54070 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759368AbcBYFvk (ORCPT ); Thu, 25 Feb 2016 00:51:40 -0500 Date: Wed, 24 Feb 2016 21:49:14 -0800 From: tip-bot for Josh Poimboeuf Message-ID: Cc: torvalds@linux-foundation.org, len.brown@intel.com, pavel@ucw.cz, bernd@petrovitsch.priv.at, akpm@linux-foundation.org, jslaby@suse.cz, bp@suse.de, bp@alien8.de, tglx@linutronix.de, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, namhyung@gmail.com, brgerst@gmail.com, hpa@zytor.com, palves@redhat.com, peterz@infradead.org, mmarek@suse.cz, chris.j.arges@canonical.com, jpoimboe@redhat.com, acme@kernel.org, rafael.j.wysocki@intel.com, luto@kernel.org, mingo@kernel.org, luto@amacapital.net Reply-To: linux-kernel@vger.kernel.org, dvlasenk@redhat.com, hpa@zytor.com, namhyung@gmail.com, brgerst@gmail.com, akpm@linux-foundation.org, jslaby@suse.cz, bernd@petrovitsch.priv.at, pavel@ucw.cz, torvalds@linux-foundation.org, len.brown@intel.com, bp@alien8.de, tglx@linutronix.de, bp@suse.de, mingo@kernel.org, luto@kernel.org, rafael.j.wysocki@intel.com, jpoimboe@redhat.com, acme@kernel.org, luto@amacapital.net, peterz@infradead.org, palves@redhat.com, mmarek@suse.cz, chris.j.arges@canonical.com In-Reply-To: <7383d87dd40a460e0d757a0793498b9d06a7ee0d.1453405861.git.jpoimboe@redhat.com> References: <7383d87dd40a460e0d757a0793498b9d06a7ee0d.1453405861.git.jpoimboe@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/debug] x86/asm/acpi: Create a stack frame in do_suspend_lowlevel() Git-Commit-ID: 13523309495cdbd57a0d344c0d5d574987af007f X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 13523309495cdbd57a0d344c0d5d574987af007f Gitweb: http://git.kernel.org/tip/13523309495cdbd57a0d344c0d5d574987af007f Author: Josh Poimboeuf AuthorDate: Thu, 21 Jan 2016 16:49:21 -0600 Committer: Ingo Molnar CommitDate: Wed, 24 Feb 2016 08:35:43 +0100 x86/asm/acpi: Create a stack frame in do_suspend_lowlevel() do_suspend_lowlevel() is a callable non-leaf function which doesn't honor CONFIG_FRAME_POINTER, which can result in bad stack traces. Create a stack frame for it when CONFIG_FRAME_POINTER is enabled. Signed-off-by: Josh Poimboeuf Reviewed-by: Borislav Petkov Acked-by: Pavel Machek Acked-by: Rafael J. Wysocki Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Chris J Arges Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Jiri Slaby Cc: Len Brown Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/7383d87dd40a460e0d757a0793498b9d06a7ee0d.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/acpi/wakeup_64.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/kernel/acpi/wakeup_64.S b/arch/x86/kernel/acpi/wakeup_64.S index 8c35df4..169963f 100644 --- a/arch/x86/kernel/acpi/wakeup_64.S +++ b/arch/x86/kernel/acpi/wakeup_64.S @@ -5,6 +5,7 @@ #include #include #include +#include # Copyright 2003 Pavel Machek , distribute under GPLv2 @@ -39,6 +40,7 @@ bogus_64_magic: jmp bogus_64_magic ENTRY(do_suspend_lowlevel) + FRAME_BEGIN subq $8, %rsp xorl %eax, %eax call save_processor_state @@ -109,6 +111,7 @@ ENTRY(do_suspend_lowlevel) xorl %eax, %eax addq $8, %rsp + FRAME_END jmp restore_processor_state ENDPROC(do_suspend_lowlevel)