* [PATCH] perf report powerpc: Fix crash if callchain is empty
@ 2018-06-11 10:40 Sandipan Das
2018-06-12 3:58 ` Ravi Bangoria
2018-06-26 6:52 ` [tip:perf/urgent] " tip-bot for Sandipan Das
0 siblings, 2 replies; 4+ messages in thread
From: Sandipan Das @ 2018-06-11 10:40 UTC (permalink / raw)
To: acme, jolsa; +Cc: linux-kernel, naveen.n.rao, ravi.bangoria, sukadev
For some cases, the callchain provided by the kernel may be
empty. So, the callchain ip filtering code will cause a crash
if we do not check whether the struct ip_callchain pointer is
NULL before accessing any members.
This can be observed on a powerpc64le system running Fedora 27
as shown below.
# perf record -b -e cycles:u ls
Before applying this patch:
# perf report --branch-history
perf: Segmentation fault
-------- backtrace --------
perf[0x1027615c]
linux-vdso64.so.1(__kernel_sigtramp_rt64+0x0)[0x7fff856304d8]
perf(arch_skip_callchain_idx+0x44)[0x10257c58]
perf[0x1017f2e4]
perf(thread__resolve_callchain+0x124)[0x1017ff5c]
perf(sample__resolve_callchain+0xf0)[0x10172788]
...
After applying this patch:
# perf report --branch-history
Samples: 25 of event 'cycles:u', Event count (approx.): 2306870
Overhead Source:Line Symbol Shared Object
+ 11.60% _init+35736 [.] _init ls
+ 9.84% strcoll_l.c:137 [.] __strcoll_l libc-2.26.so
+ 9.16% memcpy.S:175 [.] __memcpy_power7 libc-2.26.so
+ 9.01% gconv_charset.h:54 [.] _nl_find_locale libc-2.26.so
+ 8.87% dl-addr.c:52 [.] _dl_addr libc-2.26.so
+ 8.83% _init+236 [.] _init ls
...
Reported-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>
---
tools/perf/arch/powerpc/util/skip-callchain-idx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
index 3598b8b75d27..ef5d59a5742e 100644
--- a/tools/perf/arch/powerpc/util/skip-callchain-idx.c
+++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
@@ -243,7 +243,7 @@ int arch_skip_callchain_idx(struct thread *thread, struct ip_callchain *chain)
u64 ip;
u64 skip_slot = -1;
- if (chain->nr < 3)
+ if (!chain || chain->nr < 3)
return skip_slot;
ip = chain->ips[2];
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] perf report powerpc: Fix crash if callchain is empty
2018-06-11 10:40 [PATCH] perf report powerpc: Fix crash if callchain is empty Sandipan Das
@ 2018-06-12 3:58 ` Ravi Bangoria
2018-06-13 19:58 ` Arnaldo Carvalho de Melo
2018-06-26 6:52 ` [tip:perf/urgent] " tip-bot for Sandipan Das
1 sibling, 1 reply; 4+ messages in thread
From: Ravi Bangoria @ 2018-06-12 3:58 UTC (permalink / raw)
To: Sandipan Das, acme
Cc: jolsa, linux-kernel, naveen.n.rao, sukadev, Ravi Bangoria
On 06/11/2018 04:10 PM, Sandipan Das wrote:
> For some cases, the callchain provided by the kernel may be
> empty. So, the callchain ip filtering code will cause a crash
> if we do not check whether the struct ip_callchain pointer is
> NULL before accessing any members.
>
> This can be observed on a powerpc64le system running Fedora 27
> as shown below.
>
> # perf record -b -e cycles:u ls
>
> Before applying this patch:
>
> # perf report --branch-history
>
> perf: Segmentation fault
> -------- backtrace --------
> perf[0x1027615c]
> linux-vdso64.so.1(__kernel_sigtramp_rt64+0x0)[0x7fff856304d8]
> perf(arch_skip_callchain_idx+0x44)[0x10257c58]
> perf[0x1017f2e4]
> perf(thread__resolve_callchain+0x124)[0x1017ff5c]
> perf(sample__resolve_callchain+0xf0)[0x10172788]
> ...
>
> After applying this patch:
>
> # perf report --branch-history
>
> Samples: 25 of event 'cycles:u', Event count (approx.): 2306870
> Overhead Source:Line Symbol Shared Object
> + 11.60% _init+35736 [.] _init ls
> + 9.84% strcoll_l.c:137 [.] __strcoll_l libc-2.26.so
> + 9.16% memcpy.S:175 [.] __memcpy_power7 libc-2.26.so
> + 9.01% gconv_charset.h:54 [.] _nl_find_locale libc-2.26.so
> + 8.87% dl-addr.c:52 [.] _dl_addr libc-2.26.so
> + 8.83% _init+236 [.] _init ls
> ...
>
> Reported-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>
Acked-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf report powerpc: Fix crash if callchain is empty
2018-06-12 3:58 ` Ravi Bangoria
@ 2018-06-13 19:58 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-06-13 19:58 UTC (permalink / raw)
To: Ravi Bangoria; +Cc: Sandipan Das, jolsa, linux-kernel, naveen.n.rao, sukadev
Em Tue, Jun 12, 2018 at 09:28:09AM +0530, Ravi Bangoria escreveu:
> On 06/11/2018 04:10 PM, Sandipan Das wrote:
> > For some cases, the callchain provided by the kernel may be
> > empty. So, the callchain ip filtering code will cause a crash
> > if we do not check whether the struct ip_callchain pointer is
> > NULL before accessing any members.
<SNIP>
> > Reported-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> Acked-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Thanks,
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:perf/urgent] perf report powerpc: Fix crash if callchain is empty
2018-06-11 10:40 [PATCH] perf report powerpc: Fix crash if callchain is empty Sandipan Das
2018-06-12 3:58 ` Ravi Bangoria
@ 2018-06-26 6:52 ` tip-bot for Sandipan Das
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Sandipan Das @ 2018-06-26 6:52 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, linux-kernel, jolsa, sukadev, ravi.bangoria, sandipan,
hpa, naveen.n.rao, tglx, acme
Commit-ID: 143c99f6ac6812d23254e80844d6e34be897d3e1
Gitweb: https://git.kernel.org/tip/143c99f6ac6812d23254e80844d6e34be897d3e1
Author: Sandipan Das <sandipan@linux.ibm.com>
AuthorDate: Mon, 11 Jun 2018 16:10:49 +0530
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 25 Jun 2018 11:59:35 -0300
perf report powerpc: Fix crash if callchain is empty
For some cases, the callchain provided by the kernel may be empty. So,
the callchain ip filtering code will cause a crash if we do not check
whether the struct ip_callchain pointer is NULL before accessing any
members.
This can be observed on a powerpc64le system running Fedora 27 as shown
below.
# perf record -b -e cycles:u ls
Before:
# perf report --branch-history
perf: Segmentation fault
-------- backtrace --------
perf[0x1027615c]
linux-vdso64.so.1(__kernel_sigtramp_rt64+0x0)[0x7fff856304d8]
perf(arch_skip_callchain_idx+0x44)[0x10257c58]
perf[0x1017f2e4]
perf(thread__resolve_callchain+0x124)[0x1017ff5c]
perf(sample__resolve_callchain+0xf0)[0x10172788]
...
After:
# perf report --branch-history
Samples: 25 of event 'cycles:u', Event count (approx.): 2306870
Overhead Source:Line Symbol Shared Object
+ 11.60% _init+35736 [.] _init ls
+ 9.84% strcoll_l.c:137 [.] __strcoll_l libc-2.26.so
+ 9.16% memcpy.S:175 [.] __memcpy_power7 libc-2.26.so
+ 9.01% gconv_charset.h:54 [.] _nl_find_locale libc-2.26.so
+ 8.87% dl-addr.c:52 [.] _dl_addr libc-2.26.so
+ 8.83% _init+236 [.] _init ls
...
Reported-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>
Acked-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20180611104049.11048-1-sandipan@linux.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/arch/powerpc/util/skip-callchain-idx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
index 3598b8b75d27..ef5d59a5742e 100644
--- a/tools/perf/arch/powerpc/util/skip-callchain-idx.c
+++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
@@ -243,7 +243,7 @@ int arch_skip_callchain_idx(struct thread *thread, struct ip_callchain *chain)
u64 ip;
u64 skip_slot = -1;
- if (chain->nr < 3)
+ if (!chain || chain->nr < 3)
return skip_slot;
ip = chain->ips[2];
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-26 6:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-11 10:40 [PATCH] perf report powerpc: Fix crash if callchain is empty Sandipan Das
2018-06-12 3:58 ` Ravi Bangoria
2018-06-13 19:58 ` Arnaldo Carvalho de Melo
2018-06-26 6:52 ` [tip:perf/urgent] " tip-bot for Sandipan Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).