From: tip-bot for Alexey Dobriyan <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, peterz@infradead.org, adobriyan@gmail.com,
hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de,
bp@suse.de, torvalds@linux-foundation.org
Subject: [tip:x86/asm] x86/asm: Clobber flags in clear_page()
Date: Tue, 13 Feb 2018 08:59:31 -0800 [thread overview]
Message-ID: <tip-1acdbf7ea8a80706561013346d281d282a3c00f9@git.kernel.org> (raw)
In-Reply-To: <20180113185048.GA23111@avx2>
Commit-ID: 1acdbf7ea8a80706561013346d281d282a3c00f9
Gitweb: https://git.kernel.org/tip/1acdbf7ea8a80706561013346d281d282a3c00f9
Author: Alexey Dobriyan <adobriyan@gmail.com>
AuthorDate: Sat, 13 Jan 2018 21:50:48 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 13 Feb 2018 17:36:49 +0100
x86/asm: Clobber flags in clear_page()
All clear_page() implementations use XOR which resets flags.
Judging by allyesconfig disassembly no code is affected.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Reviewed-by: Borislav Petkov <bp@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20180113185048.GA23111@avx2
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/include/asm/page_64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/page_64.h b/arch/x86/include/asm/page_64.h
index 4baa6bc..f8a85c6 100644
--- a/arch/x86/include/asm/page_64.h
+++ b/arch/x86/include/asm/page_64.h
@@ -47,7 +47,7 @@ static inline void clear_page(void *page)
clear_page_erms, X86_FEATURE_ERMS,
"=D" (page),
"0" (page)
- : "memory", "rax", "rcx");
+ : "cc", "memory", "rax", "rcx");
}
void copy_page(void *to, void *from);
prev parent reply other threads:[~2018-02-13 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 18:50 [PATCH] x86_64: clobber flags in clear_page() Alexey Dobriyan
2018-02-10 21:19 ` Borislav Petkov
2018-02-13 16:59 ` tip-bot for Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-1acdbf7ea8a80706561013346d281d282a3c00f9@git.kernel.org \
--to=tipbot@zytor.com \
--cc=adobriyan@gmail.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).