From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: namhyung@kernel.org, jolsa@redhat.com, tglx@linutronix.de,
mingo@kernel.org, jpoimboe@redhat.com,
linux-kernel@vger.kernel.org, hpa@zytor.com, dsahern@gmail.com,
acme@redhat.com, a.p.zijlstra@chello.nl
Subject: [tip:perf/core] perf kvm: Remove invocation of setup/exit_browser ()
Date: Mon, 14 Dec 2015 00:13:31 -0800 [thread overview]
Message-ID: <tip-1b0344e64d7b4e512a8e5d2bc88b022fbb7a9ee6@git.kernel.org> (raw)
In-Reply-To: <1449716459-23004-4-git-send-email-namhyung@kernel.org>
Commit-ID: 1b0344e64d7b4e512a8e5d2bc88b022fbb7a9ee6
Gitweb: http://git.kernel.org/tip/1b0344e64d7b4e512a8e5d2bc88b022fbb7a9ee6
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Thu, 10 Dec 2015 12:00:55 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 10 Dec 2015 14:35:35 -0300
perf kvm: Remove invocation of setup/exit_browser()
Calling setup_browser(false) with use_browser = 0 is meaningless.
Just get rid of it. This is necessary to remove the browser
dependency from usage_with_options() and friends.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1449716459-23004-4-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-kvm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index dd94b4c..031f9f5 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -1351,7 +1351,6 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
disable_buildid_cache();
use_browser = 0;
- setup_browser(false);
if (argc) {
argc = parse_options(argc, argv, live_options,
@@ -1409,8 +1408,6 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
err = kvm_events_live_report(kvm);
out:
- exit_browser(0);
-
if (kvm->session)
perf_session__delete(kvm->session);
kvm->session = NULL;
next prev parent reply other threads:[~2015-12-14 8:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 3:00 [PATCHSET 0/7] perf tools: Remove browser dependency from usage_with_options() Namhyung Kim
2015-12-10 3:00 ` [PATCH 1/7] perf annotate: Check argument before calling setup_browser() Namhyung Kim
2015-12-14 8:12 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 2/7] perf annotate: Delay UI browser setup after initialization is done Namhyung Kim
2015-12-14 8:13 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 3/7] perf kvm: Remove invocation of setup/exit_browser() Namhyung Kim
2015-12-14 8:13 ` tip-bot for Namhyung Kim [this message]
2015-12-10 3:00 ` [PATCH 4/7] perf report: Check argument before calling setup_browser() Namhyung Kim
2015-12-14 8:13 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 5/7] perf top: Delay UI browser setup after initialization is done Namhyung Kim
2015-12-10 17:43 ` Arnaldo Carvalho de Melo
2015-12-10 17:52 ` Arnaldo Carvalho de Melo
2015-12-10 18:06 ` Arnaldo Carvalho de Melo
2015-12-10 3:00 ` [PATCH 6/7] perf tools: Free strlist on error path Namhyung Kim
2015-12-14 8:14 ` [tip:perf/core] perf thread_map: Free strlist on constructor " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 7/7] perf tools: Get rid of exit_browser() from usage_with_options() Namhyung Kim
2015-12-14 8:14 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 15:10 ` [PATCHSET 0/7] perf tools: Remove browser dependency " Josh Poimboeuf
2015-12-10 18:53 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-1b0344e64d7b4e512a8e5d2bc88b022fbb7a9ee6@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).