From: tip-bot for Sinan Kaya <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: colin.king@canonical.com, mingo@kernel.org,
kstewart@linuxfoundation.org, gregkh@linuxfoundation.org,
dzickus@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
tglx@linutronix.de, peterz@infradead.org, okaya@kernel.org
Subject: [tip:sched/core] watchdog: Reduce message verbosity
Date: Fri, 3 Aug 2018 03:24:50 -0700 [thread overview]
Message-ID: <tip-1b6266ebe3da8198e9a02fbad77bbb56e2f7ce2e@git.kernel.org> (raw)
In-Reply-To: <20180803060943.2643-1-okaya@kernel.org>
Commit-ID: 1b6266ebe3da8198e9a02fbad77bbb56e2f7ce2e
Gitweb: https://git.kernel.org/tip/1b6266ebe3da8198e9a02fbad77bbb56e2f7ce2e
Author: Sinan Kaya <okaya@kernel.org>
AuthorDate: Thu, 2 Aug 2018 23:09:41 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 3 Aug 2018 12:19:08 +0200
watchdog: Reduce message verbosity
Code is emitting the following error message during boot on systems
without PMU hardware support while probing NMI capability.
NMI watchdog: Perf event create on CPU 0 failed with -2
This error is emitted as the perf subsystem returns -ENOENT due to lack of
PMUs in the system.
It is followed by the warning that NMI watchdog is disabled:
NMI watchdog: Perf NMI watchdog permanently disabled
While NMI disabled information is useful for ordinary users, seeing a PERF
event create failed with error code -2 is not.
Reduce the message severity to debug so that if debugging is still possible
in case the error code returned by perf is required for analysis.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Don Zickus <dzickus@redhat.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=599368
Link: https://lkml.kernel.org/r/20180803060943.2643-1-okaya@kernel.org
---
kernel/watchdog_hld.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/watchdog_hld.c b/kernel/watchdog_hld.c
index e449a23e9d59..1f7020d65d0a 100644
--- a/kernel/watchdog_hld.c
+++ b/kernel/watchdog_hld.c
@@ -175,8 +175,8 @@ static int hardlockup_detector_event_create(void)
evt = perf_event_create_kernel_counter(wd_attr, cpu, NULL,
watchdog_overflow_callback, NULL);
if (IS_ERR(evt)) {
- pr_info("Perf event create on CPU %d failed with %ld\n", cpu,
- PTR_ERR(evt));
+ pr_debug("Perf event create on CPU %d failed with %ld\n", cpu,
+ PTR_ERR(evt));
return PTR_ERR(evt);
}
this_cpu_write(watchdog_ev, evt);
prev parent reply other threads:[~2018-08-03 10:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 6:09 [PATCH v2] watchdog: Reduce message verbosity Sinan Kaya
2018-08-03 10:24 ` tip-bot for Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-1b6266ebe3da8198e9a02fbad77bbb56e2f7ce2e@git.kernel.org \
--to=tipbot@zytor.com \
--cc=colin.king@canonical.com \
--cc=dzickus@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=okaya@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).