From: tip-bot for Andy Lutomirski <luto@amacapital.net>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
torvalds@linux-foundation.org, bunk@stusta.de,
luto@amacapital.net, richard.weinberger@gmail.com,
tglx@linutronix.de, hpa@linux.intel.com, mingo@elte.hu
Subject: [tip:x86/asm] x86: Default to vsyscall=emulate
Date: Mon, 5 Dec 2011 05:24:45 -0800 [thread overview]
Message-ID: <tip-2e57ae0515124af45dd889bfbd4840fd40fcc07d@git.kernel.org> (raw)
In-Reply-To: <93154af3b2b6d208906ae02d80d92cf60c6fa94f.1320712291.git.luto@amacapital.net>
Commit-ID: 2e57ae0515124af45dd889bfbd4840fd40fcc07d
Gitweb: http://git.kernel.org/tip/2e57ae0515124af45dd889bfbd4840fd40fcc07d
Author: Andy Lutomirski <luto@amacapital.net>
AuthorDate: Mon, 7 Nov 2011 16:33:41 -0800
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 5 Dec 2011 12:17:29 +0100
x86: Default to vsyscall=emulate
This essentially reverts:
2b666859ec32: x86: Default to vsyscall=native for now
The ABI breakage should now be fixed by:
commit 48c4206f5b02f28c4c78a1f5b491d3772fb64fb9
Author: Andy Lutomirski <luto@mit.edu>
Date: Thu Oct 20 08:48:19 2011 -0700
x86-64: Set siginfo and context on vsyscall emulation faults
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Cc: richard -rw- weinberger <richard.weinberger@gmail.com>
Cc: Adrian Bunk <bunk@stusta.de>
Cc: H. Peter Anvin <hpa@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/93154af3b2b6d208906ae02d80d92cf60c6fa94f.1320712291.git.luto@amacapital.net
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
Documentation/kernel-parameters.txt | 7 +++----
arch/x86/kernel/vsyscall_64.c | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index a0c5c5f..ce7fc8b 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -2750,11 +2750,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
functions are at fixed addresses, they make nice
targets for exploits that can control RIP.
- emulate Vsyscalls turn into traps and are emulated
- reasonably safely.
+ emulate [default] Vsyscalls turn into traps and are
+ emulated reasonably safely.
- native [default] Vsyscalls are native syscall
- instructions.
+ native Vsyscalls are native syscall instructions.
This is a little bit faster than trapping
and makes a few dynamic recompilers work
better than they would in emulation mode.
diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c
index 8084bec..b07ba93 100644
--- a/arch/x86/kernel/vsyscall_64.c
+++ b/arch/x86/kernel/vsyscall_64.c
@@ -57,7 +57,7 @@ DEFINE_VVAR(struct vsyscall_gtod_data, vsyscall_gtod_data) =
.lock = __SEQLOCK_UNLOCKED(__vsyscall_gtod_data.lock),
};
-static enum { EMULATE, NATIVE, NONE } vsyscall_mode = NATIVE;
+static enum { EMULATE, NATIVE, NONE } vsyscall_mode = EMULATE;
static int __init vsyscall_setup(char *str)
{
next prev parent reply other threads:[~2011-12-05 13:27 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 9:08 [3.1 patch] x86: default to vsyscall=native Adrian Bunk
2011-10-03 13:04 ` Andrew Lutomirski
2011-10-03 17:33 ` Adrian Bunk
2011-10-03 18:06 ` Andrew Lutomirski
2011-10-03 18:41 ` Adrian Bunk
2011-10-05 22:13 ` Andrew Lutomirski
2011-10-05 22:22 ` richard -rw- weinberger
2011-10-05 22:30 ` Adrian Bunk
2011-10-05 22:41 ` richard -rw- weinberger
2011-10-05 22:46 ` Andrew Lutomirski
2011-10-05 23:36 ` Andrew Lutomirski
2011-10-06 3:06 ` Andrew Lutomirski
2011-10-06 12:12 ` richard -rw- weinberger
2011-10-06 15:37 ` richard -rw- weinberger
2011-10-06 18:16 ` Andrew Lutomirski
2011-10-06 18:34 ` Linus Torvalds
2011-10-07 0:48 ` Andrew Lutomirski
2011-10-10 11:19 ` richard -rw- weinberger
2011-10-10 11:48 ` Ingo Molnar
2011-10-10 15:31 ` Andrew Lutomirski
2011-10-11 6:22 ` Ingo Molnar
2011-10-11 17:24 ` [RFC] fixing the UML failure root cause Andrew Lutomirski
2011-10-13 6:19 ` Linus Torvalds
2011-10-13 8:40 ` Andrew Lutomirski
2011-10-14 4:46 ` Linus Torvalds
2011-10-14 6:30 ` Andrew Lutomirski
2011-10-14 20:10 ` Linus Torvalds
2011-10-21 21:01 ` [PATCH] x86-64: Set siginfo and context on vsyscall emulation faults Andy Lutomirski
2011-10-22 4:46 ` Linus Torvalds
2011-10-22 9:07 ` Andy Lutomirski
2011-11-08 0:33 ` [PATCH 0/2] Fix and re-enable vsyscall=emulate Andy Lutomirski
2011-11-08 0:33 ` [PATCH 1/2] x86-64: Set siginfo and context on vsyscall emulation faults Andy Lutomirski
2011-12-05 13:23 ` [tip:x86/asm] " tip-bot for Andy Lutomirski
2011-11-08 0:33 ` [PATCH 2/2] x86: Default to vsyscall=emulate Andy Lutomirski
2011-12-05 13:24 ` tip-bot for Andy Lutomirski [this message]
2011-12-02 22:47 ` [PATCH 0/2] Fix and re-enable vsyscall=emulate Andy Lutomirski
2011-12-05 11:18 ` H. Peter Anvin
2011-10-14 19:53 ` [RFC] fixing the UML failure root cause richard -rw- weinberger
2011-10-14 20:17 ` Andrew Lutomirski
2011-10-14 20:23 ` richard -rw- weinberger
2011-10-14 20:31 ` Andrew Lutomirski
2011-10-14 20:39 ` richard -rw- weinberger
2011-10-14 22:28 ` richard -rw- weinberger
2011-10-15 16:57 ` Ingo Molnar
2011-10-05 22:24 ` [3.1 patch] x86: default to vsyscall=native Adrian Bunk
2011-10-03 13:19 ` richard -rw- weinberger
2011-10-03 17:46 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-2e57ae0515124af45dd889bfbd4840fd40fcc07d@git.kernel.org \
--to=luto@amacapital.net \
--cc=bunk@stusta.de \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=richard.weinberger@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).