linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Frederic Weisbecker <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: riel@redhat.com, torvalds@linux-foundation.org,
	peterz@infradead.org, fweisbec@gmail.com,
	linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de,
	mingo@kernel.org
Subject: [tip:sched/core] sched/fair: Spare idle load balancing on nohz_full CPUs
Date: Thu, 22 Jun 2017 04:11:53 -0700	[thread overview]
Message-ID: <tip-387bc8b5536eeb0a92f4b4ab553539eaea2ac0ba@git.kernel.org> (raw)
In-Reply-To: <1497838322-10913-4-git-send-email-fweisbec@gmail.com>

Commit-ID:  387bc8b5536eeb0a92f4b4ab553539eaea2ac0ba
Gitweb:     http://git.kernel.org/tip/387bc8b5536eeb0a92f4b4ab553539eaea2ac0ba
Author:     Frederic Weisbecker <fweisbec@gmail.com>
AuthorDate: Mon, 19 Jun 2017 04:12:02 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 22 Jun 2017 11:30:02 +0200

sched/fair: Spare idle load balancing on nohz_full CPUs

Although idle load balancing obviously only concerns idle CPUs, it can
be a disturbance on a busy nohz_full CPU. Indeed a CPU can only get rid
of an idle load balancing duty once a tick fires while it runs a task
and this can take a while on a nohz_full CPU.

We could fix that and escape the idle load balancing duty from the very
idle exit path but that would bring unecessary overhead. Lets just not
bother and leave that job to housekeeping CPUs (those outside nohz_full
range). The nohz_full CPUs simply don't want any disturbance.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1497838322-10913-4-git-send-email-fweisbec@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/fair.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index a24661a..694c258 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8683,6 +8683,10 @@ void nohz_balance_enter_idle(int cpu)
 	if (!cpu_active(cpu))
 		return;
 
+	/* Spare idle load balancing on CPUs that don't want to be disturbed: */
+	if (!is_housekeeping_cpu(cpu))
+		return;
+
 	if (test_bit(NOHZ_TICK_STOPPED, nohz_flags(cpu)))
 		return;
 

  parent reply	other threads:[~2017-06-22 11:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19  2:11 [PATCH 0/3] sched: A few nohz_full improvements Frederic Weisbecker
2017-06-19  2:12 ` [PATCH 1/3] sched/loadavg: Generalize idle naming to nohz Frederic Weisbecker
2017-06-20 17:38   ` Rik van Riel
2017-06-22 11:10   ` [tip:sched/core] sched/loadavg: Generalize "_idle" naming to "_nohz" tip-bot for Frederic Weisbecker
2017-06-19  2:12 ` [PATCH 2/3] nohz: Move idle balancer registration to idle path Frederic Weisbecker
2017-06-20 17:39   ` Rik van Riel
2017-06-22 11:11   ` [tip:sched/core] nohz: Move idle balancer registration to the " tip-bot for Frederic Weisbecker
2017-06-19  2:12 ` [PATCH 3/3] sched: Spare idle load balancing on nohz_full CPUs Frederic Weisbecker
2017-06-20 17:42   ` Rik van Riel
2017-06-20 19:06     ` Mike Galbraith
2017-06-21 13:23       ` Frederic Weisbecker
2017-06-20 20:26     ` Frederic Weisbecker
2017-06-22 11:11   ` tip-bot for Frederic Weisbecker [this message]
2017-06-22 13:52     ` [tip:sched/core] sched/fair: " Frederic Weisbecker
2017-06-22 19:47       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-387bc8b5536eeb0a92f4b4ab553539eaea2ac0ba@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).