From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945079AbdDTLbI (ORCPT ); Thu, 20 Apr 2017 07:31:08 -0400 Received: from terminus.zytor.com ([65.50.211.136]:47841 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S945057AbdDTLbE (ORCPT ); Thu, 20 Apr 2017 07:31:04 -0400 Date: Thu, 20 Apr 2017 04:28:35 -0700 From: tip-bot for Thomas Gleixner Message-ID: Cc: bigeasy@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com Reply-To: rostedt@goodmis.org, peterz@infradead.org, bigeasy@linutronix.de, mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org In-Reply-To: <20170418170554.043759892@linutronix.de> References: <20170418170554.043759892@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:smp/hotplug] perf/core: Remove redundant get_online_cpus() Git-Commit-ID: 3e27bdd5a4fc7954af4027f1a77e9556deed653d X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 3e27bdd5a4fc7954af4027f1a77e9556deed653d Gitweb: http://git.kernel.org/tip/3e27bdd5a4fc7954af4027f1a77e9556deed653d Author: Thomas Gleixner AuthorDate: Tue, 18 Apr 2017 19:05:02 +0200 Committer: Thomas Gleixner CommitDate: Thu, 20 Apr 2017 13:08:56 +0200 perf/core: Remove redundant get_online_cpus() SyS_perf_event_open() calls get_online_cpus() and eventually invokes swevent_hlist_get() which does it again. All callchains leading to swevent_hlist_get() originate from SyS_perf_event_open() so the extra protection is redundant. Remove it. Signed-off-by: Thomas Gleixner Cc: Peter Zijlstra Cc: Sebastian Siewior Cc: Steven Rostedt Link: http://lkml.kernel.org/r/20170418170554.043759892@linutronix.de --- kernel/events/core.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index ff01cba..634dd95 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -7592,7 +7592,6 @@ static int swevent_hlist_get(void) { int err, cpu, failed_cpu; - get_online_cpus(); for_each_possible_cpu(cpu) { err = swevent_hlist_get_cpu(cpu); if (err) { @@ -7600,8 +7599,6 @@ static int swevent_hlist_get(void) goto fail; } } - put_online_cpus(); - return 0; fail: for_each_possible_cpu(cpu) { @@ -7609,8 +7606,6 @@ fail: break; swevent_hlist_put_cpu(cpu); } - - put_online_cpus(); return err; }