From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756568AbdKOI43 (ORCPT ); Wed, 15 Nov 2017 03:56:29 -0500 Received: from terminus.zytor.com ([65.50.211.136]:34315 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755381AbdKOI4U (ORCPT ); Wed, 15 Nov 2017 03:56:20 -0500 Date: Wed, 15 Nov 2017 00:51:53 -0800 From: tip-bot for Vasily Averin Message-ID: Cc: acme@kernel.org, jolsa@redhat.com, peterz@infradead.org, torvalds@linux-foundation.org, namhyung@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, alexander.shishkin@linux.intel.com, tglx@linutronix.de, hbathini@linux.vnet.ibm.com, vvs@virtuozzo.com, hpa@zytor.com Reply-To: torvalds@linux-foundation.org, peterz@infradead.org, jolsa@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@kernel.org, namhyung@kernel.org, linux-kernel@vger.kernel.org, hbathini@linux.vnet.ibm.com, tglx@linutronix.de, hpa@zytor.com, vvs@virtuozzo.com In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf/core: Fix memory leak triggered by perf --namespace Git-Commit-ID: 4a31b424ac0656d1bb17520ee861144fe7a19664 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 4a31b424ac0656d1bb17520ee861144fe7a19664 Gitweb: https://git.kernel.org/tip/4a31b424ac0656d1bb17520ee861144fe7a19664 Author: Vasily Averin AuthorDate: Wed, 15 Nov 2017 08:47:02 +0300 Committer: Ingo Molnar CommitDate: Wed, 15 Nov 2017 09:48:10 +0100 perf/core: Fix memory leak triggered by perf --namespace perf with --namespace key leaks various memory objects including namespaces 4.14.0+ pid_namespace 1 12 2568 12 8 user_namespace 1 39 824 39 8 net_namespace 1 5 6272 5 8 This happen because perf_fill_ns_link_info() struct patch ns_path: during initialization ns_path incremented counters on related mnt and dentry, but without lost path_put nobody decremented them back. Leaked dentry is name of related namespace, and its leak does not allow to free unused namespace. Signed-off-by: Vasily Averin Acked-by: Peter Zijlstra Cc: Alexander Shishkin Cc: Arnaldo Carvalho de Melo Cc: Hari Bathini Cc: Jiri Olsa Cc: Linus Torvalds Cc: Namhyung Kim Cc: Thomas Gleixner Fixes: commit e422267322cd ("perf: Add PERF_RECORD_NAMESPACES to include namespaces related info") Link: http://lkml.kernel.org/r/c510711b-3904-e5e1-d296-61273d21118d@virtuozzo.com Signed-off-by: Ingo Molnar --- kernel/events/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/events/core.c b/kernel/events/core.c index 10cdb9c..ab5ac84 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6756,6 +6756,7 @@ static void perf_fill_ns_link_info(struct perf_ns_link_info *ns_link_info, ns_inode = ns_path.dentry->d_inode; ns_link_info->dev = new_encode_dev(ns_inode->i_sb->s_dev); ns_link_info->ino = ns_inode->i_ino; + path_put(&ns_path); } }