From: tip-bot for Davidlohr Bueso <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, dave@stgolabs.net, hpa@zytor.com,
mingo@kernel.org, dbueso@suse.de, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: [tip:perf/core] perf bench futex: Handle spurious wakeups
Date: Sun, 10 May 2015 00:11:04 -0700 [thread overview]
Message-ID: <tip-598adc5c9c1cfd3f154f6d9df72b38eda63e306e@git.kernel.org> (raw)
In-Reply-To: <1431110280-20231-2-git-send-email-dave@stgolabs.net>
Commit-ID: 598adc5c9c1cfd3f154f6d9df72b38eda63e306e
Gitweb: http://git.kernel.org/tip/598adc5c9c1cfd3f154f6d9df72b38eda63e306e
Author: Davidlohr Bueso <dave@stgolabs.net>
AuthorDate: Fri, 8 May 2015 11:38:00 -0700
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 8 May 2015 16:24:02 -0300
perf bench futex: Handle spurious wakeups
Wrap futex_wait around a loop and catch for EINTR.
Either a spurious wakeup occurred or a signal interrupted is, either way
we need to block again.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Cc: Davidlohr Bueso <dbueso@suse.de>
Link: http://lkml.kernel.org/r/1431110280-20231-2-git-send-email-dave@stgolabs.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/bench/futex-wake.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/perf/bench/futex-wake.c b/tools/perf/bench/futex-wake.c
index 929f762..e5e41d3 100644
--- a/tools/perf/bench/futex-wake.c
+++ b/tools/perf/bench/futex-wake.c
@@ -60,7 +60,12 @@ static void *workerfn(void *arg __maybe_unused)
pthread_cond_wait(&thread_worker, &thread_lock);
pthread_mutex_unlock(&thread_lock);
- futex_wait(&futex1, 0, NULL, futex_flag);
+ while (1) {
+ if (futex_wait(&futex1, 0, NULL, futex_flag) != EINTR)
+ break;
+ }
+
+ pthread_exit(NULL);
return NULL;
}
next prev parent reply other threads:[~2015-05-10 7:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 18:37 [PATCH 1/2] perf bench futex: Support parallel waker threads Davidlohr Bueso
2015-05-08 18:38 ` [PATCH 2/2] perf bench futex: Handle spurious wakeups Davidlohr Bueso
2015-05-10 7:11 ` tip-bot for Davidlohr Bueso [this message]
2015-05-08 19:24 ` [PATCH 1/2] perf bench futex: Support parallel waker threads Arnaldo Carvalho de Melo
2015-05-10 7:10 ` [tip:perf/core] " tip-bot for Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-598adc5c9c1cfd3f154f6d9df72b38eda63e306e@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).