From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753524AbeAJSq1 (ORCPT + 1 other); Wed, 10 Jan 2018 13:46:27 -0500 Received: from terminus.zytor.com ([65.50.211.136]:59103 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbeAJSq0 (ORCPT ); Wed, 10 Jan 2018 13:46:26 -0500 Date: Wed, 10 Jan 2018 10:40:40 -0800 From: tip-bot for Andi Kleen Message-ID: Cc: keescook@google.com, ak@linux.intel.com, peterz@infradead.org, pjt@google.com, riel@redhat.com, mingo@kernel.org, hpa@zytor.com, torvalds@linux-foundation.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, jikos@kernel.org, luto@amacapital.net, arjan@linux.intel.com, dave.hansen@intel.com, dwmw@amazon.co.uk, gregkh@linux-foundation.org, tim.c.chen@linux.intel.com Reply-To: hpa@zytor.com, torvalds@linux-foundation.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, jikos@kernel.org, luto@amacapital.net, arjan@linux.intel.com, dave.hansen@intel.com, dwmw@amazon.co.uk, tim.c.chen@linux.intel.com, gregkh@linux-foundation.org, keescook@google.com, ak@linux.intel.com, peterz@infradead.org, pjt@google.com, riel@redhat.com, mingo@kernel.org In-Reply-To: <1515508997-6154-3-git-send-email-dwmw@amazon.co.uk> References: <1515508997-6154-3-git-send-email-dwmw@amazon.co.uk> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/pti] x86/retpoline: Temporarily disable objtool when CONFIG_RETPOLINE=y Git-Commit-ID: 59b6e22f92f9a86dbd0798db72adc97bdb831f86 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Commit-ID: 59b6e22f92f9a86dbd0798db72adc97bdb831f86 Gitweb: https://git.kernel.org/tip/59b6e22f92f9a86dbd0798db72adc97bdb831f86 Author: Andi Kleen AuthorDate: Tue, 9 Jan 2018 14:43:08 +0000 Committer: Thomas Gleixner CommitDate: Wed, 10 Jan 2018 19:36:23 +0100 x86/retpoline: Temporarily disable objtool when CONFIG_RETPOLINE=y objtool's assembler currently cannot deal with the code generated by the retpoline compiler and throws hundreds of warnings, mostly because it sees calls that don't have a symbolic target. Exclude all the options that rely on objtool when RETPOLINE is active. This mainly means that the kernel has to fallback to use the frame pointer unwinder and livepatch is not supported. Josh is looking into resolving the issue. Signed-off-by: Andi Kleen Signed-off-by: David Woodhouse Signed-off-by: Thomas Gleixner Acked-by: Arjan van de Ven Acked-by: Ingo Molnar Cc: gnomes@lxorguk.ukuu.org.uk Cc: Rik van Riel Cc: Peter Zijlstra Cc: Linus Torvalds Cc: Jiri Kosina Cc: Andy Lutomirski Cc: Dave Hansen Cc: Kees Cook Cc: Tim Chen Cc: Greg Kroah-Hartman Cc: Paul Turner Link: https://lkml.kernel.org/r/1515508997-6154-3-git-send-email-dwmw@amazon.co.uk --- arch/x86/Kconfig | 4 ++-- arch/x86/Kconfig.debug | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index d181916..abeac4b 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -172,8 +172,8 @@ config X86 select HAVE_PERF_USER_STACK_DUMP select HAVE_RCU_TABLE_FREE select HAVE_REGS_AND_STACK_ACCESS_API - select HAVE_RELIABLE_STACKTRACE if X86_64 && UNWINDER_FRAME_POINTER && STACK_VALIDATION - select HAVE_STACK_VALIDATION if X86_64 + select HAVE_RELIABLE_STACKTRACE if X86_64 && UNWINDER_FRAME_POINTER && STACK_VALIDATION && !RETPOLINE + select HAVE_STACK_VALIDATION if X86_64 && !RETPOLINE select HAVE_SYSCALL_TRACEPOINTS select HAVE_UNSTABLE_SCHED_CLOCK select HAVE_USER_RETURN_NOTIFIER diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug index 6293a87..9f3928d 100644 --- a/arch/x86/Kconfig.debug +++ b/arch/x86/Kconfig.debug @@ -359,8 +359,8 @@ config PUNIT_ATOM_DEBUG choice prompt "Choose kernel unwinder" - default UNWINDER_ORC if X86_64 - default UNWINDER_FRAME_POINTER if X86_32 + default UNWINDER_ORC if X86_64 && !RETPOLINE + default UNWINDER_FRAME_POINTER if X86_32 || RETPOLINE ---help--- This determines which method will be used for unwinding kernel stack traces for panics, oopses, bugs, warnings, perf, /proc//stack, @@ -368,7 +368,7 @@ choice config UNWINDER_ORC bool "ORC unwinder" - depends on X86_64 + depends on X86_64 && !RETPOLINE select STACK_VALIDATION ---help--- This option enables the ORC (Oops Rewind Capability) unwinder for