From: tip-bot for He Kuang <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, hekuang@huawei.com, ak@linux.intel.com,
jolsa@kernel.org, hpa@zytor.com, adrian.hunter@intel.com,
namhyung@kernel.org, linux-kernel@vger.kernel.org,
mhiramat@kernel.org, sukadev@linux.vnet.ibm.com,
tumanova@linux.vnet.ibm.com, dsahern@gmail.com, mingo@kernel.org,
alexander.shishkin@linux.intel.com, eranian@google.com,
acme@redhat.com, kan.liang@intel.com, penberg@kernel.org,
peterz@infradead.org, jpoimboe@redhat.com, wangnan0@huawei.com
Subject: [tip:perf/core] perf unwind: Fix wrongly used regs for x86_32 unwind
Date: Sun, 26 Jun 2016 03:56:35 -0700 [thread overview]
Message-ID: <tip-5dafea097ac65bd01cc86801c399ae41dce79756@git.kernel.org> (raw)
In-Reply-To: <1466578626-92406-3-git-send-email-hekuang@huawei.com>
Commit-ID: 5dafea097ac65bd01cc86801c399ae41dce79756
Gitweb: http://git.kernel.org/tip/5dafea097ac65bd01cc86801c399ae41dce79756
Author: He Kuang <hekuang@huawei.com>
AuthorDate: Wed, 22 Jun 2016 06:57:03 +0000
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 23 Jun 2016 10:30:21 -0300
perf unwind: Fix wrongly used regs for x86_32 unwind
By default, "unwind-libunwind-local.c" gets SP/IP register number
according to the host platform, for remote unwind, we should use
register number for target platform. Fix this by define
LIBUNWIND_ARCH_REG_SP/IP in the wrapper file of x86_32 platform.
Signed-off-by: He Kuang <hekuang@huawei.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1466578626-92406-3-git-send-email-hekuang@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/libunwind/x86_32.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/perf/util/libunwind/x86_32.c b/tools/perf/util/libunwind/x86_32.c
index d98c17e..957ffff 100644
--- a/tools/perf/util/libunwind/x86_32.c
+++ b/tools/perf/util/libunwind/x86_32.c
@@ -12,7 +12,13 @@
*/
#define REMOTE_UNWIND_LIBUNWIND
+
+/* Define arch specific functions & regs for libunwind, should be
+ * defined before including "unwind.h"
+ */
#define LIBUNWIND__ARCH_REG_ID(regnum) libunwind__x86_reg_id(regnum)
+#define LIBUNWIND__ARCH_REG_IP PERF_REG_X86_IP
+#define LIBUNWIND__ARCH_REG_SP PERF_REG_X86_SP
#include "unwind.h"
#include "debug.h"
next prev parent reply other threads:[~2016-06-26 10:57 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 6:57 [PATCH 0/5] Fixes on perf unwind He Kuang
2016-06-22 6:57 ` [PATCH 1/5] perf unwind: Change macro names of perf register He Kuang
2016-06-26 10:56 ` [tip:perf/core] " tip-bot for He Kuang
2016-06-22 6:57 ` [PATCH 2/5] perf unwind: Fix wrongly used regs for x86_32 unwind He Kuang
2016-06-26 10:56 ` tip-bot for He Kuang [this message]
2016-06-22 6:57 ` [PATCH 3/5] perf unwind: Fix wrongly used regs for aarch64 unwind He Kuang
2016-06-26 10:57 ` [tip:perf/core] " tip-bot for He Kuang
2016-06-22 6:57 ` [PATCH 4/5] perf tools: Let python use correct gcc for build_ext He Kuang
2016-06-26 10:54 ` [tip:perf/core] " tip-bot for He Kuang
2016-06-22 6:57 ` [PATCH 5/5] perf tools: Fix NULL pointer deference when vdso not found He Kuang
2016-06-23 2:02 ` Wangnan (F)
2016-06-23 3:03 ` Hekuang
2016-06-23 12:07 ` Arnaldo Carvalho de Melo
2016-06-23 13:28 ` Arnaldo Carvalho de Melo
2016-06-26 10:55 ` [tip:perf/core] perf tools: Find right DSO taking into account if binary is 32 or 64-bit tip-bot for He Kuang
2016-06-23 13:30 ` [PATCH 0/5] Fixes on perf unwind Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2016-05-12 8:43 [PATCH v3 0/7] Add support for remote unwind He Kuang
2016-05-12 8:43 ` [PATCH v3 1/7] perf tools: Set vdso name to vdso[64,32] depending on platform He Kuang
2016-05-12 10:06 ` Adrian Hunter
2016-05-13 8:51 ` [PATCH v3 1/7 UPDATE] perf tools: Find vdso with the consider of cross-platform He Kuang
2016-05-16 13:32 ` Arnaldo Carvalho de Melo
2016-05-17 7:34 ` Adrian Hunter
2016-05-17 7:33 ` Adrian Hunter
2016-05-17 9:04 ` [PATCH v3 1/7 UPDATE2] " He Kuang
2016-05-17 9:17 ` Adrian Hunter
2016-05-17 12:46 ` Arnaldo Carvalho de Melo
2016-06-15 13:34 ` Arnaldo Carvalho de Melo
2016-06-16 0:22 ` Hekuang
2016-06-16 13:00 ` Adrian Hunter
2016-06-16 16:33 ` Arnaldo Carvalho de Melo
2016-05-17 9:05 ` [PATCH v3 1/7 UPDATE] " Hekuang
2016-05-13 8:53 ` [PATCH v3 1/7] perf tools: Set vdso name to vdso[64,32] depending on platform Hekuang
2016-05-12 8:43 ` [PATCH v3 2/7] perf tools: Store vdso buildid unconditionally He Kuang
2016-05-12 13:09 ` Arnaldo Carvalho de Melo
2016-05-20 6:43 ` [tip:perf/urgent] perf symbols: " tip-bot for He Kuang
2016-05-12 8:43 ` [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given He Kuang
2016-05-12 13:09 ` Arnaldo Carvalho de Melo
2016-05-12 20:23 ` David Ahern
2016-05-12 20:33 ` Arnaldo Carvalho de Melo
2016-05-13 7:19 ` Hekuang
2016-05-13 14:27 ` David Ahern
2016-05-13 18:01 ` Arnaldo Carvalho de Melo
2016-05-14 8:19 ` [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs He Kuang
2016-05-14 14:43 ` David Ahern
2016-05-16 1:30 ` Hekuang
2016-05-16 2:50 ` David Ahern
2016-05-16 6:40 ` Hekuang
2016-05-18 1:47 ` Hekuang
2016-05-18 1:51 ` David Ahern
2016-05-18 2:48 ` Hekuang
2016-05-18 3:04 ` David Ahern
2016-05-12 8:43 ` [PATCH v3 4/7] perf tools: Promote proper messages for cross-platform unwind He Kuang
2016-05-12 8:43 ` [PATCH v3 5/7] perf callchain: Add support " He Kuang
2016-05-12 8:43 ` [PATCH v3 6/7] perf callchain: Support x86 target platform He Kuang
2016-05-12 8:43 ` [PATCH v3 7/7] perf callchain: Support aarch64 cross-platform He Kuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-5dafea097ac65bd01cc86801c399ae41dce79756@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=hekuang@huawei.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tumanova@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).