From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757569AbcBWJJx (ORCPT ); Tue, 23 Feb 2016 04:09:53 -0500 Received: from terminus.zytor.com ([198.137.202.10]:58072 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064AbcBWJJu (ORCPT ); Tue, 23 Feb 2016 04:09:50 -0500 Date: Tue, 23 Feb 2016 01:02:14 -0800 From: =?UTF-8?B?dGlwLWJvdCBmb3IgQ2hyaXMgSiBBcmdlcyA8dGlwYm90QHp5dG9yLmNvbT4=?=@zytor.com Message-ID: Cc: tglx@linutronix.de, palves@redhat.com, brgerst@gmail.com, acme@kernel.org, akpm@linux-foundation.org, peterz@infradead.org, mmarek@suse.cz, bernd@petrovitsch.priv.at, bp@suse.de, jslaby@suse.cz, luto@kernel.org, jpoimboe@redhat.com, luto@amacapital.net, chris.j.arges@canonical.com, namhyung@gmail.com, torvalds@linux-foundation.org, mingo@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, bp@alien8.de, dvlasenk@redhat.com Reply-To: tglx@linutronix.de, peterz@infradead.org, acme@kernel.org, akpm@linux-foundation.org, palves@redhat.com, brgerst@gmail.com, jslaby@suse.cz, bp@suse.de, bernd@petrovitsch.priv.at, mmarek@suse.cz, bp@alien8.de, dvlasenk@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@kernel.org, chris.j.arges@canonical.com, torvalds@linux-foundation.org, namhyung@gmail.com, jpoimboe@redhat.com, luto@amacapital.net, luto@kernel.org In-Reply-To: References: To: =?UTF-8?B?bGludXgtdGlwLWNvbW1pdHNAdmdlci5rZXJuZWwub3Jn?=@zytor.com Subject: =?UTF-8?B?W3RpcDp4ODYvZGVidWddIHg4Ni91YWNjZXNzOiBBZGQgc3RhY2sgZnJhbWUgb3U=?= =?UTF-8?B?dHB1dCBvcGVyYW5kIGluIGdldF91c2VyKCkgaW5saW5lIGFzbQ==?= Git-Commit-ID: =?UTF-8?B?NWU5NDdiMzhmOGVhZDMzYmY2YWFlY2MyYWYyMGEwYTNhOTg4ZmQwMg==?= X-Mailer: =?UTF-8?B?dGlwLWdpdC1sb2ctZGFlbW9u?= Robot-ID: =?UTF-8?B?PHRpcC1ib3QuZ2l0Lmtlcm5lbC5vcmc+?= Robot-Unsubscribe: =?UTF-8?B?Q29udGFjdCA8bWFpbHRvOmhwYUBrZXJuZWwub3JnPiB0byBnZXQgYmxhY2tsaXM=?= =?UTF-8?B?dGVkIGZyb20gdGhlc2UgZW1haWxz?= MIME-Version: =?UTF-8?B?MS4w?= Content-Transfer-Encoding: =?UTF-8?B?OGJpdA==?= Content-Type: =?UTF-8?B?dGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOA==?= Content-Disposition: =?UTF-8?B?aW5saW5l?= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 5e947b38f8ead33bf6aaecc2af20a0a3a988fd02 Gitweb: http://git.kernel.org/tip/5e947b38f8ead33bf6aaecc2af20a0a3a988fd02 Author: Chris J Arges AuthorDate: Thu, 21 Jan 2016 16:49:25 -0600 Committer: Ingo Molnar CommitDate: Tue, 23 Feb 2016 09:03:58 +0100 x86/uaccess: Add stack frame output operand in get_user() inline asm Numerous 'call without frame pointer save/setup' warnings are introduced by stacktool because of functions using the get_user() macro. Bad stack traces could occur due to lack of or misplacement of stack frame setup code. This patch forces a stack frame to be created before the inline asm code if CONFIG_FRAME_POINTER is enabled by listing the stack pointer as an output operand for the get_user() inline assembly statement. Signed-off-by: Chris J Arges Signed-off-by: Josh Poimboeuf Reviewed-by: Borislav Petkov Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Jiri Slaby Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/bc85501f221ee512670797c7f110022e64b12c81.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/include/asm/uaccess.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h index a4a30e4..9bbb3b2 100644 --- a/arch/x86/include/asm/uaccess.h +++ b/arch/x86/include/asm/uaccess.h @@ -179,10 +179,11 @@ __typeof__(__builtin_choose_expr(sizeof(x) > sizeof(0UL), 0ULL, 0UL)) ({ \ int __ret_gu; \ register __inttype(*(ptr)) __val_gu asm("%"_ASM_DX); \ + register void *__sp asm(_ASM_SP); \ __chk_user_ptr(ptr); \ might_fault(); \ - asm volatile("call __get_user_%P3" \ - : "=a" (__ret_gu), "=r" (__val_gu) \ + asm volatile("call __get_user_%P4" \ + : "=a" (__ret_gu), "=r" (__val_gu), "+r" (__sp) \ : "0" (ptr), "i" (sizeof(*(ptr)))); \ (x) = (__force __typeof__(*(ptr))) __val_gu; \ __builtin_expect(__ret_gu, 0); \