From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763020AbbA3Sdn (ORCPT ); Fri, 30 Jan 2015 13:33:43 -0500 Received: from terminus.zytor.com ([198.137.202.10]:35830 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752929AbbA3Sdk (ORCPT ); Fri, 30 Jan 2015 13:33:40 -0500 Date: Fri, 30 Jan 2015 10:33:20 -0800 From: tip-bot for Namhyung Kim Message-ID: Cc: adrian.hunter@intel.com, hpa@zytor.com, tglx@linutronix.de, acme@redhat.com, namhyung@kernel.org, dsahern@gmail.com, andi@firstfloor.org, jolsa@redhat.com, fweisbec@gmail.com, mingo@kernel.org, a.p.zijlstra@chello.nl, eranian@google.com, linux-kernel@vger.kernel.org Reply-To: a.p.zijlstra@chello.nl, eranian@google.com, linux-kernel@vger.kernel.org, jolsa@redhat.com, fweisbec@gmail.com, mingo@kernel.org, namhyung@kernel.org, dsahern@gmail.com, andi@firstfloor.org, hpa@zytor.com, adrian.hunter@intel.com, tglx@linutronix.de, acme@redhat.com In-Reply-To: <1422518843-25818-6-git-send-email-namhyung@kernel.org> References: <1422518843-25818-6-git-send-email-namhyung@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf evsel: Set attr.task bit for a tracking event Git-Commit-ID: 62e503b7ed98fcdf16308cda0b5378e7840f4339 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 62e503b7ed98fcdf16308cda0b5378e7840f4339 Gitweb: http://git.kernel.org/tip/62e503b7ed98fcdf16308cda0b5378e7840f4339 Author: Namhyung Kim AuthorDate: Thu, 29 Jan 2015 17:06:46 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 29 Jan 2015 16:54:59 -0300 perf evsel: Set attr.task bit for a tracking event The perf_event_attr.task bit is to track task (fork and exit) events but it missed to be set by perf_evsel__config(). While it was not a problem in practice since setting other bits (comm/mmap) ended up being in same result, it'd be good to set it explicitly anyway. The attr->task is to track task related events (fork/exit) only but other meta events like comm and mmap[2] also needs the task events. So setting attr->comm and/or attr->mmap causes the kernel emits the task events anyway. So the attr->task is only meaningful when other bits are off but I'd like to set it for completeness. Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/1422518843-25818-6-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/evsel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 1d826d6..ea51a90 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -709,6 +709,7 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts) if (opts->sample_weight) perf_evsel__set_sample_bit(evsel, WEIGHT); + attr->task = track; attr->mmap = track; attr->mmap2 = track && !perf_missing_features.mmap2; attr->comm = track;