From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756957Ab3A1AHU (ORCPT ); Sun, 27 Jan 2013 19:07:20 -0500 Received: from terminus.zytor.com ([198.137.202.10]:35367 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754409Ab3A1AHR (ORCPT ); Sun, 27 Jan 2013 19:07:17 -0500 Date: Sun, 27 Jan 2013 16:06:04 -0800 From: tip-bot for Cong Ding Message-ID: Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, slash@ac.auone-net.jp, jkosina@suse.cz, jarkko.sakkinen@intel.com, matt.fleming@intel.com, dinggnu@gmail.com, tglx@linutronix.de Reply-To: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, slash@ac.auone-net.jp, jarkko.sakkinen@intel.com, jkosina@suse.cz, matt.fleming@intel.com, dinggnu@gmail.com, tglx@linutronix.de In-Reply-To: <1358183628-27784-1-git-send-email-dinggnu@gmail.com> References: <1358183628-27784-1-git-send-email-dinggnu@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/boot] x86/boot: Fix minor fd leakage in tools/relocs.c Git-Commit-ID: 65315d4889d403ea025081d8ca85ddf7b9c10f39 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (terminus.zytor.com [127.0.0.1]); Sun, 27 Jan 2013 16:06:10 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 65315d4889d403ea025081d8ca85ddf7b9c10f39 Gitweb: http://git.kernel.org/tip/65315d4889d403ea025081d8ca85ddf7b9c10f39 Author: Cong Ding AuthorDate: Mon, 14 Jan 2013 17:13:35 +0000 Committer: H. Peter Anvin CommitDate: Sun, 27 Jan 2013 10:24:28 -0800 x86/boot: Fix minor fd leakage in tools/relocs.c The opened file should be closed. Signed-off-by: Cong Ding Cc: Kusanagi Kouichi Cc: Jarkko Sakkinen Cc: Jiri Kosina Cc: Matt Fleming Link: http://lkml.kernel.org/r/1358183628-27784-1-git-send-email-dinggnu@gmail.com Signed-off-by: Ingo Molnar --- arch/x86/tools/relocs.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c index 5a1847d..79d67bd 100644 --- a/arch/x86/tools/relocs.c +++ b/arch/x86/tools/relocs.c @@ -814,12 +814,14 @@ int main(int argc, char **argv) read_relocs(fp); if (show_absolute_syms) { print_absolute_symbols(); - return 0; + goto out; } if (show_absolute_relocs) { print_absolute_relocs(); - return 0; + goto out; } emit_relocs(as_text, use_real_mode); +out: + fclose(fp); return 0; }