From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759591AbcBYFu1 (ORCPT ); Thu, 25 Feb 2016 00:50:27 -0500 Received: from torg.zytor.com ([198.137.202.12]:53904 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751830AbcBYFuX (ORCPT ); Thu, 25 Feb 2016 00:50:23 -0500 Date: Wed, 24 Feb 2016 21:48:15 -0800 From: tip-bot for Josh Poimboeuf Message-ID: Cc: luto@amacapital.net, hpa@zytor.com, jpoimboe@redhat.com, bp@alien8.de, torvalds@linux-foundation.org, brgerst@gmail.com, palves@redhat.com, luto@kernel.org, tglx@linutronix.de, namhyung@gmail.com, acme@kernel.org, mingo@kernel.org, peterz@infradead.org, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, bernd@petrovitsch.priv.at, chris.j.arges@canonical.com, mmarek@suse.cz, akpm@linux-foundation.org, jslaby@suse.cz Reply-To: hpa@zytor.com, luto@amacapital.net, jpoimboe@redhat.com, torvalds@linux-foundation.org, bp@alien8.de, tglx@linutronix.de, namhyung@gmail.com, brgerst@gmail.com, palves@redhat.com, luto@kernel.org, peterz@infradead.org, acme@kernel.org, mingo@kernel.org, dvlasenk@redhat.com, bernd@petrovitsch.priv.at, linux-kernel@vger.kernel.org, mmarek@suse.cz, akpm@linux-foundation.org, jslaby@suse.cz, chris.j.arges@canonical.com In-Reply-To: <15a3eb7ebe68e37755927915f45e4f0bde4d18c5.1453405861.git.jpoimboe@redhat.com> References: <15a3eb7ebe68e37755927915f45e4f0bde4d18c5.1453405861.git.jpoimboe@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/debug] x86/asm/crypto: Don't use RBP as a scratch register Git-Commit-ID: 68874ac3304ade7ed5ebb12af00d6b9bbbca0a16 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 68874ac3304ade7ed5ebb12af00d6b9bbbca0a16 Gitweb: http://git.kernel.org/tip/68874ac3304ade7ed5ebb12af00d6b9bbbca0a16 Author: Josh Poimboeuf AuthorDate: Thu, 21 Jan 2016 16:49:18 -0600 Committer: Ingo Molnar CommitDate: Wed, 24 Feb 2016 08:35:42 +0100 x86/asm/crypto: Don't use RBP as a scratch register The frame pointer (RBP) is getting clobbered in sha1_mb_mgr_submit_avx2() before a function call, which can mess up stack traces. Use R12 instead. Signed-off-by: Josh Poimboeuf Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Chris J Arges Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Jiri Slaby Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/15a3eb7ebe68e37755927915f45e4f0bde4d18c5.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S b/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S index a5a14c6..c3b9447 100644 --- a/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S +++ b/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S @@ -86,8 +86,8 @@ job_rax = %rax len = %rax DWORD_len = %eax -lane = %rbp -tmp3 = %rbp +lane = %r12 +tmp3 = %r12 tmp = %r9 DWORD_tmp = %r9d @@ -99,7 +99,7 @@ lane_data = %r10 # arg 2 : rdx : job ENTRY(sha1_mb_mgr_submit_avx2) push %rbx - push %rbp + push %r12 mov _unused_lanes(state), unused_lanes mov unused_lanes, lane @@ -190,7 +190,7 @@ len_is_0: movl DWORD_tmp, _result_digest+1*16(job_rax) return: - pop %rbp + pop %r12 pop %rbx ret