From: tip-bot for Nikola Pajkovsky <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, mulix@mulix.org, npajkovsky@suse.cz,
jdmason@kudzu.us, hpa@zytor.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: [tip:x86/cleanups] x86/pci-calgary: Fix iommu_free() comparison of unsigned expression >= 0
Date: Sat, 4 Feb 2017 08:19:17 -0800 [thread overview]
Message-ID: <tip-68dee8e2f2cacc54d038394e70d22411dee89da2@git.kernel.org> (raw)
In-Reply-To: <7612c0f9dd7c1290407dbf8e809def922006920b.1479161177.git.npajkovsky@suse.cz>
Commit-ID: 68dee8e2f2cacc54d038394e70d22411dee89da2
Gitweb: http://git.kernel.org/tip/68dee8e2f2cacc54d038394e70d22411dee89da2
Author: Nikola Pajkovsky <npajkovsky@suse.cz>
AuthorDate: Tue, 15 Nov 2016 09:47:49 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sat, 4 Feb 2017 09:27:06 +0100
x86/pci-calgary: Fix iommu_free() comparison of unsigned expression >= 0
commit 8fd524b355da ("x86: Kill bad_dma_address variable") has killed
bad_dma_address variable and used instead of macro DMA_ERROR_CODE
which is always zero. Since dma_addr is unsigned, the statement
dma_addr >= DMA_ERROR_CODE
is always true, and not needed.
arch/x86/kernel/pci-calgary_64.c: In function ‘iommu_free’:
arch/x86/kernel/pci-calgary_64.c:299:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
if (unlikely((dma_addr >= DMA_ERROR_CODE) && (dma_addr < badend))) {
Fixes: 8fd524b355da ("x86: Kill bad_dma_address variable")
Signed-off-by: Nikola Pajkovsky <npajkovsky@suse.cz>
Cc: iommu@lists.linux-foundation.org
Cc: Jon Mason <jdmason@kudzu.us>
Cc: Muli Ben-Yehuda <mulix@mulix.org>
Link: http://lkml.kernel.org/r/7612c0f9dd7c1290407dbf8e809def922006920b.1479161177.git.npajkovsky@suse.cz
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/pci-calgary_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c
index 5d400ba..d475179 100644
--- a/arch/x86/kernel/pci-calgary_64.c
+++ b/arch/x86/kernel/pci-calgary_64.c
@@ -296,7 +296,7 @@ static void iommu_free(struct iommu_table *tbl, dma_addr_t dma_addr,
/* were we called with bad_dma_address? */
badend = DMA_ERROR_CODE + (EMERGENCY_PAGES * PAGE_SIZE);
- if (unlikely((dma_addr >= DMA_ERROR_CODE) && (dma_addr < badend))) {
+ if (unlikely(dma_addr < badend)) {
WARN(1, KERN_ERR "Calgary: driver tried unmapping bad DMA "
"address 0x%Lx\n", dma_addr);
return;
prev parent reply other threads:[~2017-02-04 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 8:47 [PATCH] iommu: fix iommu_free() comparison of unsigned expression >= 0 Nikola Pajkovsky
2017-02-04 16:19 ` tip-bot for Nikola Pajkovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-68dee8e2f2cacc54d038394e70d22411dee89da2@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mulix@mulix.org \
--cc=npajkovsky@suse.cz \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).