From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751409AbdJEM3B (ORCPT ); Thu, 5 Oct 2017 08:29:01 -0400 Received: from terminus.zytor.com ([65.50.211.136]:44451 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbdJEM27 (ORCPT ); Thu, 5 Oct 2017 08:28:59 -0400 Date: Thu, 5 Oct 2017 05:27:46 -0700 From: tip-bot for Nicolas Iooss Message-ID: Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, nicolas.iooss_linux@m4x.org, tglx@linutronix.de, bp@suse.de, hpa@zytor.com Reply-To: hpa@zytor.com, bp@suse.de, tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, nicolas.iooss_linux@m4x.org In-Reply-To: <20170903075440.30250-1-nicolas.iooss_linux@m4x.org> References: <20170903075440.30250-1-nicolas.iooss_linux@m4x.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:ras/urgent] RAS/CEC: Use the right length for "cec_disable" Git-Commit-ID: 69a330007091ea8a801dd9fcd897ec52f9529586 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 69a330007091ea8a801dd9fcd897ec52f9529586 Gitweb: https://git.kernel.org/tip/69a330007091ea8a801dd9fcd897ec52f9529586 Author: Nicolas Iooss AuthorDate: Mon, 2 Oct 2017 11:28:35 +0200 Committer: Thomas Gleixner CommitDate: Thu, 5 Oct 2017 14:23:06 +0200 RAS/CEC: Use the right length for "cec_disable" parse_cec_param() compares a string with "cec_disable" using only 7 characters of the 11-character-long string. The proper solution for this would be: #define CEC_DISABLE "cec_disable" strncmp(str, CEC_DISABLE, strlen(CEC_DISABLE)) but when comparing a string against a string constant strncmp() has no advantage over strcmp() because the comparison is guaranteed to be bound by the string constant. So just replace str strncmp() with strcmp(). [ tglx: Made it use strcmp and updated the changelog ] Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector") Signed-off-by: Nicolas Iooss Signed-off-by: Borislav Petkov Signed-off-by: Thomas Gleixner Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/20170903075440.30250-1-nicolas.iooss_linux@m4x.org --- drivers/ras/cec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c index d0e5d6e..e2c1988 100644 --- a/drivers/ras/cec.c +++ b/drivers/ras/cec.c @@ -523,7 +523,7 @@ int __init parse_cec_param(char *str) if (*str == '=') str++; - if (!strncmp(str, "cec_disable", 7)) + if (!strcmp(str, "cec_disable")) ce_arr.disabled = 1; else return 0;