From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932568AbcBWJKB (ORCPT ); Tue, 23 Feb 2016 04:10:01 -0500 Received: from terminus.zytor.com ([198.137.202.10]:58108 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064AbcBWJJ5 (ORCPT ); Tue, 23 Feb 2016 04:09:57 -0500 Date: Tue, 23 Feb 2016 01:05:05 -0800 From: =?UTF-8?B?dGlwLWJvdCBmb3IgSm9zaCBQb2ltYm9ldWYgPHRpcGJvdEB6eXRvci5jb20+?=@zytor.com Message-ID: Cc: peterz@infradead.org, dvlasenk@redhat.com, jslaby@suse.cz, jpoimboe@redhat.com, Waiman.Long@hpe.com, torvalds@linux-foundation.org, namhyung@gmail.com, palves@redhat.com, luto@amacapital.net, mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, acme@kernel.org, bernd@petrovitsch.priv.at, bp@alien8.de, luto@kernel.org, tglx@linutronix.de, brgerst@gmail.com, akpm@linux-foundation.org, chris.j.arges@canonical.com, mmarek@suse.cz Reply-To: Waiman.Long@hpe.com, torvalds@linux-foundation.org, peterz@infradead.org, dvlasenk@redhat.com, jpoimboe@redhat.com, jslaby@suse.cz, tglx@linutronix.de, luto@kernel.org, brgerst@gmail.com, akpm@linux-foundation.org, chris.j.arges@canonical.com, mmarek@suse.cz, namhyung@gmail.com, palves@redhat.com, mingo@kernel.org, luto@amacapital.net, hpa@zytor.com, bernd@petrovitsch.priv.at, acme@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de In-Reply-To: <6685a72ddbbd0ad3694337cca0af4b4ea09f5f40.1453405861.git.jpoimboe@redhat.com> References: <6685a72ddbbd0ad3694337cca0af4b4ea09f5f40.1453405861.git.jpoimboe@redhat.com> To: =?UTF-8?B?bGludXgtdGlwLWNvbW1pdHNAdmdlci5rZXJuZWwub3Jn?=@zytor.com Subject: =?UTF-8?B?W3RpcDp4ODYvZGVidWddIHg4Ni9sb2NraW5nOiBDcmVhdGUgc3RhY2sgZnJhbWU=?= =?UTF-8?B?IGluIFBWIHVubG9jaw==?= Git-Commit-ID: =?UTF-8?B?NzRkMDNjNTAxYjEwZTM4YzU0NTU0NTY3OTMzNTA5Y2VjZGRkZDFlYg==?= X-Mailer: =?UTF-8?B?dGlwLWdpdC1sb2ctZGFlbW9u?= Robot-ID: =?UTF-8?B?PHRpcC1ib3QuZ2l0Lmtlcm5lbC5vcmc+?= Robot-Unsubscribe: =?UTF-8?B?Q29udGFjdCA8bWFpbHRvOmhwYUBrZXJuZWwub3JnPiB0byBnZXQgYmxhY2tsaXM=?= =?UTF-8?B?dGVkIGZyb20gdGhlc2UgZW1haWxz?= MIME-Version: =?UTF-8?B?MS4w?= Content-Transfer-Encoding: =?UTF-8?B?OGJpdA==?= Content-Type: =?UTF-8?B?dGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOA==?= Content-Disposition: =?UTF-8?B?aW5saW5l?= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 74d03c501b10e38c54554567933509cecdddd1eb Gitweb: http://git.kernel.org/tip/74d03c501b10e38c54554567933509cecdddd1eb Author: Josh Poimboeuf AuthorDate: Thu, 21 Jan 2016 16:49:32 -0600 Committer: Ingo Molnar CommitDate: Tue, 23 Feb 2016 09:04:00 +0100 x86/locking: Create stack frame in PV unlock The assembly PV_UNLOCK function is a callable non-leaf function which doesn't honor CONFIG_FRAME_POINTER, which can result in bad stack traces. Create a stack frame when CONFIG_FRAME_POINTER is enabled. Signed-off-by: Josh Poimboeuf Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Chris J Arges Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Jiri Slaby Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Waiman Long Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/6685a72ddbbd0ad3694337cca0af4b4ea09f5f40.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/include/asm/qspinlock_paravirt.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/include/asm/qspinlock_paravirt.h b/arch/x86/include/asm/qspinlock_paravirt.h index 9f92c18..9d55f9b 100644 --- a/arch/x86/include/asm/qspinlock_paravirt.h +++ b/arch/x86/include/asm/qspinlock_paravirt.h @@ -36,8 +36,10 @@ PV_CALLEE_SAVE_REGS_THUNK(__pv_queued_spin_unlock_slowpath); */ asm (".pushsection .text;" ".globl " PV_UNLOCK ";" + ".type " PV_UNLOCK ", @function;" ".align 4,0x90;" PV_UNLOCK ": " + FRAME_BEGIN "push %rdx;" "mov $0x1,%eax;" "xor %edx,%edx;" @@ -45,6 +47,7 @@ asm (".pushsection .text;" "cmp $0x1,%al;" "jne .slowpath;" "pop %rdx;" + FRAME_END "ret;" ".slowpath: " "push %rsi;" @@ -52,6 +55,7 @@ asm (".pushsection .text;" "call " PV_UNLOCK_SLOWPATH ";" "pop %rsi;" "pop %rdx;" + FRAME_END "ret;" ".size " PV_UNLOCK ", .-" PV_UNLOCK ";" ".popsection");