From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbbDCFHP (ORCPT ); Fri, 3 Apr 2015 01:07:15 -0400 Received: from terminus.zytor.com ([198.137.202.10]:42949 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbbDCFHM (ORCPT ); Fri, 3 Apr 2015 01:07:12 -0400 Date: Thu, 2 Apr 2015 22:06:39 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: jolsa@redhat.com, adrian.hunter@intel.com, eranian@google.com, acme@redhat.com, linux-kernel@vger.kernel.org, bp@suse.de, mingo@kernel.org, fweisbec@gmail.com, tglx@linutronix.de, dsahern@gmail.com, dzickus@redhat.com, namhyung@kernel.org, hpa@zytor.com Reply-To: linux-kernel@vger.kernel.org, bp@suse.de, mingo@kernel.org, fweisbec@gmail.com, dsahern@gmail.com, tglx@linutronix.de, dzickus@redhat.com, hpa@zytor.com, namhyung@kernel.org, jolsa@redhat.com, adrian.hunter@intel.com, eranian@google.com, acme@redhat.com In-Reply-To: <1427906210-10519-2-git-send-email-acme@kernel.org> References: <1427906210-10519-2-git-send-email-acme@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf script: No need to lookup thread twice Git-Commit-ID: 79628f2cfe0f488b23e5dc99a4a9a599032fa653 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 79628f2cfe0f488b23e5dc99a4a9a599032fa653 Gitweb: http://git.kernel.org/tip/79628f2cfe0f488b23e5dc99a4a9a599032fa653 Author: Arnaldo Carvalho de Melo AuthorDate: Wed, 1 Apr 2015 13:26:45 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 2 Apr 2015 13:18:21 -0300 perf script: No need to lookup thread twice We get the thread when we call perf_event__preprocess_sample(), no need to do it before that. Acked-by: Jiri Olsa Acked-by: Namhyung Kim Cc: Adrian Hunter Cc: Borislav Petkov Cc: David Ahern Cc: Don Zickus Cc: Frederic Weisbecker Cc: Stephane Eranian Link: http://lkml.kernel.org/r/1427906210-10519-2-git-send-email-acme@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-script.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index 662366c..c286b49 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c @@ -549,14 +549,6 @@ static int process_sample_event(struct perf_tool *tool __maybe_unused, struct machine *machine) { struct addr_location al; - struct thread *thread = machine__findnew_thread(machine, sample->pid, - sample->tid); - - if (thread == NULL) { - pr_debug("problem processing %d event, skipping it.\n", - event->header.type); - return -1; - } if (debug_mode) { if (sample->time < last_timestamp) { @@ -581,7 +573,7 @@ static int process_sample_event(struct perf_tool *tool __maybe_unused, if (cpu_list && !test_bit(sample->cpu, cpu_bitmap)) return 0; - scripting_ops->process_event(event, sample, evsel, thread, &al); + scripting_ops->process_event(event, sample, evsel, al.thread, &al); return 0; }