From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754057AbcFPIhe (ORCPT ); Thu, 16 Jun 2016 04:37:34 -0400 Received: from terminus.zytor.com ([198.137.202.10]:33528 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbcFPIha (ORCPT ); Thu, 16 Jun 2016 04:37:30 -0400 Date: Thu, 16 Jun 2016 01:37:20 -0700 From: tip-bot for Jiri Olsa Message-ID: Cc: hpa@zytor.com, mingo@kernel.org, namhyung@kernel.org, a.p.zijlstra@chello.nl, jolsa@kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com, tglx@linutronix.de, dsahern@gmail.com Reply-To: a.p.zijlstra@chello.nl, mingo@kernel.org, namhyung@kernel.org, hpa@zytor.com, jolsa@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, acme@redhat.com, dsahern@gmail.com In-Reply-To: <1465928361-2442-8-git-send-email-jolsa@kernel.org> References: <1465928361-2442-8-git-send-email-jolsa@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf stdio: Do not pass hists in hist_entry__fprintf Git-Commit-ID: 8f1d1b4452ce71a231d1a22e6357285fb773c551 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 8f1d1b4452ce71a231d1a22e6357285fb773c551 Gitweb: http://git.kernel.org/tip/8f1d1b4452ce71a231d1a22e6357285fb773c551 Author: Jiri Olsa AuthorDate: Tue, 14 Jun 2016 20:19:17 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 15 Jun 2016 10:47:11 -0300 perf stdio: Do not pass hists in hist_entry__fprintf There's no need, we have the hists pointer in struct hist_entry. Signed-off-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1465928361-2442-8-git-send-email-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/stdio/hist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c index 5d00783..150c4de 100644 --- a/tools/perf/ui/stdio/hist.c +++ b/tools/perf/ui/stdio/hist.c @@ -492,7 +492,6 @@ out: } static int hist_entry__fprintf(struct hist_entry *he, size_t size, - struct hists *hists, char *bf, size_t bfsz, FILE *fp) { int ret; @@ -500,6 +499,7 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size, .buf = bf, .size = size, }; + struct hists *hists = he->hists; u64 total_period = hists->stats.total_period; if (size == 0 || size > bfsz) @@ -755,7 +755,7 @@ size_t hists__fprintf(struct hists *hists, bool show_header, int max_rows, if (percent < min_pcnt) continue; - ret += hist_entry__fprintf(h, max_cols, hists, line, linesz, fp); + ret += hist_entry__fprintf(h, max_cols, line, linesz, fp); if (max_rows && ++nr_rows >= max_rows) break;