From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932894AbcBWJLP (ORCPT ); Tue, 23 Feb 2016 04:11:15 -0500 Received: from terminus.zytor.com ([198.137.202.10]:58412 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754110AbcBWJLJ (ORCPT ); Tue, 23 Feb 2016 04:11:09 -0500 Date: Tue, 23 Feb 2016 01:04:40 -0800 From: =?UTF-8?B?dGlwLWJvdCBmb3IgSm9zaCBQb2ltYm9ldWYgPHRpcGJvdEB6eXRvci5jb20+?=@zytor.com Message-ID: Cc: hpa@zytor.com, acme@kernel.org, torvalds@linux-foundation.org, jslaby@suse.cz, brgerst@gmail.com, mmarek@suse.cz, luto@amacapital.net, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, luto@kernel.org, bp@alien8.de, bernd@petrovitsch.priv.at, namhyung@gmail.com, tglx@linutronix.de, akpm@linux-foundation.org, mingo@kernel.org, wim@iguana.be, chris.j.arges@canonical.com, palves@redhat.com, peterz@infradead.org, dvlasenk@redhat.com, linux@roeck-us.net Reply-To: dvlasenk@redhat.com, linux@roeck-us.net, chris.j.arges@canonical.com, wim@iguana.be, mingo@kernel.org, palves@redhat.com, peterz@infradead.org, tglx@linutronix.de, akpm@linux-foundation.org, bernd@petrovitsch.priv.at, namhyung@gmail.com, bp@alien8.de, luto@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, mmarek@suse.cz, jpoimboe@redhat.com, torvalds@linux-foundation.org, jslaby@suse.cz, brgerst@gmail.com, hpa@zytor.com, acme@kernel.org In-Reply-To: <60de3cfb6f16d413bfb923036cc87fec132df735.1453405861.git.jpoimboe@redhat.com> References: <60de3cfb6f16d413bfb923036cc87fec132df735.1453405861.git.jpoimboe@redhat.com> To: =?UTF-8?B?bGludXgtdGlwLWNvbW1pdHNAdmdlci5rZXJuZWwub3Jn?=@zytor.com Subject: =?UTF-8?B?W3RpcDp4ODYvZGVidWddIHdhdGNoZG9nL2hwd2R0OiBDcmVhdGUgc3RhY2sgZnI=?= =?UTF-8?B?YW1lIGluIGFzbWlubGluZV9jYWxsKCk=?= Git-Commit-ID: =?UTF-8?B?YTIxNmM4NzVhMDE1MjA4OTZjN2VkOWVhNDM3NzlhM2RhNDEwM2VlOQ==?= X-Mailer: =?UTF-8?B?dGlwLWdpdC1sb2ctZGFlbW9u?= Robot-ID: =?UTF-8?B?PHRpcC1ib3QuZ2l0Lmtlcm5lbC5vcmc+?= Robot-Unsubscribe: =?UTF-8?B?Q29udGFjdCA8bWFpbHRvOmhwYUBrZXJuZWwub3JnPiB0byBnZXQgYmxhY2tsaXM=?= =?UTF-8?B?dGVkIGZyb20gdGhlc2UgZW1haWxz?= MIME-Version: =?UTF-8?B?MS4w?= Content-Transfer-Encoding: =?UTF-8?B?OGJpdA==?= Content-Type: =?UTF-8?B?dGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOA==?= Content-Disposition: =?UTF-8?B?aW5saW5l?= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a216c875a01520896c7ed9ea43779a3da4103ee9 Gitweb: http://git.kernel.org/tip/a216c875a01520896c7ed9ea43779a3da4103ee9 Author: Josh Poimboeuf AuthorDate: Thu, 21 Jan 2016 16:49:31 -0600 Committer: Ingo Molnar CommitDate: Tue, 23 Feb 2016 09:04:00 +0100 watchdog/hpwdt: Create stack frame in asminline_call() asminline_call() is a callable non-leaf function which doesn't honor CONFIG_FRAME_POINTER, which can result in bad stack traces. Create a stack frame when CONFIG_FRAME_POINTER is enabled. Signed-off-by: Josh Poimboeuf Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Chris J Arges Cc: Denys Vlasenko Cc: Guenter Roeck Cc: H. Peter Anvin Cc: Jiri Slaby Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Wim Van Sebroeck Cc: linux-watchdog@vger.kernel.org Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/60de3cfb6f16d413bfb923036cc87fec132df735.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- drivers/watchdog/hpwdt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index 92443c3..90016db 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -353,10 +353,10 @@ static int detect_cru_service(void) asm(".text \n\t" ".align 4 \n\t" - ".globl asminline_call \n" + ".globl asminline_call \n\t" + ".type asminline_call, @function \n\t" "asminline_call: \n\t" - "pushq %rbp \n\t" - "movq %rsp, %rbp \n\t" + FRAME_BEGIN "pushq %rax \n\t" "pushq %rbx \n\t" "pushq %rdx \n\t" @@ -386,7 +386,7 @@ asm(".text \n\t" "popq %rdx \n\t" "popq %rbx \n\t" "popq %rax \n\t" - "leave \n\t" + FRAME_END "ret \n\t" ".previous");