From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754329AbcBPHyM (ORCPT ); Tue, 16 Feb 2016 02:54:12 -0500 Received: from terminus.zytor.com ([198.137.202.10]:40643 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754307AbcBPHyI (ORCPT ); Tue, 16 Feb 2016 02:54:08 -0500 Date: Mon, 15 Feb 2016 23:53:53 -0800 From: tip-bot for Wang Nan Message-ID: Cc: masami.hiramatsu.pt@hitachi.com, ast@kernel.org, hpa@zytor.com, tglx@linutronix.de, jolsa@kernel.org, lizefan@huawei.com, mingo@kernel.org, hekuang@huawei.com, acme@redhat.com, wangnan0@huawei.com, namhyung@kernel.org, linux-kernel@vger.kernel.org Reply-To: acme@redhat.com, mingo@kernel.org, hekuang@huawei.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, namhyung@kernel.org, wangnan0@huawei.com, hpa@zytor.com, masami.hiramatsu.pt@hitachi.com, ast@kernel.org, tglx@linutronix.de, jolsa@kernel.org In-Reply-To: <1454680939-24963-2-git-send-email-wangnan0@huawei.com> References: <1454680939-24963-2-git-send-email-wangnan0@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Unlink entries from terms list Git-Commit-ID: a8adfceb389a0045e06af22517fa3326797b160a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a8adfceb389a0045e06af22517fa3326797b160a Gitweb: http://git.kernel.org/tip/a8adfceb389a0045e06af22517fa3326797b160a Author: Wang Nan AuthorDate: Fri, 12 Feb 2016 16:31:23 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 12 Feb 2016 16:51:15 -0300 perf tools: Unlink entries from terms list We were just freeing them, better unlink and init its nodes to catch bugs faster if we keep dangling references to them. Signed-off-by: Wang Nan Acked-by: Jiri Olsa Cc: Alexei Starovoitov Cc: He Kuang Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Zefan Li Cc: pi3orama@163.com [ Spun off from another patch, use list_del_init() instead of list_del() ] Link: http://lkml.kernel.org/r/1454680939-24963-2-git-send-email-wangnan0@huawei.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/parse-events.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 813d9b2..133c8d2 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -2072,8 +2072,10 @@ void parse_events__free_terms(struct list_head *terms) { struct parse_events_term *term, *h; - list_for_each_entry_safe(term, h, terms, list) + list_for_each_entry_safe(term, h, terms, list) { + list_del_init(&term->list); free(term); + } } void parse_events_evlist_error(struct parse_events_evlist *data,