From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752201AbdKHLBg (ORCPT ); Wed, 8 Nov 2017 06:01:36 -0500 Received: from terminus.zytor.com ([65.50.211.136]:44821 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbdKHLBe (ORCPT ); Wed, 8 Nov 2017 06:01:34 -0500 Date: Wed, 8 Nov 2017 02:57:01 -0800 From: tip-bot for Frederic Weisbecker Message-ID: Cc: torvalds@linux-foundation.org, mingo@kernel.org, tj@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, davem@davemloft.net, jiangshanlai@gmail.com, paulmck@linux.vnet.ibm.com, tglx@linutronix.de, hpa@zytor.com, frederic@kernel.org Reply-To: paulmck@linux.vnet.ibm.com, tglx@linutronix.de, hpa@zytor.com, frederic@kernel.org, torvalds@linux-foundation.org, mingo@kernel.org, tj@kernel.org, linux-kernel@vger.kernel.org, jiangshanlai@gmail.com, davem@davemloft.net, peterz@infradead.org In-Reply-To: <1509980490-4285-14-git-send-email-frederic@kernel.org> References: <1509980490-4285-14-git-send-email-frederic@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/core] netpoll: Use lockdep to assert IRQs are disabled/enabled Git-Commit-ID: af0733937317e1e03b60f3af8cf9cd59d665593c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: af0733937317e1e03b60f3af8cf9cd59d665593c Gitweb: https://git.kernel.org/tip/af0733937317e1e03b60f3af8cf9cd59d665593c Author: Frederic Weisbecker AuthorDate: Mon, 6 Nov 2017 16:01:29 +0100 Committer: Ingo Molnar CommitDate: Wed, 8 Nov 2017 11:13:54 +0100 netpoll: Use lockdep to assert IRQs are disabled/enabled Use lockdep to check that IRQs are enabled or disabled as expected. This way the sanity check only shows overhead when concurrency correctness debug code is enabled. Signed-off-by: Frederic Weisbecker Acked-by: Thomas Gleixner Cc: David S. Miller Cc: Lai Jiangshan Cc: Linus Torvalds Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Tejun Heo Link: http://lkml.kernel.org/r/1509980490-4285-14-git-send-email-frederic@kernel.org Signed-off-by: Ingo Molnar --- net/core/netpoll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 912731b..57557a6 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -334,7 +334,7 @@ void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb, /* It is up to the caller to keep npinfo alive. */ struct netpoll_info *npinfo; - WARN_ON_ONCE(!irqs_disabled()); + lockdep_assert_irqs_disabled(); npinfo = rcu_dereference_bh(np->dev->npinfo); if (!npinfo || !netif_running(dev) || !netif_device_present(dev)) {