From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752992AbcGSHbK (ORCPT ); Tue, 19 Jul 2016 03:31:10 -0400 Received: from terminus.zytor.com ([198.137.202.10]:46608 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752643AbcGSHbG (ORCPT ); Tue, 19 Jul 2016 03:31:06 -0400 Date: Tue, 19 Jul 2016 00:30:35 -0700 From: tip-bot for Richard Cochran Message-ID: Cc: maxime.coquelin@st.com, torvalds@linux-foundation.org, hpa@zytor.com, peterz@infradead.org, patrice.chotard@st.com, bigeasy@linutronix.de, tglx@linutronix.de, srinivas.kandagatla@gmail.com, mingo@kernel.org, linux-kernel@vger.kernel.org, anna-maria@linutronix.de, daniel.lezcano@linaro.org, rcochran@linutronix.de Reply-To: torvalds@linux-foundation.org, hpa@zytor.com, maxime.coquelin@st.com, bigeasy@linutronix.de, patrice.chotard@st.com, peterz@infradead.org, mingo@kernel.org, srinivas.kandagatla@gmail.com, tglx@linutronix.de, rcochran@linutronix.de, daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org, anna-maria@linutronix.de In-Reply-To: <20160713153338.062741642@linutronix.de> References: <20160713153338.062741642@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:smp/hotplug] clocksource/arm_global_timer: Convert to hotplug state machine Git-Commit-ID: b8a12296ac812f829bd9392346b01b1872d8118b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: b8a12296ac812f829bd9392346b01b1872d8118b Gitweb: http://git.kernel.org/tip/b8a12296ac812f829bd9392346b01b1872d8118b Author: Richard Cochran AuthorDate: Wed, 13 Jul 2016 17:17:04 +0000 Committer: Ingo Molnar CommitDate: Fri, 15 Jul 2016 10:41:44 +0200 clocksource/arm_global_timer: Convert to hotplug state machine Install the callbacks via the state machine and let the core invoke the callbacks on the already online CPUs. Signed-off-by: Richard Cochran Signed-off-by: Anna-Maria Gleixner Reviewed-by: Sebastian Andrzej Siewior Cc: Daniel Lezcano Cc: Linus Torvalds Cc: Maxime Coquelin Cc: Patrice Chotard Cc: Peter Zijlstra Cc: Srinivas Kandagatla Cc: Thomas Gleixner Cc: kernel@stlinux.com Cc: linux-arm-kernel@lists.infradead.org Cc: rt@linutronix.de Link: http://lkml.kernel.org/r/20160713153338.062741642@linutronix.de Signed-off-by: Ingo Molnar --- drivers/clocksource/arm_global_timer.c | 39 +++++++++------------------------- include/linux/cpuhotplug.h | 1 + 2 files changed, 11 insertions(+), 29 deletions(-) diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c index 2a9ceb6..8da0329 100644 --- a/drivers/clocksource/arm_global_timer.c +++ b/drivers/clocksource/arm_global_timer.c @@ -165,9 +165,9 @@ static irqreturn_t gt_clockevent_interrupt(int irq, void *dev_id) return IRQ_HANDLED; } -static int gt_clockevents_init(struct clock_event_device *clk) +static int gt_starting_cpu(unsigned int cpu) { - int cpu = smp_processor_id(); + struct clock_event_device *clk = this_cpu_ptr(gt_evt); clk->name = "arm_global_timer"; clk->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT | @@ -186,10 +186,13 @@ static int gt_clockevents_init(struct clock_event_device *clk) return 0; } -static void gt_clockevents_stop(struct clock_event_device *clk) +static int gt_dying_cpu(unsigned int cpu) { + struct clock_event_device *clk = this_cpu_ptr(gt_evt); + gt_clockevent_shutdown(clk); disable_percpu_irq(clk->irq); + return 0; } static cycle_t gt_clocksource_read(struct clocksource *cs) @@ -252,24 +255,6 @@ static int __init gt_clocksource_init(void) return clocksource_register_hz(>_clocksource, gt_clk_rate); } -static int gt_cpu_notify(struct notifier_block *self, unsigned long action, - void *hcpu) -{ - switch (action & ~CPU_TASKS_FROZEN) { - case CPU_STARTING: - gt_clockevents_init(this_cpu_ptr(gt_evt)); - break; - case CPU_DYING: - gt_clockevents_stop(this_cpu_ptr(gt_evt)); - break; - } - - return NOTIFY_OK; -} -static struct notifier_block gt_cpu_nb = { - .notifier_call = gt_cpu_notify, -}; - static int __init global_timer_of_register(struct device_node *np) { struct clk *gt_clk; @@ -325,18 +310,14 @@ static int __init global_timer_of_register(struct device_node *np) goto out_free; } - err = register_cpu_notifier(>_cpu_nb); - if (err) { - pr_warn("global-timer: unable to register cpu notifier.\n"); - goto out_irq; - } - - /* Immediately configure the timer on the boot CPU */ + /* Register and immediately configure the timer on the boot CPU */ err = gt_clocksource_init(); if (err) goto out_irq; - err = gt_clockevents_init(this_cpu_ptr(gt_evt)); + err = cpuhp_setup_state(CPUHP_AP_ARM_GLOBAL_TIMER_STARTING, + "AP_ARM_GLOBAL_TIMER_STARTING", + gt_starting_cpu, gt_dying_cpu); if (err) goto out_irq; diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h index 201a2e2..d24b0fc 100644 --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -47,6 +47,7 @@ enum cpuhp_state { CPUHP_AP_PERF_ARM_STARTING, CPUHP_AP_ARM_L2X0_STARTING, CPUHP_AP_ARM_ARCH_TIMER_STARTING, + CPUHP_AP_ARM_GLOBAL_TIMER_STARTING, CPUHP_AP_DUMMY_TIMER_STARTING, CPUHP_AP_ARM_TWD_STARTING, CPUHP_AP_METAG_TIMER_STARTING,