From: tip-bot for Paul Bolle <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: pebolle@tiscali.nl, linux-kernel@vger.kernel.org,
peterz@infradead.org, hpa@zytor.com,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
mingo@kernel.org, tglx@linutronix.de
Subject: [tip:x86/asm] x86/decoder: Use stdout if insn decoder test is successful
Date: Tue, 25 Oct 2016 23:54:42 -0700 [thread overview]
Message-ID: <tip-bdcc18b548b8f1fab23c097724c6f32daac03185@git.kernel.org> (raw)
In-Reply-To: <1477428965-20548-2-git-send-email-pebolle@tiscali.nl>
Commit-ID: bdcc18b548b8f1fab23c097724c6f32daac03185
Gitweb: http://git.kernel.org/tip/bdcc18b548b8f1fab23c097724c6f32daac03185
Author: Paul Bolle <pebolle@tiscali.nl>
AuthorDate: Tue, 25 Oct 2016 22:56:04 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 26 Oct 2016 08:41:06 +0200
x86/decoder: Use stdout if insn decoder test is successful
If the instruction decoder test ran successful it prints a message like
this to stderr:
Succeed: decoded and checked 1767380 instructions
But, as described in "console mode programming user interface guidelines
version 101" which doesn't exist, programs should use stderr for errors
or warnings. We're told about a successful run here, so the instruction
decoder test should use stdout.
Let's fix the typo too, while we're at it.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1477428965-20548-2-git-send-email-pebolle@tiscali.nl
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/tools/test_get_len.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/tools/test_get_len.c b/arch/x86/tools/test_get_len.c
index 56f04db..ecf31e0 100644
--- a/arch/x86/tools/test_get_len.c
+++ b/arch/x86/tools/test_get_len.c
@@ -167,7 +167,7 @@ int main(int argc, char **argv)
fprintf(stderr, "Warning: decoded and checked %d"
" instructions with %d warnings\n", insns, warnings);
else
- fprintf(stderr, "Succeed: decoded and checked %d"
+ fprintf(stdout, "Success: decoded and checked %d"
" instructions\n", insns);
return 0;
}
next prev parent reply other threads:[~2016-10-26 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 20:56 [PATCH 0/2] x86: use stdout for success and stdout for failure Paul Bolle
2016-10-25 20:56 ` [PATCH 1/2] x86: use stdout if insn decoder test is successful Paul Bolle
2016-10-26 6:54 ` tip-bot for Paul Bolle [this message]
2016-10-25 20:56 ` [PATCH 2/2] x86: use stderr if insn sanity test fails Paul Bolle
2016-10-26 6:55 ` [tip:x86/asm] x86/decoder: Use " tip-bot for Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-bdcc18b548b8f1fab23c097724c6f32daac03185@git.kernel.org \
--to=tipbot@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pebolle@tiscali.nl \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).