From: tip-bot for Taeung Song <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, dzickus@redhat.com, tglx@linutronix.de,
wangnan0@huawei.com, mhiramat@kernel.org, acme@redhat.com,
mingo@kernel.org, linux-kernel@vger.kernel.org,
peterz@infradead.org, dsahern@gmail.com, namhyung@kernel.org,
jolsa@kernel.org, treeze.taeung@gmail.com
Subject: [tip:perf/core] perf tools: Refactor the code to strip command name with {l,r}trim()
Date: Tue, 11 Apr 2017 22:36:56 -0700 [thread overview]
Message-ID: <tip-bdd97ca63faa374c98314d53c0bcaedb473c5a33@git.kernel.org> (raw)
In-Reply-To: <1491575061-704-6-git-send-email-treeze.taeung@gmail.com>
Commit-ID: bdd97ca63faa374c98314d53c0bcaedb473c5a33
Gitweb: http://git.kernel.org/tip/bdd97ca63faa374c98314d53c0bcaedb473c5a33
Author: Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Fri, 7 Apr 2017 23:24:21 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 11 Apr 2017 15:23:26 -0300
perf tools: Refactor the code to strip command name with {l,r}trim()
After reading command name from /proc/<pid>/status, use ltrim() and
rtrim() to strip command name, not using just while loop, isspace() and
etc.
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1491575061-704-6-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/event.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 76b9c6b..8255a26 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -106,7 +106,7 @@ static int perf_event__get_comm_ids(pid_t pid, char *comm, size_t len,
int fd;
size_t size = 0;
ssize_t n;
- char *nl, *name, *tgids, *ppids;
+ char *name, *tgids, *ppids;
*tgid = -1;
*ppid = -1;
@@ -134,14 +134,7 @@ static int perf_event__get_comm_ids(pid_t pid, char *comm, size_t len,
if (name) {
name += 5; /* strlen("Name:") */
-
- while (*name && isspace(*name))
- ++name;
-
- nl = strchr(name, '\n');
- if (nl)
- *nl = '\0';
-
+ name = rtrim(ltrim(name));
size = strlen(name);
if (size >= len)
size = len - 1;
prev parent reply other threads:[~2017-04-12 5:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 14:24 [PATCH 0/5] Refactoring with ltrim() and rtrim() Taeung Song
2017-04-07 14:24 ` [PATCH 1/5] perf annotate: Refactor the code to parse disassemble lines with {l,r}trim() Taeung Song
2017-04-07 15:01 ` Arnaldo Carvalho de Melo
2017-04-07 15:04 ` Arnaldo Carvalho de Melo
2017-04-07 18:08 ` Taeung Song
2017-04-07 15:04 ` Arnaldo Carvalho de Melo
2017-04-08 0:12 ` Taeung Song
2017-04-07 14:24 ` [PATCH 2/5] perf stat: Refactor the code to strip csv output with ltrim() Taeung Song
2017-04-07 15:06 ` Arnaldo Carvalho de Melo
2017-04-07 23:45 ` Taeung Song
2017-04-12 5:35 ` [tip:perf/core] " tip-bot for Taeung Song
2017-04-07 14:24 ` [PATCH 3/5] perf ui browser: Refactor the code to parse color configs " Taeung Song
2017-04-12 5:35 ` [tip:perf/core] " tip-bot for Taeung Song
2017-04-07 14:24 ` [PATCH 4/5] perf pmu: Refactor wordwrap() " Taeung Song
2017-04-12 5:36 ` [tip:perf/core] " tip-bot for Taeung Song
2017-04-07 14:24 ` [PATCH 5/5] perf tools: Refactor the code to strip command name with {l,r}trim() Taeung Song
2017-04-12 5:36 ` tip-bot for Taeung Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-bdd97ca63faa374c98314d53c0bcaedb473c5a33@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=treeze.taeung@gmail.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).