linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] perf tools: Initialize perf_data_file fd field
@ 2018-08-29 20:16 Jérémie Galarneau
  2018-09-05 16:09 ` Jiri Olsa
  2018-09-25  9:33 ` [tip:perf/core] " tip-bot for Jérémie Galarneau
  0 siblings, 2 replies; 5+ messages in thread
From: Jérémie Galarneau @ 2018-08-29 20:16 UTC (permalink / raw)
  To: linux-kernel
  Cc: Jérémie Galarneau, Jiri Olsa, Arnaldo Carvalho de Melo,
	Peter Zijlstra, Ingo Molnar, Alexander Shishkin

Building the perf CTF converter fails with gcc 4.8.4
on Ubuntu 14.04 with the following error:

error: missing initializer for field ‘fd’ of ‘struct perf_data_file’
[-Werror=missing-field-initializers]

Per 4b838b0d and the ensuing discussion on the mailing
list, it appears that this affects other distributions
and gcc versions.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 tools/perf/util/data-convert-bt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index abd38abf1d91..f75d4aa612c5 100644
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -1578,7 +1578,7 @@ int bt_convert__perf2ctf(const char *input, const char *path,
 {
 	struct perf_session *session;
 	struct perf_data data = {
-		.file.path = input,
+		.file      = { .path = input, .fd = -1 },
 		.mode      = PERF_DATA_MODE_READ,
 		.force     = opts->force,
 	};
-- 
2.18.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-09-25  9:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-29 20:16 [PATCH] perf tools: Initialize perf_data_file fd field Jérémie Galarneau
2018-09-05 16:09 ` Jiri Olsa
2018-09-18 18:07   ` Jérémie Galarneau
2018-09-18 18:59     ` Arnaldo Carvalho de Melo
2018-09-25  9:33 ` [tip:perf/core] " tip-bot for Jérémie Galarneau

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).