From: tip-bot for Lauro Ramos Venancio <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, hpa@zytor.com, lvenanci@redhat.com,
tglx@linutronix.de, torvalds@linux-foundation.org, efault@gmx.de,
linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: [tip:sched/core] sched/topology: Move comment about asymmetric node setups
Date: Mon, 15 May 2017 02:06:34 -0700 [thread overview]
Message-ID: <tip-c20e1ea4b61c3d99a354d912f2d74822fd2a001d@git.kernel.org> (raw)
In-Reply-To: <1492717903-5195-4-git-send-email-lvenanci@redhat.com>
Commit-ID: c20e1ea4b61c3d99a354d912f2d74822fd2a001d
Gitweb: http://git.kernel.org/tip/c20e1ea4b61c3d99a354d912f2d74822fd2a001d
Author: Lauro Ramos Venancio <lvenanci@redhat.com>
AuthorDate: Thu, 20 Apr 2017 16:51:42 -0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 15 May 2017 10:15:27 +0200
sched/topology: Move comment about asymmetric node setups
Signed-off-by: Lauro Ramos Venancio <lvenanci@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: lwang@redhat.com
Cc: riel@redhat.com
Link: http://lkml.kernel.org/r/1492717903-5195-4-git-send-email-lvenanci@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/topology.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 5a4d9ae..c10f44a 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -495,14 +495,6 @@ enum s_alloc {
/*
* Build an iteration mask that can exclude certain CPUs from the upwards
* domain traversal.
- *
- * Asymmetric node setups can result in situations where the domain tree is of
- * unequal depth, make sure to skip domains that already cover the entire
- * range.
- *
- * In that case build_sched_domains() will have terminated the iteration early
- * and our sibling sd spans will be empty. Domains should always include the
- * CPU they're built on, so check that.
*/
static void build_group_mask(struct sched_domain *sd, struct sched_group *sg)
{
@@ -590,7 +582,16 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu)
sibling = *per_cpu_ptr(sdd->sd, i);
- /* See the comment near build_group_mask(). */
+ /*
+ * Asymmetric node setups can result in situations where the
+ * domain tree is of unequal depth, make sure to skip domains
+ * that already cover the entire range.
+ *
+ * In that case build_sched_domains() will have terminated the
+ * iteration early and our sibling sd spans will be empty.
+ * Domains should always include the CPU they're built on, so
+ * check that.
+ */
if (!cpumask_test_cpu(i, sched_domain_span(sibling)))
continue;
next prev parent reply other threads:[~2017-05-15 9:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 19:51 [PATCH 0/4] sched/topology: fix overlap group capacity and balance cpu Lauro Ramos Venancio
2017-04-20 19:51 ` [PATCH 1/4] sched/topology: optimize build_group_mask() Lauro Ramos Venancio
2017-05-15 9:06 ` [tip:sched/core] sched/topology: Optimize build_group_mask() tip-bot for Lauro Ramos Venancio
2017-04-20 19:51 ` [PATCH 2/4] sched/topology: all instances of a sched group must use the same sched_group_capacity Lauro Ramos Venancio
2017-04-20 19:51 ` [PATCH 3/4] sched/topology: move comment about asymmetric node setups Lauro Ramos Venancio
2017-04-21 16:31 ` Peter Zijlstra
2017-05-15 9:06 ` tip-bot for Lauro Ramos Venancio [this message]
2017-04-20 19:51 ` [PATCH 4/4] sched/topology: the group balance cpu must be a cpu where the group is installed Lauro Ramos Venancio
2017-04-24 13:03 ` Peter Zijlstra
2017-04-24 14:19 ` Peter Zijlstra
2017-04-24 14:27 ` Peter Zijlstra
2017-04-24 15:19 ` Lauro Venancio
2017-04-24 22:19 ` Peter Zijlstra
2017-04-24 15:11 ` Lauro Venancio
2017-04-24 22:15 ` Peter Zijlstra
2017-04-25 12:17 ` Peter Zijlstra
2017-04-25 14:33 ` Lauro Venancio
2017-04-25 15:12 ` Peter Zijlstra
2017-04-25 15:22 ` Peter Zijlstra
2017-04-25 15:27 ` Peter Zijlstra
2017-04-25 15:39 ` Peter Zijlstra
2017-04-25 15:52 ` Peter Zijlstra
2017-04-25 15:56 ` Lauro Venancio
2017-04-25 16:26 ` Peter Zijlstra
2017-04-26 16:31 ` [PATCH 0/4] sched/topology: fix overlap group capacity and balance cpu Peter Zijlstra
2017-04-26 17:59 ` Lauro Venancio
2017-04-26 22:43 ` Peter Zijlstra
2017-04-28 10:33 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-c20e1ea4b61c3d99a354d912f2d74822fd2a001d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lvenanci@redhat.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).