From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754658AbcBWI7k (ORCPT ); Tue, 23 Feb 2016 03:59:40 -0500 Received: from terminus.zytor.com ([198.137.202.10]:56826 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754497AbcBWI7j (ORCPT ); Tue, 23 Feb 2016 03:59:39 -0500 Date: Tue, 23 Feb 2016 00:58:34 -0800 From: =?UTF-8?B?dGlwLWJvdCBmb3IgSm9zaCBQb2ltYm9ldWYgPHRpcGJvdEB6eXRvci5jb20+?=@zytor.com Message-ID: Cc: jpoimboe@redhat.com, bp@alien8.de, torvalds@linux-foundation.org, palves@redhat.com, herbert@gondor.apana.org.au, mmarek@suse.cz, acme@kernel.org, namhyung@gmail.com, tglx@linutronix.de, brgerst@gmail.com, peterz@infradead.org, jslaby@suse.cz, akpm@linux-foundation.org, bp@suse.de, bernd@petrovitsch.priv.at, luto@amacapital.net, dvlasenk@redhat.com, davem@davemloft.net, linux-kernel@vger.kernel.org, mingo@kernel.org, chris.j.arges@canonical.com, luto@kernel.org, hpa@zytor.com Reply-To: namhyung@gmail.com, tglx@linutronix.de, peterz@infradead.org, brgerst@gmail.com, akpm@linux-foundation.org, jslaby@suse.cz, bp@alien8.de, jpoimboe@redhat.com, mmarek@suse.cz, herbert@gondor.apana.org.au, palves@redhat.com, torvalds@linux-foundation.org, acme@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, chris.j.arges@canonical.com, luto@kernel.org, hpa@zytor.com, bp@suse.de, bernd@petrovitsch.priv.at, davem@davemloft.net, dvlasenk@redhat.com, luto@amacapital.net In-Reply-To: <1dbf80c097bb9d89c0cbddc01a815ada690e3b32.1453405861.git.jpoimboe@redhat.com> References: <1dbf80c097bb9d89c0cbddc01a815ada690e3b32.1453405861.git.jpoimboe@redhat.com> To: =?UTF-8?B?bGludXgtdGlwLWNvbW1pdHNAdmdlci5rZXJuZWwub3Jn?=@zytor.com Subject: =?UTF-8?B?W3RpcDp4ODYvZGVidWddIHg4Ni9hc20vY3J5cHRvOiBNb3ZlIGp1bXBfdGFibGU=?= =?UTF-8?B?IHRvIC5yb2RhdGEgc2VjdGlvbg==?= Git-Commit-ID: =?UTF-8?B?YzI2YWM3MDgxYWYxZjFjZDA1Y2NmZWE4NThkNDU1MTAwMjU1Y2ZkMA==?= X-Mailer: =?UTF-8?B?dGlwLWdpdC1sb2ctZGFlbW9u?= Robot-ID: =?UTF-8?B?PHRpcC1ib3QuZ2l0Lmtlcm5lbC5vcmc+?= Robot-Unsubscribe: =?UTF-8?B?Q29udGFjdCA8bWFpbHRvOmhwYUBrZXJuZWwub3JnPiB0byBnZXQgYmxhY2tsaXM=?= =?UTF-8?B?dGVkIGZyb20gdGhlc2UgZW1haWxz?= MIME-Version: =?UTF-8?B?MS4w?= Content-Transfer-Encoding: =?UTF-8?B?OGJpdA==?= Content-Type: =?UTF-8?B?dGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOA==?= Content-Disposition: =?UTF-8?B?aW5saW5l?= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: c26ac7081af1f1cd05ccfea858d455100255cfd0 Gitweb: http://git.kernel.org/tip/c26ac7081af1f1cd05ccfea858d455100255cfd0 Author: Josh Poimboeuf AuthorDate: Thu, 21 Jan 2016 16:49:16 -0600 Committer: Ingo Molnar CommitDate: Tue, 23 Feb 2016 09:03:56 +0100 x86/asm/crypto: Move jump_table to .rodata section stacktool reports the following warning: stacktool: arch/x86/crypto/crc32c-pcl-intel-asm_64.o: crc_pcl()+0x11dd: can't decode instruction It gets confused when trying to decode jump_table data. Move jump_table to the .rodata section which is a more appropriate home for read-only data. Signed-off-by: Josh Poimboeuf Reviewed-by: Borislav Petkov Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Chris J Arges Cc: David S. Miller Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Herbert Xu Cc: Jiri Slaby Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/1dbf80c097bb9d89c0cbddc01a815ada690e3b32.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S index 4fe27e0..dc05f01 100644 --- a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S +++ b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S @@ -170,8 +170,8 @@ continue_block: ## branch into array lea jump_table(%rip), bufp movzxw (bufp, %rax, 2), len - offset=crc_array-jump_table - lea offset(bufp, len, 1), bufp + lea crc_array(%rip), bufp + lea (bufp, len, 1), bufp jmp *bufp ################################################################ @@ -310,7 +310,9 @@ do_return: popq %rdi popq %rbx ret +ENDPROC(crc_pcl) +.section .rodata, "a", %progbits ################################################################ ## jump table Table is 129 entries x 2 bytes each ################################################################ @@ -324,13 +326,11 @@ JMPTBL_ENTRY %i i=i+1 .endr -ENDPROC(crc_pcl) ################################################################ ## PCLMULQDQ tables ## Table is 128 entries x 2 words (8 bytes) each ################################################################ -.section .rodata, "a", %progbits .align 8 K_table: .long 0x493c7d27, 0x00000001